Skip to content

Commit 93486b5

Browse files
committed
Gave notes subsections titles
1 parent d668c33 commit 93486b5

File tree

4 files changed

+26
-16
lines changed

4 files changed

+26
-16
lines changed

partials/section.embedded.hbs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,16 @@
3939
</figcaption>
4040
</figure><!-- End of #subsection__inline-svg -->
4141

42+
<h3>Notes:</h3>
4243
<ul>
4344
<li>
44-
<small>Note: Be sure to provide values for the <code>height</code> and <code>width</code> attributes so <abbr>SVGs</abbr> won't expand to fill the page if styles don't load.</small>
45+
<small>Be sure to provide values for the <code>height</code> and <code>width</code> attributes so <abbr>SVGs</abbr> won't expand to fill the page if styles don't load.</small>
4546
</li>
4647
<li>
47-
<small>Note: Different implementations of <abbr>SVG</abbr> have <a rel="external noopener" href="https://css-tricks.com/accessible-svgs/">different approaches for being made accessible</a>.</small>
48+
<small>Different implementations of <abbr>SVG</abbr> have <a rel="external noopener" href="https://css-tricks.com/accessible-svgs/">different approaches for being made accessible</a>.</small>
4849
</li>
4950
<li>
50-
<small>Note: Apply <code>focusable=”false”</code> to any <abbr>SVG</abbr> placed inside of <a rel="external noopener" href="http://simplyaccessible.com/article/7-solutions-svgs/#acc-heading-5">a focusable element such as a link or button</a>.</small>
51+
<small>Apply <code>focusable=”false”</code> to any <abbr>SVG</abbr> placed inside of <a rel="external noopener" href="http://simplyaccessible.com/article/7-solutions-svgs/#acc-heading-5">a focusable element such as a link or button</a>.</small>
5152
</li>
5253
</ul>
5354

@@ -123,8 +124,9 @@
123124
Please <a rel="external noopener" href="http://browsehappy.com/">consider upgrading your browser</a> or <a download href="http://clips.vorwaerts-gmbh.de/VfE_html5.mp4">download a file</a> for offline viewing.
124125
</video><!-- End of #subsection__video -->
125126

127+
<h3>Notes:</h3>
126128
<p>
127-
<small>Note: Accessibility errors concerning the video's missing audio description should go away once the <code>&lt;track&gt;</code>'s source is linked to a valid caption file.</small>
129+
<small>Accessibility errors concerning the video's missing audio description should go away once the <code>&lt;track&gt;</code>'s source is linked to a valid caption file.</small>
128130
</p>
129131

130132
<h2 id="subsection__object">Object</h2><!-- Start of #subsection__object -->

partials/section.forms.hbs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -405,12 +405,13 @@
405405
Text Button
406406
</span>
407407

408+
<h4>Notes:</h4>
408409
<ul>
409410
<li>
410-
<small>Note: Add <code>pointer-events: none;</code> to <a rel="external noopener" href="https://twitter.com/stowball/status/857707052545613824">inline SVG icons placed in buttons</a>.</small>
411+
<small>Add <code>pointer-events: none;</code> to <a rel="external noopener" href="https://twitter.com/stowball/status/857707052545613824">inline SVG icons placed in buttons</a>.</small>
411412
</li>
412413
<li>
413-
<small>Note: Use <code>tabindex="0"</code> in conjunction with <code>role="button"</code> to ensure that the text button is focusable. Use <code>cursor: pointer;</code> in the CSS to communicate that it is interactable. Learn more about <a rel="external noopener" href="https://css-tricks.com/use-button-element/"><cite>When To Use The Button Element</cite></a>.</small>
414+
<small>Use <code>tabindex="0"</code> in conjunction with <code>role="button"</code> to ensure that the text button is focusable. Use <code>cursor: pointer;</code> in the CSS to communicate that it is interactable. Learn more about <a rel="external noopener" href="https://css-tricks.com/use-button-element/"><cite>When To Use The Button Element</cite></a>.</small>
414415
</li>
415416
</ul>
416417

@@ -580,8 +581,9 @@
580581
Loading
581582
</button>
582583

584+
<h5>Notes:</h5>
583585
<p>
584-
<small>Note: Use <code>:hover</code>, <code>:focus</code>, and <code>:active</code> selectors to control the other button states. Learn more about <a rel="external noopener" href="https://medium.com/eightshapes-llc/buttons-in-design-systems-eac3acf7e23#.b1p96hsrw">Buttons in Design Systems</a>.</small>
586+
<small>Use <code>:hover</code>, <code>:focus</code>, and <code>:active</code> selectors to control the other button states. Learn more about <a rel="external noopener" href="https://medium.com/eightshapes-llc/buttons-in-design-systems-eac3acf7e23#.b1p96hsrw">Buttons in Design Systems</a>.</small>
585587
</p>
586588
</div><!-- End of #subsection__buttons -->
587589
</fieldset><!-- End of #subsection__states-and-validation -->
@@ -997,8 +999,9 @@
997999
type="file" />
9981000
</label>
9991001

1002+
<h4>Notes:</h4>
10001003
<p>
1001-
<small>Note: Be sure to reference the <a rel="external noopener" href="http://spaceninja.com/2015/12/08/falsehoods-programmers-believe/"><cite>Falsehoods Programmers Believe</cite></a> collection for creating bulletproof inputs.</small>
1004+
<small>Be sure to reference the <a rel="external noopener" href="http://spaceninja.com/2015/12/08/falsehoods-programmers-believe/"><cite>Falsehoods Programmers Believe</cite></a> collection for creating bulletproof inputs.</small>
10021005
</p>
10031006

10041007
</fieldset><!-- End of #subsection__autocomplete -->

partials/section.tables.hbs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,9 @@
8888
</tfoot>
8989
</table>
9090

91+
<h3>Notes:</h3>
9192
<p>
92-
<small>Note: Use <code>id</code> and <code>header</code> attributes for tables with complicated markup (colspans, row headers, etc.).</small>
93+
<small>Use <code>id</code> and <code>header</code> attributes for tables with complicated markup (colspans, row headers, etc.).</small>
9394
</p>
9495

9596
</section><!-- End of #section__tables -->

partials/section.text-level.hbs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,10 @@
5959
<li>Blackcurrant</li>
6060
</ul>
6161

62-
<ul>
63-
<li>
64-
<small>Note: VoiceOver will not <a rel="external noopener" href="https://unfetteredthoughts.net/2017/09/26/voiceover-and-list-style-type-none/">announce unordered lists properly when either the list-style-type is set to none or display is set to inline</a>.</small>
65-
</li>
66-
</ul>
62+
<h4>Notes:</h4>
63+
<p>
64+
<small>VoiceOver will not <a rel="external noopener" href="https://unfetteredthoughts.net/2017/09/26/voiceover-and-list-style-type-none/">announce unordered lists properly when either the list-style-type is set to none or display is set to inline</a>.</small>
65+
</p>
6766

6867
<h3>Ordered List</h3>
6968
<ol>
@@ -160,9 +159,12 @@ drwxr-xr-x 9 eric staff 306 Mar 24 13:36 .git/
160159
<li><span role="definition" aria-label="Approximately equals">≈</span></li>
161160
<li><span role="definition" aria-label="Not equals">≠</span></li>
162161
</ul>
162+
163+
<h4>Notes:</h4>
163164
<p>
164-
<small>Note: Certain screen readers will not <a rel="external noopener" href="http://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/">read certain symbols out loud</a>. Use <code>role="definition"</code> in conjunction with <code>aria-label</code> to ensure the symbol is read.</small>
165+
<small>Certain screen readers will not <a rel="external noopener" href="http://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/">read certain symbols out loud</a>. Use <code>role="definition"</code> in conjunction with <code>aria-label</code> to ensure the symbol is read.</small>
165166
</p>
167+
166168
</div><!-- End of #subsection__symbols -->
167169
<div id="subsection__emoji" aria-labelledby="subtitle__emoji"><!-- Start of #subsection__emoji -->
168170
<h3 id="subtitle__emoji">Emoji</h3>
@@ -173,8 +175,10 @@ drwxr-xr-x 9 eric staff 306 Mar 24 13:36 .git/
173175
<li><span role="img" aria-label="Snowman emoji">⛄️</span></li>
174176
<li><span role="img" aria-label="Beer emoji">🍺</span></li>
175177
</ul>
178+
179+
<h4>Notes:</h4>
176180
<p>
177-
<small>Note: Certain screen readers will not <a rel="external noopener" href="http://tink.uk/accessible-emoji/">expose emoji as images in the accessibility treee</a>. Use <code>role="img"</code> in conjunction with <code>aria-label</code> to ensure the symbol is read.</small>
181+
<small>Certain screen readers will not <a rel="external noopener" href="http://tink.uk/accessible-emoji/">expose emoji as images in the accessibility treee</a>. Use <code>role="img"</code> in conjunction with <code>aria-label</code> to ensure the symbol is read.</small>
178182
</p>
179183
</div><!-- End of #subsection__emoji -->
180184
</section><!-- End of #section__text-level -->

0 commit comments

Comments
 (0)