Skip to content

Conversation

@janogarcia
Copy link
Contributor

Fix mixed content errors for placeholder images

What does this Pull Request do?

Fixes #26

Where should the reviewer start?

Just review the modified template section.embedded.hbs and then test the compiled output.

How should this be manually tested?

View the updated docs/index.html over an SSL connection and check for any mixed content errors (e.g., Chrome DevTools Network tab).

Any background context you want to provide?

The mixed content error was preventing the affected placeholder images from being displayed.

What are the relevant tickets?

#26

Applicable screenshots

Bug in production version.

Mixed content errors highlighted in a screenshot of Chrome DevTools Network view

Additional questions

N/A

Copy link
Owner

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you so much for this update, it's a really great call.

I'm sorry it took so long to get to, it got lost in my notifications. I really appreciate the contribution, though 🎉

@ericwbailey ericwbailey merged commit a86c472 into ericwbailey:main Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-https image URLs won't load

2 participants