GitHub Links

[tomasnorre]

Hi,

I really like your initiative here. Big kudos for taking the initiative.

I saw that you are linking to: https://github.com/librarianphp/librarian and not to https://github.com/erikaheidi/sponsoross/ it looks to me like the LINK_GITHUB ENV isn't set.

[tomasnorre]

Looks like it's change already in the main branch, my bad.

It worked locally because I prepared a PR. doh!
Let me know if I should push my PR.

[erikaheidi]

Hi @tomasnorre ! Thank you for bringing that to attention. It seems the variable is not set on the production environment, indeed! At the other hand, I think we don't really need to be using the ENV for that and could just create a static list of relevant links since that would make maintenance easier in the long term, what do you think? In that case if you're up to it, I would really appreciate a PR. Initially I think we could maybe add a link to this repository, and a link to github.com/sponsors for people who want to know more or subscribe to the program.

Let me know what you think :)

[tomasnorre]

Hi.

I think we don't really need to be using the ENV for that and could just create a static list of relevant links since that would make maintenance easier in the long term, what do you think?

I think a static list should do the trick.

In that case if you're up to it, I would really appreciate a PR.

I'll if I can find some time for it.

[erikaheidi]

Sure, no worries!

[tomasnorre]

Hi @erikaheidi

How do you imagine this with the static list. The config.php is in .gitignore so I cannot adjust it there.

I see in your base.twig.html that

{% for title,link in social_links() %}

But I don't find where you fetch social_links().

Do you have a suggestion how you would like this solved?