Skip to content

Commit 6284f37

Browse files
committed
Revert "Don't send authentication to OWIF for the web/stream URL request."
This reverts commit 25a925c. webauth now used for /web/stream url as it was in the past
1 parent 07b624c commit 6284f37

File tree

7 files changed

+20
-13
lines changed

7 files changed

+20
-13
lines changed

src/clientsocket.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ ClientSocket::ClientSocket(int fd_in,
282282
Service service(urlparams["service"]);
283283

284284
Util::vlog("ClientSocket: live streaming request");
285-
(void)LiveStreaming(service, fd, streaming_parameters, config_map);
285+
(void)LiveStreaming(service, fd, webauth, streaming_parameters, config_map);
286286
Util::vlog("ClientSocket: live streaming ends");
287287

288288
return;
@@ -299,7 +299,7 @@ ClientSocket::ClientSocket(int fd_in,
299299
case(stb_transcoding_broadcom):
300300
{
301301
Util::vlog("ClientSocket: transcoding service broadcom");
302-
(void)LiveTranscodingBroadcom(service, fd, stb_traits, streaming_parameters, config_map);
302+
(void)LiveTranscodingBroadcom(service, fd, webauth, stb_traits, streaming_parameters, config_map);
303303
break;
304304
}
305305

@@ -444,7 +444,7 @@ ClientSocket::ClientSocket(int fd_in,
444444
if(default_action == action_stream)
445445
{
446446
Util::vlog("ClientSocket: streaming service");
447-
(void)LiveStreaming(service, fd, streaming_parameters, config_map);
447+
(void)LiveStreaming(service, fd, webauth, streaming_parameters, config_map);
448448
}
449449
else
450450
{
@@ -455,7 +455,7 @@ ClientSocket::ClientSocket(int fd_in,
455455
case(stb_transcoding_broadcom):
456456
{
457457
Util::vlog("ClientSocket: transcoding service broadcom");
458-
(void)LiveTranscodingBroadcom(service, fd, stb_traits, streaming_parameters, config_map);
458+
(void)LiveTranscodingBroadcom(service, fd, webauth, stb_traits, streaming_parameters, config_map);
459459
break;
460460
}
461461

src/livestreaming.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ using std::string;
1818
#include <poll.h>
1919
#include <time.h>
2020

21-
LiveStreaming::LiveStreaming(const Service &service, int socketfd,
21+
LiveStreaming::LiveStreaming(const Service &service, int socketfd, string webauth,
2222
const StreamingParameters &, const ConfigMap &config_map)
2323
{
2424
PidMap::const_iterator it;
@@ -40,7 +40,7 @@ LiveStreaming::LiveStreaming(const Service &service, int socketfd,
4040
if(!service.is_valid())
4141
throw(http_trap("LiveStreaming: invalid service", 404, "Not found, service not found"));
4242

43-
WebifRequest webifrequest(service, config_map);
43+
WebifRequest webifrequest(service, webauth, config_map);
4444

4545
for(webifrequest_ok = false; (time(0) - timeout) < 60; )
4646
{

src/livestreaming.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class LiveStreaming
1919

2020
public:
2121

22-
LiveStreaming(const Service &service, int socketfd,
22+
LiveStreaming(const Service &service, int socketfd, std::string webauth,
2323
const StreamingParameters &streaming_parameters,
2424
const ConfigMap &config_map);
2525
};

src/livetranscoding-broadcom.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ using std::string;
2121
#include <time.h>
2222

2323
LiveTranscodingBroadcom::LiveTranscodingBroadcom(const Service &service, int socketfd,
24-
const stb_traits_t &stb_traits,
24+
string webauth, const stb_traits_t &stb_traits,
2525
const StreamingParameters &streaming_parameters,
2626
const ConfigMap &config_map)
2727
{
@@ -49,7 +49,7 @@ LiveTranscodingBroadcom::LiveTranscodingBroadcom(const Service &service, int soc
4949
if(!service.is_valid())
5050
throw(http_trap("LiveTranscodingBroadcom: invalid service", 404, "Not found, unknown service"));
5151

52-
WebifRequest webifrequest(service, config_map);
52+
WebifRequest webifrequest(service, webauth, config_map);
5353

5454
for(webifrequest_ok = false; (time(0) - timeout) < 60; )
5555
{

src/livetranscoding-broadcom.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class LiveTranscodingBroadcom
3333
public:
3434

3535
LiveTranscodingBroadcom(const Service &service, int socketfd,
36-
const stb_traits_t &stb_traits,
36+
std::string webauth, const stb_traits_t &stb_traits,
3737
const StreamingParameters &streaming_parameters,
3838
const ConfigMap &config_map);
3939
};

src/webifrequest.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ static const struct addrinfo gai_webif_hints =
3535
.ai_next = 0,
3636
};
3737

38-
WebifRequest::WebifRequest(const Service &service_in, const ConfigMap &config_map_in)
38+
WebifRequest::WebifRequest(const Service &service_in,
39+
string webauth, const ConfigMap &config_map_in)
3940
:
4041
service(service_in), config_map(config_map_in)
4142
{
@@ -74,7 +75,12 @@ WebifRequest::WebifRequest(const Service &service_in, const ConfigMap &config_ma
7475

7576
freeaddrinfo(gai_webif_address);
7677

77-
request = string("GET /web/stream?StreamService=") + service.service_string() + " HTTP/1.0\r\n\r\n";
78+
request = string("GET /web/stream?StreamService=") + service.service_string() + " HTTP/1.0\r\n";
79+
80+
if(webauth.length())
81+
request += "Authorization: Basic " + webauth + "\r\n";
82+
83+
request += "\r\n";
7884

7985
Util::vlog("WebifRequest: send request to webif: \"%s\"", request.c_str());
8086

src/webifrequest.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ class WebifRequest
2626

2727
public:
2828

29-
WebifRequest(const Service &service, const ConfigMap &config_map);
29+
WebifRequest(const Service &service, std::string webauth,
30+
const ConfigMap &config_map);
3031
~WebifRequest();
3132

3233
void poll();

0 commit comments

Comments
 (0)