Merge branch 'rickard/fix-harmless-bugs-warnings/26' into maint-27

* rickard/fix-harmless-bugs-warnings/26:
  [erts] Silence faulty CodeChecker warnings
  [erts] Fix harmless initialization bug

Author: Erlang/OTP

erts/emulator/beam/bif.c

@@ -159,6 +159,8 @@ BIF_RETTYPE link_1(BIF_ALIST_1)
 	if (!prt)
 	    goto res_no_proc;
 
+        ERTS_UNDEF(ref, THE_NON_VALUE);
+
         lnk = erts_link_internal_tree_lookup_create(&ERTS_P_LINKS(BIF_P),
                                                     &created,
                                                     ERTS_LNK_TYPE_PORT,
@@ -1100,6 +1102,8 @@ BIF_RETTYPE unlink_1(BIF_ALIST_1)
             ErtsPortOpResult res = ERTS_PORT_OP_DROPPED;
 	    Port *prt;
 
+            ERTS_UNDEF(ref, THE_NON_VALUE);
+
 	    /* Send unlink signal */
 	    prt = erts_port_lookup(BIF_ARG_1, ERTS_PORT_SFLGS_DEAD);
 	    if (!prt) {

erts/emulator/beam/erl_alloc.c

@@ -2907,6 +2907,7 @@ erts_allocator_options(void *proc)
     hpp = NULL;
     szp = &sz;
     sz = 0;
+    ERTS_UNDEF(hp, NULL);
 
  bld_term:
 

erts/emulator/beam/erl_bif_info.c

@@ -3857,6 +3857,7 @@ fun_info_2(BIF_ALIST_2)
     case am_module:
         /* Unloaded funs must report their module even though we can't find
          * their full MFA. */
+        ASSERT(fe != NULL || mfa != NULL);
         val = (mfa != NULL) ? mfa->module : fe->module;
         hp = HAlloc(p, 3);
         break;

erts/emulator/beam/erl_db_hash.c

@@ -1645,6 +1645,7 @@ int db_erase_hash(DbTable *tbl, Eterm key, Eterm *ret)
 	bp = &b->next;
 	b = b->next;
     }
+    ERTS_UNDEF(nitems, -1);
     if (nitems_diff) {
         ADD_NITEMS(tb, lck_ctr, hval, nitems_diff);
         nitems = NITEMS_ESTIMATE(tb, lck_ctr, hval);
@@ -1710,6 +1711,7 @@ static int db_erase_object_hash(DbTable *tbl, Eterm object, Eterm *ret)
 	bp = &b->next;
 	b = b->next;
     }
+    ERTS_UNDEF(nitems, -1);
     if (nitems_diff) {
         ADD_NITEMS(tb, lck_ctr, hval, nitems_diff);
         nitems = NITEMS_ESTIMATE(tb, lck_ctr, hval);
@@ -2975,6 +2977,7 @@ static int db_take_hash(Process *p, DbTable *tbl, Eterm key, Eterm *ret)
             break;
         }
     }
+    ERTS_UNDEF(nitems, -1);
     if (nitems_diff) {
         ADD_NITEMS(tb, lck_ctr, hval, nitems_diff);
         nitems = NITEMS_ESTIMATE(tb, lck_ctr, hval);

erts/emulator/beam/erl_proc_sig_queue.c

@@ -4292,6 +4292,7 @@ handle_exit_signal(Process *c_p, ErtsSigRecvTracing *tracing,
     Eterm reason;
     Eterm from;
 
+    ERTS_UNDEF(reason, THE_NON_VALUE);
     ASSERT(ERTS_PROC_SIG_TYPE(tag) == ERTS_SIG_Q_TYPE_GEN_EXIT);
 
     xsigd = get_exit_signal_data(sig);
@@ -4788,6 +4789,8 @@ handle_persistent_mon_msg(Process *c_p, ErtsSigRecvTracing *tracing,
             ErtsMessage *first = NULL, *prev, *last;
             Uint hsz = size_object(msg);
             Uint i;
+            ERTS_UNDEF(last,NULL);
+            ERTS_UNDEF(prev,NULL);
 
             for (i = 0; i < n; i++) {
                 Eterm *hp;
@@ -9023,11 +9026,9 @@ erts_proc_sig_queue_try_enqueue_to_buffer(Eterm from,
         int nonmsg = ERTS_SIG_IS_NON_MSG(first);
         int restarted = 0;
         ErtsSignalInQueueBuffer* buffer;
-        Uint64 nonempty_slots_before;
+        Uint64 nonempty_slots_before = 0;
         Uint32 slot, state;
 
-        ERTS_UNDEF(nonempty_slots_before, 0);
-
         ASSERT(is_value(from));
 
         /* Use the sender id to hash to an outer signal queue buffer. This

erts/emulator/beam/erl_process.c

@@ -10726,6 +10726,7 @@ execute_sys_tasks(Process *c_p, erts_aint32_t *statep, int in_reds)
 	    if (c_p->flags & F_DISABLE_GC) {
 		save_gc_task(c_p, st, st_prio);
 		st = NULL;
+                ERTS_UNDEF(st_res, am_undefined);
 		reds--;
 	    }
 	    else {
@@ -10739,6 +10740,7 @@ execute_sys_tasks(Process *c_p, erts_aint32_t *statep, int in_reds)
 		    if (c_p->flags & (F_DIRTY_MAJOR_GC|F_DIRTY_MINOR_GC)) {
 			save_dirty_task(c_p, st);
 			st = NULL;
+                        ERTS_UNDEF(st_res, am_undefined);
 			break;
 		    }
 		    if (type == ERTS_PSTT_GC_MAJOR)
@@ -10781,6 +10783,7 @@ execute_sys_tasks(Process *c_p, erts_aint32_t *statep, int in_reds)
                  * but instead unconditionally schedule this as dirty
                  * work...
                  */
+                ERTS_UNDEF(st_res, am_undefined);
                 if (c_p->flags & F_DISABLE_GC) {
                     /* We might need to GC, but GC was disabled */
                     save_gc_task(c_p, st, st_prio);
@@ -13031,8 +13034,10 @@ erts_send_local_spawn_reply(Process *parent, ErtsProcLocks parent_locks,
 
     type = child ? am_ok : am_error;
 
-    if (have_seqtrace(token) && child)
+    if (have_seqtrace(token) && child) {
         token_sz = size_object(token);
+        ERTS_UNDEF(token_copy, NIL);
+    }
     else {
         token_copy = token = NIL;
         token_sz = 0;