Skip to content

Commit 494e145

Browse files
committed
erts: Improve READEME.pcre_update.md
1 parent 883d887 commit 494e145

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

erts/emulator/pcre/README.pcre_update.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ like this in the C source:
238238
When building, pcre2\_match\_loop\_break\_cases.gen.h will be generated
239239
during build by pcre.mk, it will look like:
240240

241-
case 791: goto L_LOOP_COUNT_691;
242-
case 1892: goto L_LOOP_COUNT_1792;
243-
case 1999: goto L_LOOP_COUNT_1899;
241+
case 791: goto L_LOOP_COUNT_791;
242+
case 1892: goto L_LOOP_COUNT_1892;
243+
case 1999: goto L_LOOP_COUNT_1999;
244244

245245
etc
246246

@@ -304,12 +304,11 @@ from pcre.mk. Note that you will need to put things back in order in
304304
pcre.mk after all testing is done. Once a 'make' is successful, you
305305
can generate new dependencies:
306306

307-
~/tmp/pcre/epcre-8.33> gcc -MM -c -g -O2 -DHAVE_CONFIG_H -I/ldisk/pan/git/otp/erts/x86_64-unknown-linux-gnu -DERLANG_INTEGRATION *.c | grep -v $ERL_TOP
307+
~/tmp/pcre/epcre-8.33> gcc -MM -c -DERLANG_INTEGRATION *.c | sed ...
308308

309-
Well, then you have to add $(PCRE\_OBJDIR)/ to each object and
310-
$(PCRE\_DIR)/ to each header. I did it manually, it's just a couple of
311-
files. Now your pcre.mk is fairly up to date and it's time to start
312-
patching in the changes...
309+
pcre.mk contains a full gcc command line with sed that adds $(PCRE\_OBJDIR)/
310+
to each object file and $(PCRE\_DIR)/ to each source file. Now your pcre.mk is
311+
fairly up to date and it's time to start patching in the changes...
313312

314313
## Updating pcre2_match.c
315314

@@ -473,7 +472,7 @@ fix whatever you did in pcre.mk to make it build locally.
473472
## Update test suites
474473

475474
The next step is to integrate the updated PCRE2 tests into our test suites.
476-
Copy testoutput[1-5,10] from the testdata directory of your new version
475+
Copy testoutput[1,2,4,5,10] from the testdata directory of your new version
477476
of pcre2, to the re\_SUITE\_data in stdlib's test suites. Run the
478477
test suites and remove any bugs. Usually the bugs come from the fact
479478
that the PCRE test suites get better and from our implementation of

0 commit comments

Comments
 (0)