Skip to content

Commit 6b9de88

Browse files
author
Erlang/OTP
committed
Merge branch 'dgud/patch-26/kvakvs/nsis-deleteregkey-api-change/OTP-19683' into maint-27
* dgud/patch-26/kvakvs/nsis-deleteregkey-api-change/OTP-19683: Add extra uninstall removal instructions, thanks to @inikulshin Bugfix: API change in NSIS scripting as of 3.0.6 (July 2020) in DeleteRegKey use /ifnosubkeys for old behaviour
2 parents 1e17e71 + 154c641 commit 6b9de88

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

erts/etc/win32/nsis/erlang20.nsi

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -482,12 +482,16 @@ continue_delete:
482482

483483
noshortcuts:
484484
; We delete both in HKCU and HKLM, we don't really know were they might be...
485-
DeleteRegKey /ifempty HKLM "SOFTWARE\Ericsson\Erlang\${ERTS_VERSION}"
486-
DeleteRegKey /ifempty HKCU "SOFTWARE\Ericsson\Erlang\${ERTS_VERSION}"
487-
DeleteRegKey HKLM \
488-
"SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Erlang OTP"
489-
DeleteRegKey HKCU \
490-
"SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Erlang OTP"
485+
DeleteRegKey /ifnosubkeys HKCU "SOFTWARE\Ericsson\Erlang\${ERTS_VERSION}"
486+
DeleteRegKey /ifnosubkeys HKCU "SOFTWARE\Ericsson\Erlang"
487+
DeleteRegKey /ifnosubkeys HKCU "SOFTWARE\Ericsson"
488+
489+
DeleteRegKey /ifnosubkeys HKLM "SOFTWARE\Ericsson\Erlang\${ERTS_VERSION}"
490+
DeleteRegKey /ifnosubkeys HKLM "SOFTWARE\Ericsson\Erlang"
491+
DeleteRegKey /ifnosubkeys HKLM "SOFTWARE\Ericsson"
492+
493+
DeleteRegKey HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Erlang OTP"
494+
DeleteRegKey HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Erlang OTP"
491495

492496

493497
; Now remove shell/file associations we'we made...

0 commit comments

Comments
 (0)