ssh: fix cli testcase in Windows

- add FIXME comment for logger events verification in parallel groups

Author: u3s

lib/ssh/test/ssh_basic_SUITE.erl

@@ -234,6 +234,10 @@ end_per_testcase(TestCase, Config)
 end_per_testcase(TestCase, Config) ->
     process_events(TestCase, Config).
 
+%% FIXME in parallel executions (p_basic group) this setup does not
+%% work log handlers are uniq per testcase, but they all receive same
+%% logger events; so if one testcase fails due to logger events, rest
+%% of group might fail as well
 process_events(TestCase, Config) ->
     {ok, Events} = ssh_test_lib:get_log_events(
                      proplists:get_value(log_handler_ref, Config)),

lib/ssh/test/ssh_test_cli.erl

@@ -74,7 +74,11 @@ terminate(_Why, _S) ->
     nop.
 
 run_portprog(User, cli, TmpDir) ->
-    Pty_bin = os:find_executable("cat"),
+    Cmd = case os:type() of
+              {win32, _} -> "cmd.exe";
+              _ -> "cat"
+          end,
+    Pty_bin = os:find_executable(Cmd),
     ct:pal("Pty_bin = ~p", [Pty_bin]),
     ssh_test_lib:open_port({spawn_executable, Pty_bin},
 			   [stream,