-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: mnesia select/3,4 doc update #10416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CT Test Results 2 files 59 suites 18m 33s ⏱️ Results for commit f3353fd. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
Hi, While you're at it would it be ok for you to fix other cases as well? |
|
We're still missing some stuff. Also you want to merge this to master, but your branch is based on otp 27, so you don't see some functions in your branch (select_reverse stuff), I think it would be better if you rebased to master. This are the problems I still see: |
| [`foldr/3`](`foldr/3`) and [`foldl/3`](`foldl/3`) are synonyms. | ||
| """. | ||
| -spec foldr(Fun, Acc0, Tab::table(), LockKind::lock_kind()) -> Acc when | ||
| -spec foldr(Fun, Acc0, Tabble::table(), LockKind::lock_kind()) -> Acc when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 'Table', instead of 'Tabble'
|
It's still WIP, I struggle to find time to finish this, but thanks for corrections. I'll rebase it to master. |
|
Ok thanks for the info. I've marked it as draft then, please convert it back to normal PR once you finish :) |
In
mnesia:select/3:SpectoMatchSpec(which is referenced from the doc section)In
mnesia:select/4:SpectoMatchSpec(which is referenced from the doc section)NtoNObjects(which is referenced from the doc section)TLDR: synchronization between variable names in specs and docs