Skip to content

Conversation

@MarkoMin
Copy link
Contributor

@MarkoMin MarkoMin commented Nov 27, 2025

In mnesia:select/3:

  1. renamed Spec to MatchSpec (which is referenced from the doc section)

In mnesia:select/4:

  1. renamed Spec to MatchSpec (which is referenced from the doc section)
  2. renamed N to NObjects (which is referenced from the doc section)

TLDR: synchronization between variable names in specs and docs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

CT Test Results

  2 files   59 suites   18m 33s ⏱️
695 tests 544 ✅ 151 💤 0 ❌
750 runs  584 ✅ 166 💤 0 ❌

Results for commit f3353fd.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Dec 1, 2025
@Mikaka27 Mikaka27 self-assigned this Dec 2, 2025
@Mikaka27
Copy link
Contributor

Mikaka27 commented Dec 2, 2025

Hi,

While you're at it would it be ok for you to fix other cases as well?
I see for example:

activity/4 (this one has also list of functions passed to AccessMod if it's used)
add_table_copy/3
add_table_index/3 (to be consistent with del_table_index which has a doc section)
backup_checkpoint/3
change_table_majority/2
create_schema/1
del_table_copy/2
del_table_index/2
delete_schema/1 (to be consistent with create_schema and doc section)
dirty_select/2 (to be consistent with your changes in select)
dirty_select_reverse/2 (same as above)
foldl/3 (to be consistent with foldl/4)
foldl/4
foldr/3 (to be consistent with foldr/4)
foldr/4
install_fallback/2
move_table_copy/3 (to be consistent with add_table_copy/3, and del_table_copy/3)
restore/2
select_reverse/3 (to be consistent with select/3)
select_reverse/4 (to be consistent with select/4)
set_master_nodes/1
set_master_nodes/2
snmp_open_table/2
subscribe/1
transform_table/3 (to be consistent with transform_table/4)
transform_table/4
traverse_backup/4 (to be consistent with traverse_backup/6)
traverse_backup/6
unsubscribe/1 (to be consistent with subscribe/1)
wait_for_tables/2

@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label Dec 2, 2025
@Mikaka27 Mikaka27 removed the waiting waiting for changes/input from author label Dec 5, 2025
@Mikaka27
Copy link
Contributor

We're still missing some stuff. Also you want to merge this to master, but your branch is based on otp 27, so you don't see some functions in your branch (select_reverse stuff), I think it would be better if you rebased to master.

This are the problems I still see:

add_table_copy/3 (parameter N should be Node)
backup_checkpoint/3 (parameter Mod should be BackupMod)
change_table_access_mode/2 (parameter Mode should be AccessMode)
change_table_majority/2 (parameter M should be Majority)
del_table_copy/2 (parameter N should be Node)
dirty_select_reverse/2 (parameter Spec should be MatchSpec)
install_fallback/1 (parameter Src should be Source)
install_fallback/2 (spec calls parameter Opt, but doc says Args)
restore/2 (parameter Opaque in docs, but Src in spec)
select_reverse/3 (you don't have it on your branch)
select_reverse/4 (you don't have it on your branch)
set_master_nodes/1 (parameter NS in spec, but MasterNodes in docs)
set_master_nodes/2 (parameter NS in spec, but MasterNodes in docs)
snmp_open_table/2 (parameter Snmp in spec, but SnmpStruct in docs)
subscribe/1 (paramter What in spec, but EventCategory in docs)
transform_table/3 (parameter Attr in spec, but NewAttributeList in docs)
transform_table/4 (parameters NewA and NewRN)
traverse_backup/4 (parameters Src and Dest, are called Source and Target in traverse_backup/6)
unsubscribe/1 (parameter What in spec, but EventCategory in docs)

@Mikaka27 Mikaka27 added the waiting waiting for changes/input from author label Dec 10, 2025
[`foldr/3`](`foldr/3`) and [`foldl/3`](`foldl/3`) are synonyms.
""".
-spec foldr(Fun, Acc0, Tab::table(), LockKind::lock_kind()) -> Acc when
-spec foldr(Fun, Acc0, Tabble::table(), LockKind::lock_kind()) -> Acc when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'Table', instead of 'Tabble'

@MarkoMin
Copy link
Contributor Author

It's still WIP, I struggle to find time to finish this, but thanks for corrections. I'll rebase it to master.

@Mikaka27 Mikaka27 marked this pull request as draft December 10, 2025 09:43
@Mikaka27
Copy link
Contributor

Ok thanks for the info. I've marked it as draft then, please convert it back to normal PR once you finish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:PS Assigned to OTP team PS waiting waiting for changes/input from author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants