fix: don't normalize multiple spaces

WIP

Author: jdkato

internal/check/substitution.go

@@ -113,7 +113,7 @@ func (s Substitution) Run(blk nlp.Block, _ *core.File, cfg *core.Config) ([]core
 					return alerts, err
 				}
 
-				observed := strings.TrimSpace(converted)
+				observed := converted
 				expected, msgErr := subMsg(s, (idx/2)-1, observed)
 				if msgErr != nil {
 					return alerts, msgErr

internal/core/util.go

@@ -13,7 +13,6 @@ import (
 var defaultIgnoreDirectories = []string{
 	"node_modules", ".git",
 }
-var spaces = regexp.MustCompile(" +")
 var reANSI = regexp.MustCompile("[\u001B\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(?:;[a-zA-Z\\d]*)*)?\u0007)|(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PRZcf-ntqry=><~]))")
 var sanitizer = strings.NewReplacer(
 	"&rsquo;", "'",
@@ -39,12 +38,9 @@ func StripANSI(s string) string {
 	return reANSI.ReplaceAllString(s, "")
 }
 
-// WhitespaceToSpace converts newlines and multiple spaces (e.g., "  ") into a
-// single space.
+// WhitespaceToSpace converts newlines into a single space.
 func WhitespaceToSpace(msg string) string {
-	msg = strings.ReplaceAll(msg, "\n", " ")
-	msg = spaces.ReplaceAllString(msg, " ")
-	return msg
+	return strings.ReplaceAll(msg, "\n", " ")
 }
 
 // ShouldIgnoreDirectory will check if directory should be ignored

testdata/features/checks.feature

@@ -109,11 +109,11 @@ Feature: Checks
             test.md:23:1:Bugs.TermCase:Use 'iOS' rather than IOS.
             test.md:25:1:Bugs.SameCase:Use 'MPL 2.0' instead of 'mpl 2.0'
             test.md:27:1:Bugs.SameCase:Use 'MPL 2.0' instead of 'MPL2.0'
-            test.md:31:15:Bugs.EmptyReplace:Use instead of 'obvious'.
+            test.md:31:15:Bugs.EmptyReplace:Use  instead of 'obvious'.
             test2.md:3:1:demo.CapSub:Use 'Change to the `/etc` directory' instead of 'Change into the `/etc` directory'.
             test2.md:7:1:demo.CapSub:Use 'Change to the `/home/user` directory' instead of 'Change into the `/home/user` directory'.
             test2.md:9:1:demo.CapSub:Use 'Change to the `/etc/X11` directory' instead of 'Change into the `/etc/X11` directory'.
-            test2.md:11:6:Bugs.WrongExp:Use 'versus' instead of 'vs'.
+            test2.md:11:6:Bugs.WrongExp:Use 'versus' instead of 'vs '.
             """
 
     Scenario: Sequence

testdata/features/styles.feature

@@ -56,7 +56,7 @@ Feature: Styles
             test.mdx:1:3:demo.HeadingStartsWithCapital:'this is a heading' should be capitalized
             test.mdx:9:4:demo.ScopedHeading:'this is another heading!' should be in title case
             test.rst:1:22:demo.CommasPerSentence:More than 3 commas!
-            test.rst:1:58:demo.Spacing:'. I' should have one space
+            test.rst:1:58:demo.Spacing:'.  I' should have one space
             test.rst:3:1:demo.SentenceLength:Sentences should be less than 25 words
             test.rst:5:28:demo.Ending-Preposition:Don't end a sentence with 'by.'
             test.rst:9:1:demo.ParagraphLength:Paragraphs should be less than 150 words