More Rubocop fixes (#149)

* Fix rubocop warnings

* Remove JRuby

Author: biow0lf

README.md

@@ -1,7 +1,6 @@
 # ErrbitPlugin
 
 [![RSpec](https://github.com/errbit/errbit_plugin/actions/workflows/rspec.yml/badge.svg)](https://github.com/errbit/errbit_plugin/actions/workflows/rspec.yml)
-[![RSpec on JRuby](https://github.com/errbit/errbit_plugin/actions/workflows/jruby.yml/badge.svg)](https://github.com/errbit/errbit_plugin/actions/workflows/jruby.yml)
 [![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/standardrb/standard)
 
 ErrbitPlugin provides a set of base classes that you can extend to create
@@ -19,7 +18,7 @@ plugin you can create, and that is the issue tracker.
 ### Issue Trackers
 
 An issue tracker plugin is a Ruby class that enables you to link errors within
-errbit to an issue in an external issue tracker like Github. An app within
+errbit to an issue in an external issue tracker like GitHub. An app within
 errbit can be associated an issue tracker or not. When there is an association,
 errbit users can choose 'create issue' from an error page which will both
 create an issue on the external issue tracker out of the given error and link
@@ -133,4 +132,4 @@ end
 ## Contributing
 
 Discuss any changes you'd like to make with the authors on the mailing list, or
-by opening a github issue.
+by opening a GitHub issue.

lib/errbit_plugin/none_issue_tracker.rb

@@ -44,11 +44,11 @@ def url
       ""
     end
 
-    def create_issue(*)
+    def create_issue(*) # rubocop:disable Naming/PredicateMethod
       false
     end
 
-    def close_issue(*)
+    def close_issue(*) # rubocop:disable Naming/PredicateMethod
       false
     end
   end

spec/errbit_plugin/issue_tracker_validator_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe ErrbitPlugin::IssueTrackerValidator do
   describe "#valid?" do
     context "with a complete class" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -26,7 +26,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -49,7 +49,7 @@ def url
     end
 
     context "with class not inherit from ErrbitPlugin::IssueTracker" do
-      klass = Class.new do
+      klass = Class.new do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -73,7 +73,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -102,7 +102,7 @@ def url
     end
 
     context "with no label method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.note
           "foo"
         end
@@ -119,7 +119,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -148,7 +148,7 @@ def url
     end
 
     context "with no icons method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.note
           "foo"
         end
@@ -165,7 +165,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -194,7 +194,7 @@ def url
     end
 
     context "without fields method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -211,7 +211,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -240,7 +240,7 @@ def url
     end
 
     context "without configured? method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -257,7 +257,7 @@ def self.icons
           {}
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -286,7 +286,7 @@ def url
     end
 
     context "without errors method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -332,7 +332,7 @@ def url
     end
 
     context "without create_issue method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -353,7 +353,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -379,7 +379,7 @@ def url
 
     context "without close_issue method" do
       # this is an optional method
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -400,7 +400,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -425,7 +425,7 @@ def url
     end
 
     context "without url method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -446,7 +446,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end
 
@@ -471,7 +471,7 @@ def close_issue
     end
 
     context "without note method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
+      klass = Class.new(ErrbitPlugin::IssueTracker) do # rubocop:disable RSpec/LeakyLocalVariable
         def self.label
           "foo"
         end
@@ -488,7 +488,7 @@ def configured?
           true
         end
 
-        def errors
+        def errors # rubocop:disable Naming/PredicateMethod
           true
         end