Round target temperatures when they are being set

Author: Vilppu Vuorinen

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Changed
 - Guard against zero Ata device energy meter reading. Latest firmware returns occasional zeroes breaking energy consumption integrations.
+- Round temperatures being set to the nearest temperature_increment using round half up.
 
 ## [2.11.0] - 2021-10-03
 ### Added

pymelcloud/ata_device.py

@@ -156,7 +156,7 @@ def apply_write(self, state: Dict[str, Any], key: str, value: Any):
         flags = state.get(EFFECTIVE_FLAGS, 0)
 
         if key == PROPERTY_TARGET_TEMPERATURE:
-            state["SetTemperature"] = value
+            state["SetTemperature"] = self.round_temperature(value)
             flags = flags | 0x04
         elif key == PROPERTY_OPERATION_MODE:
             state["OperationMode"] = _operation_mode_to(value)

pymelcloud/atw_device.py

@@ -297,28 +297,28 @@ def apply_write(self, state: Dict[str, Any], key: str, value: Any):
         flags = state.get(EFFECTIVE_FLAGS, 0)
 
         if key == PROPERTY_TARGET_TANK_TEMPERATURE:
-            state["SetTankWaterTemperature"] = value
+            state["SetTankWaterTemperature"] = self.round_temperature(value)
             flags |= 0x1000000000020
         elif key == PROPERTY_OPERATION_MODE:
             state["ForcedHotWaterMode"] = value == OPERATION_MODE_FORCE_HOT_WATER
             flags |= 0x10000
         elif key == PROPERTY_ZONE_1_TARGET_TEMPERATURE:
-            state["SetTemperatureZone1"] = value
+            state["SetTemperatureZone1"] = self.round_temperature(value)
             flags |= 0x200000080
         elif key == PROPERTY_ZONE_2_TARGET_TEMPERATURE:
-            state["SetTemperatureZone2"] = value
+            state["SetTemperatureZone2"] = self.round_temperature(value)
             flags |= 0x800000200
         elif key == PROPERTY_ZONE_1_TARGET_HEAT_FLOW_TEMPERATURE:
-            state["SetHeatFlowTemperatureZone1"] = value
+            state["SetHeatFlowTemperatureZone1"] = self.round_temperature(value)
             flags |= 0x1000000000000
         elif key == PROPERTY_ZONE_1_TARGET_COOL_FLOW_TEMPERATURE:
-            state["SetCoolFlowTemperatureZone1"] = value
+            state["SetCoolFlowTemperatureZone1"] = self.round_temperature(value)
             flags |= 0x1000000000000
         elif key == PROPERTY_ZONE_2_TARGET_HEAT_FLOW_TEMPERATURE:
-            state["SetHeatFlowTemperatureZone2"] = value
+            state["SetHeatFlowTemperatureZone2"] = self.round_temperature(value)
             flags |= 0x1000000000000
         elif key == PROPERTY_ZONE_2_TARGET_COOL_FLOW_TEMPERATURE:
-            state["SetCoolFlowTemperatureZone2"] = value
+            state["SetCoolFlowTemperatureZone2"] = self.round_temperature(value)
             flags |= 0x1000000000000
         elif key == PROPERTY_ZONE_1_OPERATION_MODE:
             state["OperationModeZone1"] = value

pymelcloud/device.py

@@ -60,6 +60,15 @@ def get_state_prop(self, name: str) -> Optional[Any]:
             return None
         return self._state.get(name)
 
+    def round_temperature(self, temperature: float) -> float:
+        """Round a temperature to the nearest temperature increment."""
+        increment = self.temperature_increment
+        if temperature < 0:
+            half_increment = -increment / 2.0
+        else:
+            half_increment = increment / 2.0
+        return round((temperature + half_increment) / increment) * increment
+
     @abstractmethod
     def apply_write(self, state: Dict[str, Any], key: str, value: Any):
         """Apply writes to state object.