Clean it a bit...

Author: erwindouna

README.md

@@ -29,7 +29,7 @@ availability issues.
 
 * Air-to-air heat pumps (DeviceType=0)
 * Air-to-water heat pumps (DeviceType=1)
-* Energy Recovery Ventilators (DeviceType=3) 
+* Energy Recovery Ventilators (DeviceType=3)
 
 ## Read
 

src/pymelcloud/__init__.py

@@ -1,26 +1,29 @@
 """MELCloud client library."""
+
 from datetime import timedelta
 from typing import Dict, List, Optional
 
 from aiohttp import ClientSession
 
 from pymelcloud.ata_device import AtaDevice
 from pymelcloud.atw_device import AtwDevice
-from pymelcloud.erv_device import ErvDevice
 from pymelcloud.client import Client as _Client
 from pymelcloud.client import login as _login
 from pymelcloud.const import DEVICE_TYPE_ATA, DEVICE_TYPE_ATW, DEVICE_TYPE_ERV
 from pymelcloud.device import Device
+from pymelcloud.erv_device import ErvDevice
 
 
 async def login(
-    email: str, password: str, session: Optional[ClientSession] = None,
+    email: str,
+    password: str,
+    session: Optional[ClientSession] = None,
 ) -> str:
     """Log in to MELCloud with given credentials.
 
     Returns access token.
     """
-    _client = await _login(email, password, session,)
+    _client = await _login(email, password, session)
     return _client.token
 
 
@@ -37,9 +40,10 @@ async def get_devices(
     should be fetched only once during application life cycle to leverage the request
     pooling and rate limits.
 
-    Keyword arguments:
+    Keyword Arguments:
         conf_update_interval -- rate limit for fetching device confs. (default = 5 min)
         device_set_debounce -- debounce time for writing device state. (default = 1 s)
+
     """
     _client = _Client(
         token,

src/pymelcloud/ata_device.py

@@ -1,9 +1,10 @@
 """Air-To-Air (DeviceType=0) device definition."""
+
 from datetime import timedelta
 from typing import Any, Dict, List, Optional
 
-from pymelcloud.device import EFFECTIVE_FLAGS, Device
 from pymelcloud.client import Client
+from pymelcloud.device import EFFECTIVE_FLAGS, Device
 
 PROPERTY_TARGET_TEMPERATURE = "target_temperature"
 PROPERTY_OPERATION_MODE = "operation_mode"

src/pymelcloud/atw_device.py

@@ -1,4 +1,5 @@
 """Air-To-Water (DeviceType=1) device definition."""
+
 from typing import Any, Callable, Dict, List, Optional
 
 from pymelcloud.device import EFFECTIVE_FLAGS, Device
@@ -209,7 +210,7 @@ async def set_target_flow_temperature(self, target_flow_temperature):
         """Set target flow temperature for the currently active operation mode."""
         op_mode = self.operation_mode
         if op_mode is None:
-            return None
+            return
 
         if op_mode in [
             ZONE_OPERATION_MODE_COOL_THERMOSTAT,

src/pymelcloud/client.py

@@ -1,4 +1,5 @@
 """MEL API access."""
+
 from datetime import datetime, timedelta
 from typing import Any, Dict, List, Optional
 
@@ -209,7 +210,7 @@ async def fetch_energy_report(self, device) -> Optional[Dict[Any, Any]]:
                 "DeviceId": device_id,
                 "UseCurrency": False,
                 "FromDate": f"{from_str}T00:00:00",
-                "ToDate": f"{to_str}T00:00:00"
+                "ToDate": f"{to_str}T00:00:00",
             },
             raise_for_status=True,
         ) as resp:

src/pymelcloud/device.py

@@ -1,17 +1,18 @@
 """Base MELCloud device."""
+
 import asyncio
 from abc import ABC, abstractmethod
 from datetime import datetime, timedelta, timezone
-from decimal import Decimal, ROUND_HALF_UP
+from decimal import ROUND_HALF_UP, Decimal
 from typing import Any, Dict, List, Optional
 
 from pymelcloud.client import Client
 from pymelcloud.const import (
+    ACCESS_LEVEL,
     DEVICE_TYPE_LOOKUP,
     DEVICE_TYPE_UNKNOWN,
     UNIT_TEMP_CELSIUS,
     UNIT_TEMP_FAHRENHEIT,
-    ACCESS_LEVEL,
 )
 
 PROPERTY_POWER = "power"
@@ -64,18 +65,21 @@ def get_state_prop(self, name: str) -> Optional[Any]:
 
     def round_temperature(self, temperature: float) -> float:
         """Round a temperature to the nearest temperature increment."""
-        return float(
-            Decimal(str(temperature / self.temperature_increment))
-            .quantize(Decimal('1'), rounding=ROUND_HALF_UP)
-        ) * self.temperature_increment
+        return (
+            float(
+                Decimal(str(temperature / self.temperature_increment)).quantize(
+                    Decimal("1"), rounding=ROUND_HALF_UP
+                )
+            )
+            * self.temperature_increment
+        )
 
     @abstractmethod
     def apply_write(self, state: Dict[str, Any], key: str, value: Any):
         """Apply writes to state object.
 
         Used for property validation, do not modify device state.
         """
-        pass
 
     async def update(self):
         """Fetch state of the device from MELCloud.
@@ -217,7 +221,7 @@ def daily_energy_consumed(self) -> Optional[float]:
 
         consumption = 0
 
-        for mode in ['Heating', 'Cooling', 'Auto', 'Dry', 'Fan', 'Other']:
+        for mode in ["Heating", "Cooling", "Auto", "Dry", "Fan", "Other"]:
             previous_reports = self._energy_report.get(mode, [0.0])
             if previous_reports:
                 last_report = previous_reports[-1]

src/pymelcloud/erv_device.py

@@ -1,4 +1,5 @@
 """Energy-Recovery-Ventilation (DeviceType=3) device definition."""
+
 from typing import Any, Dict, List, Optional
 
 from pymelcloud.device import EFFECTIVE_FLAGS, Device

tests/samples/ata_get.json

@@ -31,4 +31,4 @@
     "Offline": true,
     "Scene": null,
     "SceneOwner": null
-}
+}

tests/samples/ata_listdevice.json

@@ -177,4 +177,4 @@
 	"CanSetTemperatureIncrementOverride": true,
 	"CanDisableLocalController": true
     }
- }
+ }

tests/samples/atw_1zone_get.json

@@ -151,4 +151,4 @@
     "Offline": false,
     "Units": [
     ]
-}
+}