Skip to content

Commit 1b986be

Browse files
committed
add code review suggestions
1 parent 4112a5f commit 1b986be

File tree

3 files changed

+3
-44
lines changed

3 files changed

+3
-44
lines changed

src/Quantum/misc_known_codes.jl

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -8,46 +8,6 @@
88
# Subsystem codes
99
#############################
1010

11-
"""
12-
[[9, 1, 4, 3]] gauged Shor code from [poulin2005stabilizer](@cite)
13-
14-
```jldoctest
15-
julia> using CodingTheory, Oscar;
16-
17-
julia> code = GaugedShorCode();
18-
19-
julia> length(code), dimension(code), code.r
20-
(9, 1, 4)
21-
22-
julia> code.stabs_stand
23-
[1 0 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0]
24-
[0 1 0 0 1 1 1 1 1 0 0 0 0 0 0 0 0 0]
25-
[0 0 0 0 0 0 0 0 0 1 1 1 0 1 0 1 1 0]
26-
[0 0 0 0 0 0 0 0 0 1 0 0 1 1 1 0 1 1]
27-
28-
julia> code.logicals
29-
1-element Vector{Tuple{fpMatrix, fpMatrix}}:
30-
([0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 1], [1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0])
31-
32-
julia> code.X_stabs
33-
[1 1 1 1 1 1 0 0 0]
34-
[1 1 1 0 0 0 1 1 1]
35-
36-
julia> code.Z_stabs
37-
[1 1 0 1 1 0 1 1 0]
38-
[0 1 1 0 1 1 0 1 1]
39-
40-
julia> code.g_ops_mat
41-
[0 0 0 0 0 0 0 0 0 0 1 1 0 0 0 0 0 0]
42-
[0 0 1 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0]
43-
[0 0 0 0 0 0 0 0 0 0 0 0 0 1 1 0 0 0]
44-
[0 0 0 0 0 1 0 0 1 0 0 0 0 0 0 0 0 0]
45-
[0 0 0 0 0 0 0 0 0 1 1 0 0 0 0 0 0 0]
46-
[1 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0]
47-
[0 0 0 0 0 0 0 0 0 0 0 0 1 1 0 0 0 0]
48-
[0 0 0 1 0 0 1 0 0 0 0 0 0 0 0 0 0 0]
49-
```
50-
"""
5111
function GaugedShorCode()
5212
# Poulin, "Stabilizer Formalism for Operator Quantum Error Correction", (2008)
5313
# [[9, 1, 4, 3]] gauged Shor code
@@ -183,7 +143,6 @@ function BravyiBaconShorCode(A::CTMatrixTypes)
183143
# but this is corrected here to match
184144
# X - consequetive column pairs
185145
X_gauges = zero_matrix(F, sum([col_wts[i] - 1 for i in 1:length(col_wts)]), n)
186-
typeof(X_gauges)
187146
curr_row = 1
188147
F_one = F(1)
189148
for c in 1:nc

src/Quantum/product_codes.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1166,7 +1166,7 @@ Return the coprime bivariate bicycle code defined by the residue ring elements `
11661166
11671167
# Note
11681168
1169-
- This is defined in https://arxiv.org/pdf/2408.10001v1.
1169+
- This is defined in https://arxiv.org/pdf/2408.10001.
11701170
"""
11711171
function CoprimeBivariateBicycleCode(a::ResElem, b::ResElem)
11721172
R = parent(a)

test/Quantum/product_codes_test.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,8 +399,8 @@
399399
@test length(SPCtest) == 512
400400
@test dimension(SPCtest) == 174
401401
@test_broken minimum_distance(SPCtest) == 8
402-
@test_broken H_X == SPCtest.X_stabs
403-
@test_broken H_Z == SPCtest.Z_stabs
402+
@test H_X == SPCtest.X_stabs
403+
@test H_Z == SPCtest.Z_stabs
404404
end
405405

406406
@testset "BivariateBicycleCode" begin

0 commit comments

Comments
 (0)