RIS updates

Author: esabo

Manifest.toml

@@ -2,7 +2,7 @@
 
 julia_version = "1.10.5"
 manifest_format = "2.0"
-project_hash = "26354b5f3440d58ba825c3a08bb43d55c1f95c59"
+project_hash = "2d6645f27d1e47bd5cddd8a51982054007baf2cb"
 
 [[deps.ASL_jll]]
 deps = ["Artifacts", "JLLWrappers", "Libdl", "Pkg"]
@@ -562,6 +562,12 @@ version = "1.4.3"
 deps = ["Unicode"]
 uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 
+[[deps.ProgressMeter]]
+deps = ["Distributed", "Printf"]
+git-tree-sha1 = "8f6bc219586aef8baf0ff9a5fe16ee9c70cb65e4"
+uuid = "92933f4c-e287-5a05-a399-4b506db050ca"
+version = "1.10.2"
+
 [[deps.PtrArrays]]
 git-tree-sha1 = "77a42d78b6a92df47ab37e177b2deac405e1c88f"
 uuid = "43287f4e-b6f4-7ad1-bb20-aadabca52c3d"

Project.toml

@@ -13,6 +13,7 @@ Graphs = "86223c79-3864-5bf0-83f7-82e725a168b6"
 JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 Oscar = "f1435218-dba5-11e9-1e4d-f1a5fab5fc13"
+ProgressMeter = "92933f4c-e287-5a05-a399-4b506db050ca"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"

src/Classical/weight_dist.jl

@@ -1019,18 +1019,23 @@ function minimum_words(C::AbstractLinearCode)
     end
 end
 
+"""
+    random_information_set_minimum_distance_bound!(C::AbstractLinearCode; max_iters::Int = 10000, verbose::Bool = false)
 
+Return an upper bound on the minimum distance of `C` and a codeword of that weight using
+`max_iters` random information sets.
+"""
 function random_information_set_minimum_distance_bound!(C::AbstractLinearCode; max_iters::Int = 10000, verbose::Bool = false)
 
-    println("here")
     order(field(C)) == 2 || throw(DomainError(C, "Currently only implemented for binary codes."))
     is_positive(max_iters) || throw(DomainError(max_iters, "The number of iterations must be a positive integer."))
 
     !ismissing(C.d) && (println("Distance already known"); return C.d;)
     verbose && println("Bounding the distance")
     G = _Flint_matrix_to_Julia_T_matrix(_rref_no_col_swap(C.G), UInt8)
+    G = _remove_empty(G, :rows)
     upper, ind  = _min_wt_row(G)
-    found = _Flint_matrix_to_Julia_T_matrix(G[ind:ind, :], UInt8)
+    found = G[ind, :]
     # TODO this can contradict C.u_bound cause that requires a different found
     verbose && println("Starting lower bound: $(C.l_bound)")
     verbose && println("Starting upper bound: $upper")
@@ -1042,7 +1047,7 @@ function random_information_set_minimum_distance_bound!(C::AbstractLinearCode; m
     return uppers[loc], matrix(field(C), permutedims(founds[loc]))
 end
 
-function _RIS_bound_loop!(operators_to_reduce::Matrix{T}, curr_l_bound::Int, curr_u_bound::Int,
+function _RIS_bound_loop(operators_to_reduce::Matrix{T}, curr_l_bound::Int, curr_u_bound::Int,
     found::Vector{T}, max_iters::Int, n::Int, verbose::Bool) where T <: Integer
 
     num_thrds = Threads.nthreads()
@@ -1053,6 +1058,7 @@ function _RIS_bound_loop!(operators_to_reduce::Matrix{T}, curr_l_bound::Int, cur
     founds = [found for _ in 1:num_thrds]
     thread_load = Int(floor(max_iters / num_thrds))
     remaining = max_iters - thread_load * num_thrds
+    prog_meter = Progress(max_iters)
     Threads.@threads for t in 1:num_thrds
         orig_ops = deepcopy(operators_to_reduce)
         perm_ops = similar(orig_ops)
@@ -1083,8 +1089,10 @@ function _RIS_bound_loop!(operators_to_reduce::Matrix{T}, curr_l_bound::Int, cur
                     end
                 end
             end
+            next!(prog_meter)
         end
     end
+    finish!(prog_meter)
 
     return uppers, founds
 end
@@ -1146,13 +1154,13 @@ function weight_enumerator_classical(T::Trellis; type::Symbol = :complete)
     return T.CWE
 end
 
+# TODO: remove C from this, store in WE struct
 """
     MacWilliams_identity(C::AbstractLinearCode, W::WeightEnumerator; dual::Symbol = :Euclidean)
 
 Return the weight enumerator of the dual (`:Euclidean` or `:Hermitian`) of `C` obtained
 by applying the MacWilliams identities to `W`.
 """
-# TODO: remove C from this, store in WE struct
 function MacWilliams_identity(C::AbstractLinearCode, W::WeightEnumerator; dual::Symbol = :Euclidean)
     dual ∈ (:Euclidean, :Hermitian) ||
         throw(ArgumentError("The MacWilliams identities are only programmed for the Euclidean and Hermitian duals."))

src/CodingTheory.jl

@@ -18,6 +18,7 @@ using Random
 using DataStructures
 using StatsBase
 using Distributions
+using ProgressMeter
 
 import LinearAlgebra: tr, Adjoint, transpose, kron, diagm
 import Oscar: dual, factor, transpose, order, polynomial, nrows, ncols, degree,