Merge branch 'dev' into fixdev

Author: Fe-r-oz

src/Classical/weight_dist.jl

@@ -595,6 +595,7 @@ function Gray_code_minimum_distance(C::AbstractLinearCode; verbose::Bool = false
 
                             if uppers[m] > w
                                 uppers[m] = w
+                                # TODO maybe so .= here
                                 founds[m] = c
                                 perms[m] = i
                                 # verbose && println("Adjusting upper bound: $upperlocal")

src/CodingTheory.jl

@@ -70,7 +70,8 @@ export AbstractSubsystemCode, AbstractSubsystemCodeCSS, AbstractStabilizerCode,
     AbstractGraphStateStabilizerCSS, AbstractHypergraphProductCode, AbstractEASubsystemCode,
     AbstractEASubsystemCodeCSS, AbstractEAStabilizerCode, AbstractEAStabilizerCodeCSS 
 # misc
-export LogicalTrait, GaugeTrait, HasLogicals, HasNoLogicals, HasGauges, HasNoGauges, copy, ChainComplex
+export LogicalTrait, GaugeTrait, CSSTrait, HasLogicals, HasNoLogicals, HasGauges, HasNoGauges,
+    IsCSS, IsNotCSS, copy, ChainComplex
 
 #############################
          # utils.jl
@@ -360,8 +361,8 @@ export polynomial, type, CWE_to_HWE, weight_enumerator, MacWilliams_identity,
 include("Quantum/weight_dist.jl")
 # export weight_plot_CSS_X, weight_plot_CSS_Z, weight_plot_CSS, minimum_distance_X_Z,
 #     minimum_distance_X, minimum_distance_Z, is_pure, QDistRndCSS
-export minimum_distance_upper_bound!
-export QDistRndCSS
+export minimum_distance_upper_bound!, random_information_set_minimum_distance_bound!,
+    QDistRand
 
 #############################
 #  Quantum/product_codes.jl

src/Quantum/graph_state.jl

@@ -9,15 +9,15 @@
 
 Return the graph state defined by the graph `G`.
 """
-function GraphState(G::SimpleGraph{Int64})
+function GraphState(G::SimpleGraph{Int})
     # probably need some checks on G here but maybe the function args are good enough
     A = adjacency_matrix(G)
     _, nc = size(A)
     for i in 1:nc
         iszero(A[i, i]) || throw(ArgumentError("Graph cannot have self-loops."))
     end
     # are there non-binary graph states?
-    F = GF(2)
+    F = Oscar.Nemo.Native.GF(2)
     Fone = F(1)
     sym_stabs = zero_matrix(F, nc, 2 * nc)
     for r in 1:nc
@@ -38,6 +38,7 @@ Return the cluster state (graph state) on the rectangular lattice with width `w`
 function ClusterState(w::Int, h::Int)
     (0 <= w && 0 <= h) || throw(ArgumentError("Rectangle dimensions must be positive."))
 
+    # BUG this function has never been updated from the quadratic form
     E = GF(2, 2, :ω)
     ω = gen(E)
     Eone = E(1)

src/Quantum/misc_known_codes.jl

@@ -865,12 +865,15 @@ end
 Return the `[[144, 12, 12]]` gross code.
 """
 function GrossCode()
+    S, (x, y) = polynomial_ring(Oscar.Nemo.Native.GF(2), [:x, :y])
     l = 12
     m = 6
     R, _ = quo(S, ideal(S, [x^l - 1, y^m - 1]))
     a = R(x^3 + y + y^2)
     b = R(y^3 + x + x^2)
-    return BivariateBicycleCode(a, b)
+    S = BivariateBicycleCode(a, b)
+    # set_minimum_distance!(S, 12)
+    return S
 end
 
 #############################

src/Quantum/subsystem_code.jl

@@ -177,6 +177,7 @@ function SubsystemCode(G::CTMatrixTypes; char_vec::Union{Vector{zzModRingElem},
                 stabs_stand, stand_r, stand_k, P_stand, missing)
         else
             # bare
+            # TODO use ! versions throughout after vcats
             _, mat = _remove_empty(_rref_symp_col_swap(vcat(stabs, bare_logs)), :rows)
             anti = hcat(logs_mat[:, n + 1:end], -logs_mat[:, 1:n]) * transpose(_remove_empty(mat, :rows))
             u_bound_bare, _ = minimum(row_wts_symplectic(mat[findall(!iszero(anti[i:i, :]) for i in axes(anti, 1)), :]))