Merge branch 'dev' into dev

Author: Fe-r-oz

Manifest.toml

@@ -2,7 +2,7 @@ module JLD2Ext
 
 import CodingTheory
 
-import CodingTheory: TriangularColorCode488, TriangularColorCode666, PlanarSurfaceCode3D, PlanarSurfaceCode3D_X, ToricCode3D, StabilizerCode, set_logicals!
+import CodingTheory: TriangularColorCode488, TriangularColorCode666, StabilizerCode, set_logicals!, set_minimum_distance! #PlanarSurfaceCode3D, PlanarSurfaceCode3D_X, ToricCode3D,
 
 import JLD2
 

ext/JLD2Ext/JLD2Ext.jl

@@ -40,6 +40,7 @@ function CodingTheory.TriangularColorCode488(d::Int)
     F = CodingTheory.Oscar.GF(2)
     Q = StabilizerCode(CodingTheory.Oscar.matrix(F, S))
     set_logicals!(Q, CodingTheory.Oscar.matrix(F, l))
+    set_minimum_distance!(Q, d)
     return Q
 end
 
@@ -82,6 +83,7 @@ function CodingTheory.TriangularColorCode666(d::Int)
     F = CodingTheory.Oscar.GF(2)
     Q = StabilizerCode(CodingTheory.Oscar.matrix(F, S))
     set_logicals!(Q, CodingTheory.Oscar.matrix(F, l))
+    set_minimum_distance!(Q, d)
     return Q
 end
 
@@ -133,7 +135,7 @@ function CodingTheory.PlanarSurfaceCode3D_X(d::Int)
         X_logs = load_alist(joinpath(path, "surface3D_9_lx.alist"))
         X_meta = load_alist(joinpath(path, "surface3D_9_mx.alist"))
     end
-    F = CodingTheory.Oscar.GF(2)
+    F = CodingTheory.Oscar.Nemo.Native.GF(2)
     return CodingTheory.Oscar.matrix(F, X_stabs), CodingTheory.Oscar.matrix(F, X_logs),
         CodingTheory.Oscar.matrix(F, X_meta)
 end
@@ -206,7 +208,7 @@ function CodingTheory.ToricCode3D_X(d::Int)
         X_logs = load_alist(joinpath(path, "toric3D_13_lx.alist"))
         X_meta = load_alist(joinpath(path, "toric3D_13_mx.alist"))
     end
-    F = CodingTheory.Oscar.GF(2)
+    F = CodingTheory.Oscar.Nemo.Native.GF(2)
     return CodingTheory.Oscar.matrix(F, X_stabs), CodingTheory.Oscar.matrix(F, X_logs),
         CodingTheory.Oscar.matrix(F, X_meta)
 end

ext/JLD2Ext/Quantum/misc_known_codes.jl

@@ -291,7 +291,10 @@ minimum_distance_upper_bound(C::AbstractLinearCode) = C.u_bound
 
 Return `true` if code is maximum distance separable (MDS).
 """
-is_MDS(C::AbstractLinearCode) = ismissing(C.d) ? missing : C.d != Singleton_bound(C.n, C.k)
+function is_MDS(C::AbstractLinearCode)
+    ismissing(C.d) && minimum_distance(C)
+    return C.d == Singleton_bound(C.n, C.k)
+end
 
 """
     number_correctable_errors(C::AbstractLinearCode)

src/Classical/linear_code.jl

@@ -517,16 +517,16 @@ function subcode_of_dimension_between_codes(C1::AbstractLinearCode, C2::Abstract
 end
 
 """
-    expanded_code(C::AbstractLinearCode, K::CTFieldTypes, β::Vector{<:CTFieldElem})
+    expanded_code(C::AbstractLinearCode, K::CTFieldTypes, β::Vector{FqFieldElem})
 
 Return the expanded code of `C` constructed by exapnding the generator matrix
 to the subfield `K` using the basis `β` for `field(C)` over `K`.
 """
-function expanded_code(C::AbstractLinearCode, K::CTFieldTypes, β::Vector{<:CTFieldElem})
+function expanded_code(C::AbstractLinearCode, K::CTFieldTypes, β::Vector{FqFieldElem})
     flag, λ = is_basis(C.F, K, β)
     flag || throw(ArgumentError("β is not a basis for the extension"))
 
-    # D = _expansiondict(C.F, K, λ)
+    # D = _expansion_dict(C.F, K, λ)
     # m = div(degree(C.F), degree(K))
 
     G = generator_matrix(C)
@@ -552,6 +552,7 @@ function expanded_code(C::AbstractLinearCode, K::CTFieldTypes, β::Vector{<:CTFi
     end
     H_exp = expand_matrix(H_new, K, λ)
     # H_exp = _expandmatrix(H_new, D, m)
+    return G_exp
 
     C_new = LinearCode(G_exp, H_exp)
     C_new.G = change_base_ring(K, C_new.G)

src/Classical/new_codes_from_old.jl

@@ -9,8 +9,6 @@ module CodingTheory
 using AutoHashEquals
 using Graphs
 import Graphs as Grphs
-# using Plots
-# import Grphs: nv, incidence_matrix, vertices, inneighbors, add_edge!, add_vertex!
 using Oscar
 using Combinatorics
 using .Threads
@@ -33,16 +31,22 @@ import Base: circshift, iseven, show, length, in, zeros, ⊆, /, *, ==, ∩, +,
 import Combinatorics: powerset
 import DataStructures: capacity
 
-# TODO: don't want this here
-# GAP.Packages.load("LINS");
+# tilings.jl
+LINS_flag_install = Packages.install("LINS")
+if LINS_flag_install
+    LINS_flag = Packages.load("LINS")
+    LINS_flag || @warn "Unable to load the GAP packages LINS."
+else
+    @warn "Unable to install the GAP packages LINS."
+end
 
 #############################
          # types.jl
 #############################
 
 const CTFieldTypes = FinField
 const CTFieldElem = FinFieldElem
-const CTMatrixTypes = MatElem{<:CTFieldElem}
+const CTMatrixTypes = Union{fpMatrix, FqMatrix} # MatElem{<:CTFieldElem}
 const CTPolyRing = PolyRing{<:CTFieldElem}
 const CTPolyRingElem = PolyRingElem{<:CTFieldElem}
 const CTGroupAlgebra = GroupAlgebraElem{fpFieldElem, GroupAlgebra{fpFieldElem, FinGenAbGroup, FinGenAbGroupElem}}