Merge pull request #41 from escaped/fix/get_fields

 ModelAdminMixin: Only remove 'render_inline_actions' if exists

Author: escaped

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+* Do not break if `render_inline_actions` field is missing, thanks to @tony
+
 ### Added
 
 * support for django 3.x

CONTRIBUTORS.md

@@ -6,4 +6,5 @@
 - [@nikbora](https://github.com/nikbora)
 - [@orwald-sergesson](https://github.com/torwald-sergesson)
 - [@sobolevn](https://github.com/sobolevn)
+- [@tony](https://github.com/tony)
 - [@tripliks](https://github.com/tripliks)

inline_actions/admin.py

@@ -176,7 +176,8 @@ def get_fields(self, request, obj=None):
             # django adds all readonly fields by default
             # if `self.fields` is not defined we don't want to include
             # `render_inline_actions
-            fields.remove('render_inline_actions')
+            if 'render_inline_actions' in fields:
+                fields.remove('render_inline_actions')
         return fields
 
     def _execute_action(self, request, model_admin, action, obj, parent_obj=None):

test_proj/blog/tests/test_admin.py

@@ -216,3 +216,32 @@ def test_skip_rendering_actions_for_unsaved_objects(admin_client, mocker, articl
     admin = ArticleAdmin(unsaved_article, admin_site)
 
     assert admin.render_inline_actions(unsaved_article) == ''
+
+
+@pytest.mark.django_db
+def test_missing_render_inline_actions_from_readonly_fields(
+    rf, admin_user, admin_site, article
+):
+    """
+    Make sure that customization does not break the app.
+    """
+    from test_proj.blog import admin
+
+    class ArticleAdmin(admin.InlineActionsModelAdminMixin, admin.admin.ModelAdmin):
+        list_display = ('name',)
+        inline_actions = None
+
+        def get_readonly_fields(self, *args, **kwargs):
+            """
+            Do some fancy logic to return a list of fields, which does not include `render_inline_actions`.
+            """
+            return []
+
+    request = rf.get(f'/admin/blog/articles/{article.id}/')
+    request.user = admin_user
+
+    admin = ArticleAdmin(Article, admin_site)
+
+    # even though `render_inline_actions` is not part of the fields,
+    # it should not fail :)
+    admin.changeform_view(request)