Add migration to remove prettier oxc plugin and update e2e tests

Co-authored-by: neilime <[email protected]>

Author: Copilot

TODO-PRETTIER-OXC.md

@@ -0,0 +1,31 @@
+# TODO: Re-enable Prettier OXC Plugin
+
+## Background
+
+The `@prettier/plugin-oxc` plugin was temporarily disabled due to stability issues. The plugin was removed in migration `20250623095600-remove-prettier-oxc.ts`.
+
+## Action Required
+
+When a stable release of `@prettier/plugin-oxc` becomes available:
+
+1. Create a new migration to re-add the plugin to the prettier configuration
+2. Update the migration to add:
+   ```json
+   {
+     "prettier": {
+       "plugins": ["@prettier/plugin-oxc"]
+     }
+   }
+   ```
+3. Test thoroughly to ensure the plugin is stable
+4. Update this file or remove it once completed
+
+## Related Files
+
+- Migration that added the plugin: `packages/core/src/install/migrations/20250623095500-add-prettier-oxc.ts`
+- Migration that removed the plugin: `packages/core/src/install/migrations/20250623095600-remove-prettier-oxc.ts`
+
+## References
+
+- Prettier OXC Plugin: https://github.com/prettier/plugin-oxc
+- Monitor releases: https://github.com/prettier/plugin-oxc/releases

packages/core/src/core.e2e.spec.ts

@@ -94,6 +94,11 @@ describe(`E2E - ${packageToTest}`, () => {
 
       expect(buildStderr).toBeFalsy();
       expect(buildCode).toBe(0);
+
+      const { code: formatCode, stderr: formatStderr } = await exec(testProjectDir, "npm run format");
+
+      expect(formatStderr).toBeFalsy();
+      expect(formatCode).toBe(0);
     }, 200000);
   });
 

packages/core/src/install/migrations/20250623095600-remove-prettier-oxc.spec.ts

@@ -0,0 +1,48 @@
+import { PackageJson } from "../../services/PackageJson";
+import { createProjectForTestFile, deleteTestProject } from "../../tests/test-project";
+import { up } from "./20250623095600-remove-prettier-oxc";
+
+// Set to false to avoid using the cache
+const useCache = true;
+// Set to false to inspect the test project directory after the test
+const shouldCleanupAfterTest = true;
+
+describe("Migration 20250623095600-remove-prettier-oxc", () => {
+  let testProjectDir: string;
+
+  beforeAll(async () => {
+    if (!useCache) {
+      console.warn("Cache is disabled. Enable it one dev is done.");
+    }
+    if (!shouldCleanupAfterTest) {
+      console.warn("Cleanup is disabled. Enable it one dev is done.");
+    }
+
+    testProjectDir = await createProjectForTestFile(__filename, useCache);
+  });
+
+  afterEach(async () => {
+    if (shouldCleanupAfterTest) {
+      await deleteTestProject(__filename);
+    }
+  });
+
+  describe("Up", () => {
+    it("should apply migration and remove prettier plugins", async () => {
+      // First, add the prettier oxc plugin to simulate the previous migration
+      const packageJson = PackageJson.fromDirPath(testProjectDir);
+      packageJson.merge({
+        prettier: {
+          plugins: ["@prettier/plugin-oxc"],
+        },
+      });
+
+      // Apply the migration to remove it
+      await up(testProjectDir);
+
+      const packageJsonContent = PackageJson.fromDirPath(testProjectDir).getContent();
+
+      expect(packageJsonContent).toMatchSnapshot();
+    });
+  });
+});

packages/core/src/install/migrations/20250623095600-remove-prettier-oxc.ts

@@ -0,0 +1,17 @@
+import { MigrationUpFunction } from "../../services/MigrationsService";
+import { JsonFileData, PackageJson } from "../../services/PackageJson";
+
+export const up: MigrationUpFunction = async (absoluteProjectDir: string): Promise<void> => {
+  const packageJson = PackageJson.fromDirPath(absoluteProjectDir);
+
+  const packageJsonContent = packageJson.getContent();
+  
+  // Remove prettier.plugins if it exists
+  if (packageJsonContent.prettier && typeof packageJsonContent.prettier === "object") {
+    const prettierConfig = packageJsonContent.prettier as JsonFileData;
+    if (prettierConfig.plugins) {
+      delete prettierConfig.plugins;
+      packageJson.setContent(packageJsonContent);
+    }
+  }
+};

packages/core/src/install/migrations/__snapshots__/20250623095600-remove-prettier-oxc.spec.ts.snap

@@ -0,0 +1,9 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`Migration 20250623095600-remove-prettier-oxc Up should apply migration and remove prettier plugins 1`] = `
+{
+  "license": "MIT",
+  "prettier": {},
+  "version": "1.0.0",
+}
+`;

packages/react/src/react.e2e.spec.ts

@@ -92,6 +92,11 @@ describe(`E2E - ${packageToTest}`, () => {
 
       expect(buildStderr).toBeFalsy();
       expect(buildCode).toBe(0);
+
+      const { code: formatCode, stderr: formatStderr } = await exec(testProjectDir, "npm run format");
+
+      expect(formatStderr).toBeFalsy();
+      expect(formatCode).toBe(0);
     }, 200000);
   });