Address PR feedback: remove only oxc plugin from array and delete TODO file

Co-authored-by: neilime <[email protected]>

Author: Copilot

TODO-PRETTIER-OXC.md

@@ -103,6 +103,7 @@ exports[`E2E - core Simple project Installs core package 2`] = `
 
 exports[`E2E - core Simple project Installs core package 3`] = `
 {
+  "plugins": [],
   "printWidth": 100,
   "semi": true,
   "trailingComma": "es5",

packages/core/src/__snapshots__/core.e2e.spec.ts.snap

@@ -17,7 +17,9 @@ describe("Migration 20250623095600-remove-prettier-oxc", () => {
     if (!shouldCleanupAfterTest) {
       console.warn("Cleanup is disabled. Enable it once dev is done.");
     }
+  });
 
+  beforeEach(async () => {
     testProjectDir = await createProjectForTestFile(__filename, useCache);
   });
 
@@ -28,7 +30,7 @@ describe("Migration 20250623095600-remove-prettier-oxc", () => {
   });
 
   describe("Up", () => {
-    it("should apply migration and remove prettier plugins", async () => {
+    it("should remove only @prettier/plugin-oxc from plugins array", async () => {
       // First, add the prettier oxc plugin to simulate the previous migration
       const packageJson = PackageJson.fromDirPath(testProjectDir);
       packageJson.merge({
@@ -44,5 +46,22 @@ describe("Migration 20250623095600-remove-prettier-oxc", () => {
 
       expect(packageJsonContent).toMatchSnapshot();
     });
+
+    it("should keep other plugins when removing @prettier/plugin-oxc", async () => {
+      // Add prettier config with multiple plugins
+      const packageJson = PackageJson.fromDirPath(testProjectDir);
+      packageJson.merge({
+        prettier: {
+          plugins: ["@prettier/plugin-oxc", "prettier-plugin-other"],
+        },
+      });
+
+      // Apply the migration
+      await up(testProjectDir);
+
+      const packageJsonContent = PackageJson.fromDirPath(testProjectDir).getContent();
+
+      expect(packageJsonContent).toMatchSnapshot();
+    });
   });
 });

packages/core/src/install/migrations/20250623095600-remove-prettier-oxc.spec.ts

@@ -6,12 +6,17 @@ export const up: MigrationUpFunction = async (absoluteProjectDir: string): Promi
 
   const packageJsonContent = packageJson.getContent();
 
-  // Remove prettier.plugins if it exists
+  // Remove @prettier/plugin-oxc from prettier.plugins if it exists
   if (packageJsonContent.prettier && typeof packageJsonContent.prettier === "object") {
     const prettierConfig = packageJsonContent.prettier as JsonFileData;
-    if (prettierConfig.plugins) {
-      delete prettierConfig.plugins;
-      packageJson.setContent(packageJsonContent);
+    if (Array.isArray(prettierConfig.plugins)) {
+      const plugins = prettierConfig.plugins as string[];
+      const filteredPlugins = plugins.filter((plugin) => plugin !== "@prettier/plugin-oxc");
+      
+      if (filteredPlugins.length !== plugins.length) {
+        prettierConfig.plugins = filteredPlugins;
+        packageJson.setContent(packageJsonContent);
+      }
     }
   }
 };

packages/core/src/install/migrations/20250623095600-remove-prettier-oxc.ts

@@ -1,9 +1,23 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
-exports[`Migration 20250623095600-remove-prettier-oxc Up should apply migration and remove prettier plugins 1`] = `
+exports[`Migration 20250623095600-remove-prettier-oxc Up should keep other plugins when removing @prettier/plugin-oxc 1`] = `
 {
   "license": "MIT",
-  "prettier": {},
+  "prettier": {
+    "plugins": [
+      "prettier-plugin-other",
+    ],
+  },
+  "version": "1.0.0",
+}
+`;
+
+exports[`Migration 20250623095600-remove-prettier-oxc Up should remove only @prettier/plugin-oxc from plugins array 1`] = `
+{
+  "license": "MIT",
+  "prettier": {
+    "plugins": [],
+  },
   "version": "1.0.0",
 }
 `;

packages/core/src/install/migrations/__snapshots__/20250623095600-remove-prettier-oxc.spec.ts.snap

@@ -126,6 +126,7 @@ exports[`E2E - react Simple project Installs react package 2`] = `
 
 exports[`E2E - react Simple project Installs react package 3`] = `
 {
+  "plugins": [],
   "printWidth": 100,
   "semi": true,
   "trailingComma": "es5",