Skip to content

Commit f5dc26b

Browse files
Make a failed extension load throw an error during pre-compilation (JuliaLang#56668)
Co-authored-by: Ian Butterworth <[email protected]>
1 parent 60f0057 commit f5dc26b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

base/loading.jl

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1587,9 +1587,14 @@ function run_extension_callbacks(extid::ExtensionId)
15871587
true
15881588
catch
15891589
# Try to continue loading if loading an extension errors
1590-
errs = current_exceptions()
1591-
@error "Error during loading of extension $(extid.id.name) of $(extid.parentid.name), \
1590+
if JLOptions().incremental != 0
1591+
# during incremental precompilation, this should be fail-fast
1592+
rethrow()
1593+
else
1594+
errs = current_exceptions()
1595+
@error "Error during loading of extension $(extid.id.name) of $(extid.parentid.name), \
15921596
use `Base.retry_load_extensions()` to retry." exception=errs
1597+
end
15931598
false
15941599
finally
15951600
global loading_extension = false

0 commit comments

Comments
 (0)