Skip to content

Commit 1185405

Browse files
authored
[TEST] Fix linking order and gmock linking (open-telemetry#3106)
* Fix link order * Fix gmock linking
1 parent 63683c1 commit 1185405

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

ext/test/http/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ if(WITH_HTTP_CLIENT_CURL)
55
set(FILENAME curl_http_test)
66
add_compile_definitions(WITH_CURL)
77
add_executable(${FILENAME} ${FILENAME}.cc)
8-
target_link_libraries(${FILENAME} ${GTEST_BOTH_LIBRARIES}
8+
target_link_libraries(${FILENAME} ${GMOCK_LIB} ${GTEST_BOTH_LIBRARIES}
99
${CMAKE_THREAD_LIBS_INIT})
1010

1111
if(TARGET CURL::libcurl)
@@ -24,8 +24,8 @@ endif()
2424

2525
set(URL_PARSER_FILENAME url_parser_test)
2626
add_executable(${URL_PARSER_FILENAME} ${URL_PARSER_FILENAME}.cc)
27-
target_link_libraries(${URL_PARSER_FILENAME} ${GTEST_BOTH_LIBRARIES}
28-
${CMAKE_THREAD_LIBS_INIT} opentelemetry_api)
27+
target_link_libraries(${URL_PARSER_FILENAME} opentelemetry_api ${GMOCK_LIB}
28+
${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT})
2929
gtest_add_tests(
3030
TARGET ${URL_PARSER_FILENAME}
3131
TEST_PREFIX ext.http.urlparser.

test_common/src/http/client/nosend/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if(${BUILD_TESTING})
2828
endif()
2929

3030
target_link_libraries(
31-
opentelemetry_http_client_nosend ${GTEST_BOTH_LIBRARIES} opentelemetry_ext
32-
opentelemetry_test_common)
31+
opentelemetry_http_client_nosend opentelemetry_ext
32+
opentelemetry_test_common ${GMOCK_LIB} ${GTEST_BOTH_LIBRARIES})
3333

3434
endif()

0 commit comments

Comments
 (0)