Skip to content

Commit 779f136

Browse files
authored
Merge pull request #53 from esl/cets-split-tests
Split tests and add test helpers
2 parents 059078d + 06d99a8 commit 779f136

14 files changed

+2680
-2037
lines changed

test/cets_SUITE.erl

Lines changed: 62 additions & 2015 deletions
Large diffs are not rendered by default.

test/cets_disco_SUITE.erl

Lines changed: 772 additions & 0 deletions
Large diffs are not rendered by default.

test/cets_dist_blocker_SUITE.erl

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,10 @@ unknown_cases() ->
3535
].
3636

3737
init_per_suite(Config) ->
38-
Names = [peer_ct2],
39-
{Nodes, Peers} = lists:unzip([cets_test_peer:start_node(N) || N <- Names]),
40-
[
41-
{nodes, maps:from_list(lists:zip(Names, Nodes))},
42-
{peers, maps:from_list(lists:zip(Names, Peers))}
43-
| Config
44-
].
38+
cets_test_peer:start([ct2], Config).
4539

4640
end_per_suite(Config) ->
41+
cets_test_peer:stop(Config),
4742
Config.
4843

4944
init_per_group(_Group, Config) ->
@@ -64,7 +59,7 @@ end_per_testcase(_, _Config) ->
6459
%% Test blocking functionality
6560

6661
waits_for_cleaning(Config) ->
67-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
62+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
6863
{ok, Blocker} = cets_dist_blocker:start_link(),
6964
cets_dist_blocker:add_cleaner(self()),
7065
connect_and_disconnect(Node2),
@@ -75,7 +70,7 @@ waits_for_cleaning(Config) ->
7570
gen_server:stop(Blocker).
7671

7772
unblocks_if_cleaner_goes_down(Config) ->
78-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
73+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
7974
{ok, Blocker} = cets_dist_blocker:start_link(),
8075
Cleaner = spawn_cleaner(),
8176
connect_and_disconnect(Node2),
@@ -86,7 +81,7 @@ unblocks_if_cleaner_goes_down(Config) ->
8681
gen_server:stop(Blocker).
8782

8883
unblocks_if_cleaner_goes_down_and_second_cleaner_says_done(Config) ->
89-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
84+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
9085
{ok, Blocker} = cets_dist_blocker:start_link(),
9186
%% Two cleaners
9287
cets_dist_blocker:add_cleaner(self()),
@@ -101,7 +96,7 @@ unblocks_if_cleaner_goes_down_and_second_cleaner_says_done(Config) ->
10196
gen_server:stop(Blocker).
10297

10398
unblocks_if_cleaner_says_done_and_second_cleaner_goes_down(Config) ->
104-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
99+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
105100
{ok, Blocker} = cets_dist_blocker:start_link(),
106101
%% Two cleaners
107102
cets_dist_blocker:add_cleaner(self()),
@@ -117,7 +112,7 @@ unblocks_if_cleaner_says_done_and_second_cleaner_goes_down(Config) ->
117112
gen_server:stop(Blocker).
118113

119114
blocks_if_cleaner_says_done_and_second_cleaner_does_not_ack(Config) ->
120-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
115+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
121116
{ok, Blocker} = cets_dist_blocker:start_link(),
122117
%% Two cleaners
123118
cets_dist_blocker:add_cleaner(self()),
@@ -131,7 +126,7 @@ blocks_if_cleaner_says_done_and_second_cleaner_does_not_ack(Config) ->
131126
gen_server:stop(Blocker).
132127

133128
skip_blocking_if_no_cleaners(Config) ->
134-
#{peer_ct2 := Node2} = proplists:get_value(nodes, Config),
129+
#{ct2 := Node2} = proplists:get_value(nodes, Config),
135130
{ok, Blocker} = cets_dist_blocker:start_link(),
136131
pong = net_adm:ping(Node2),
137132
true = erlang:disconnect_node(Node2),

0 commit comments

Comments
 (0)