fix: no-symbol-dispose and no-symbol-asyncdispose category (#270)

ota-meshi · web-flow · commit 092d93b717fa · 2025-06-27T16:03:10.000+09:00
diff --git a/.changeset/update-config.md b/.changeset/update-config.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-es-x": major
+---
+
+Update `no-explicit-resource-management` config.
diff --git a/docs/configs/index.md b/docs/configs/index.md
@@ -1108,7 +1108,7 @@ export default [
 disallow proposal ES2026 [Explicit Resource Management](https://github.com/tc39/proposal-explicit-resource-management)\
 ⚠️ This config will be changed in the minor versions of this plugin.
 
-This configs includes rules for [es-x/no-asyncdisposablestack](../rules/no-asyncdisposablestack.md), [es-x/no-disposablestack](../rules/no-disposablestack.md), [es-x/no-suppressederror](../rules/no-suppressederror.md), and [es-x/no-using-declarations](../rules/no-using-declarations.md).
+This configs includes rules for [es-x/no-asyncdisposablestack](../rules/no-asyncdisposablestack.md), [es-x/no-disposablestack](../rules/no-disposablestack.md), [es-x/no-suppressederror](../rules/no-suppressederror.md), [es-x/no-symbol-asyncdispose](../rules/no-symbol-asyncdispose.md), [es-x/no-symbol-dispose](../rules/no-symbol-dispose.md), and [es-x/no-using-declarations](../rules/no-using-declarations.md).
 
 ### [Config (Flat Config)]
 
diff --git a/docs/rules/index.md b/docs/rules/index.md
@@ -15,6 +15,8 @@ There is a config that enables the rules in this category: [`no-new-in-esnext`]
 | [es-x/no-disposablestack](./no-disposablestack.md) | disallow the `DisposableStack` class. |  |
 | [es-x/no-error-iserror](./no-error-iserror.md) | disallow the `Error.isError` method. |  |
 | [es-x/no-suppressederror](./no-suppressederror.md) | disallow the `SuppressedError` class. |  |
+| [es-x/no-symbol-asyncdispose](./no-symbol-asyncdispose.md) | disallow the `Symbol.asyncDispose` property. |  |
+| [es-x/no-symbol-dispose](./no-symbol-dispose.md) | disallow the `Symbol.dispose` property. |  |
 | [es-x/no-using-declarations](./no-using-declarations.md) | disallow `using` and `await using` declarations. |  |
 
 ## ES2025
@@ -52,8 +54,6 @@ There are multiple configs that enable all rules in this category: [`no-new-in-e
 | [es-x/no-set-prototype-issupersetof](./no-set-prototype-issupersetof.md) | disallow the `Set.prototype.isSupersetOf` method. |  |
 | [es-x/no-set-prototype-symmetricdifference](./no-set-prototype-symmetricdifference.md) | disallow the `Set.prototype.symmetricDifference` method. |  |
 | [es-x/no-set-prototype-union](./no-set-prototype-union.md) | disallow the `Set.prototype.union` method. |  |
-| [es-x/no-symbol-asyncdispose](./no-symbol-asyncdispose.md) | disallow the `Symbol.asyncDispose` property. |  |
-| [es-x/no-symbol-dispose](./no-symbol-dispose.md) | disallow the `Symbol.dispose` property. |  |
 | [es-x/no-trailing-dynamic-import-commas](./no-trailing-dynamic-import-commas.md) | disallow trailing commas in `import()`. | 🔧 |
 
 ## ES2025 Intl API
diff --git a/docs/rules/no-symbol-asyncdispose.md b/docs/rules/no-symbol-asyncdispose.md
@@ -7,9 +7,9 @@ description: "disallow the `Symbol.asyncDispose` property"
 > disallow the `Symbol.asyncDispose` property
 
 - ❗ <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
-- ✅ The following configurations enable this rule: [no-new-in-es2025], [restrict-to-es3], [restrict-to-es5], [restrict-to-es2015], [restrict-to-es2016], [restrict-to-es2017], [restrict-to-es2018], [restrict-to-es2019], [restrict-to-es2020], [restrict-to-es2021], [restrict-to-es2022], [restrict-to-es2023], and [restrict-to-es2024]
+- ✅ The following configurations enable this rule: [no-explicit-resource-management] and [no-new-in-esnext]
 
-This rule reports ES2025 [`Symbol.asyncDispose` property](https://github.com/tc39/proposal-explicit-resource-management) as errors.
+This rule reports ES2026 [`Symbol.asyncDispose` property](https://github.com/tc39/proposal-explicit-resource-management) as errors.
 
 ## 💡 Examples
 
@@ -51,16 +51,5 @@ This is prior to the `settings['es-x'].allowTestedProperty` setting.
 - [Rule source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/lib/rules/no-symbol-asyncdispose.js)
 - [Test source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/tests/lib/rules/no-symbol-asyncdispose.js)
 
-[no-new-in-es2025]: ../configs/index.md#no-new-in-es2025
-[restrict-to-es3]: ../configs/index.md#restrict-to-es3
-[restrict-to-es5]: ../configs/index.md#restrict-to-es5
-[restrict-to-es2015]: ../configs/index.md#restrict-to-es2015
-[restrict-to-es2016]: ../configs/index.md#restrict-to-es2016
-[restrict-to-es2017]: ../configs/index.md#restrict-to-es2017
-[restrict-to-es2018]: ../configs/index.md#restrict-to-es2018
-[restrict-to-es2019]: ../configs/index.md#restrict-to-es2019
-[restrict-to-es2020]: ../configs/index.md#restrict-to-es2020
-[restrict-to-es2021]: ../configs/index.md#restrict-to-es2021
-[restrict-to-es2022]: ../configs/index.md#restrict-to-es2022
-[restrict-to-es2023]: ../configs/index.md#restrict-to-es2023
-[restrict-to-es2024]: ../configs/index.md#restrict-to-es2024
+[no-explicit-resource-management]: ../configs/index.md#no-explicit-resource-management
+[no-new-in-esnext]: ../configs/index.md#no-new-in-esnext
diff --git a/docs/rules/no-symbol-dispose.md b/docs/rules/no-symbol-dispose.md
@@ -7,9 +7,9 @@ description: "disallow the `Symbol.dispose` property"
 > disallow the `Symbol.dispose` property
 
 - ❗ <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
-- ✅ The following configurations enable this rule: [no-new-in-es2025], [restrict-to-es3], [restrict-to-es5], [restrict-to-es2015], [restrict-to-es2016], [restrict-to-es2017], [restrict-to-es2018], [restrict-to-es2019], [restrict-to-es2020], [restrict-to-es2021], [restrict-to-es2022], [restrict-to-es2023], and [restrict-to-es2024]
+- ✅ The following configurations enable this rule: [no-explicit-resource-management] and [no-new-in-esnext]
 
-This rule reports ES2025 [`Symbol.dispose` property](https://github.com/tc39/proposal-explicit-resource-management) as errors.
+This rule reports ES2026 [`Symbol.dispose` property](https://github.com/tc39/proposal-explicit-resource-management) as errors.
 
 ## 💡 Examples
 
@@ -51,16 +51,5 @@ This is prior to the `settings['es-x'].allowTestedProperty` setting.
 - [Rule source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/lib/rules/no-symbol-dispose.js)
 - [Test source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/tests/lib/rules/no-symbol-dispose.js)
 
-[no-new-in-es2025]: ../configs/index.md#no-new-in-es2025
-[restrict-to-es3]: ../configs/index.md#restrict-to-es3
-[restrict-to-es5]: ../configs/index.md#restrict-to-es5
-[restrict-to-es2015]: ../configs/index.md#restrict-to-es2015
-[restrict-to-es2016]: ../configs/index.md#restrict-to-es2016
-[restrict-to-es2017]: ../configs/index.md#restrict-to-es2017
-[restrict-to-es2018]: ../configs/index.md#restrict-to-es2018
-[restrict-to-es2019]: ../configs/index.md#restrict-to-es2019
-[restrict-to-es2020]: ../configs/index.md#restrict-to-es2020
-[restrict-to-es2021]: ../configs/index.md#restrict-to-es2021
-[restrict-to-es2022]: ../configs/index.md#restrict-to-es2022
-[restrict-to-es2023]: ../configs/index.md#restrict-to-es2023
-[restrict-to-es2024]: ../configs/index.md#restrict-to-es2024
+[no-explicit-resource-management]: ../configs/index.md#no-explicit-resource-management
+[no-new-in-esnext]: ../configs/index.md#no-new-in-esnext
diff --git a/lib/configs/flat/no-explicit-resource-management.js b/lib/configs/flat/no-explicit-resource-management.js
@@ -14,6 +14,8 @@ module.exports = {
         "es-x/no-asyncdisposablestack": "error",
         "es-x/no-disposablestack": "error",
         "es-x/no-suppressederror": "error",
+        "es-x/no-symbol-asyncdispose": "error",
+        "es-x/no-symbol-dispose": "error",
         "es-x/no-using-declarations": "error",
     },
 }
diff --git a/lib/configs/flat/no-new-in-es2025.js b/lib/configs/flat/no-new-in-es2025.js
@@ -40,8 +40,6 @@ module.exports = {
         "es-x/no-set-prototype-issupersetof": "error",
         "es-x/no-set-prototype-symmetricdifference": "error",
         "es-x/no-set-prototype-union": "error",
-        "es-x/no-symbol-asyncdispose": "error",
-        "es-x/no-symbol-dispose": "error",
         "es-x/no-trailing-dynamic-import-commas": "error",
     },
 }
diff --git a/lib/configs/flat/no-new-in-esnext.js b/lib/configs/flat/no-new-in-esnext.js
@@ -16,6 +16,8 @@ module.exports = {
         "es-x/no-disposablestack": "error",
         "es-x/no-error-iserror": "error",
         "es-x/no-suppressederror": "error",
+        "es-x/no-symbol-asyncdispose": "error",
+        "es-x/no-symbol-dispose": "error",
         "es-x/no-using-declarations": "error",
     },
 }
diff --git a/lib/configs/no-explicit-resource-management.js b/lib/configs/no-explicit-resource-management.js
@@ -10,6 +10,8 @@ module.exports = {
         "es-x/no-asyncdisposablestack": "error",
         "es-x/no-disposablestack": "error",
         "es-x/no-suppressederror": "error",
+        "es-x/no-symbol-asyncdispose": "error",
+        "es-x/no-symbol-dispose": "error",
         "es-x/no-using-declarations": "error",
     },
 }
diff --git a/lib/configs/no-new-in-es2025.js b/lib/configs/no-new-in-es2025.js
@@ -36,8 +36,6 @@ module.exports = {
         "es-x/no-set-prototype-issupersetof": "error",
         "es-x/no-set-prototype-symmetricdifference": "error",
         "es-x/no-set-prototype-union": "error",
-        "es-x/no-symbol-asyncdispose": "error",
-        "es-x/no-symbol-dispose": "error",
         "es-x/no-trailing-dynamic-import-commas": "error",
     },
 }
diff --git a/lib/configs/no-new-in-esnext.js b/lib/configs/no-new-in-esnext.js
@@ -12,6 +12,8 @@ module.exports = {
         "es-x/no-disposablestack": "error",
         "es-x/no-error-iserror": "error",
         "es-x/no-suppressederror": "error",
+        "es-x/no-symbol-asyncdispose": "error",
+        "es-x/no-symbol-dispose": "error",
         "es-x/no-using-declarations": "error",
     },
 }
diff --git a/lib/rules/no-symbol-asyncdispose.js b/lib/rules/no-symbol-asyncdispose.js
@@ -8,13 +8,14 @@ module.exports = {
     meta: {
         docs: {
             description: "disallow the `Symbol.asyncDispose` property",
-            category: "ES2025",
+            category: "ES2026",
+            proposal: "explicit-resource-management",
             recommended: false,
             url: "http://eslint-community.github.io/eslint-plugin-es-x/rules/no-symbol-asyncdispose.html",
         },
         fixable: null,
         messages: {
-            forbidden: "ES2025 '{{name}}' property is forbidden.",
+            forbidden: "ES2026 '{{name}}' property is forbidden.",
         },
         schema: [
             {
diff --git a/lib/rules/no-symbol-dispose.js b/lib/rules/no-symbol-dispose.js
@@ -8,13 +8,14 @@ module.exports = {
     meta: {
         docs: {
             description: "disallow the `Symbol.dispose` property",
-            category: "ES2025",
+            category: "ES2026",
+            proposal: "explicit-resource-management",
             recommended: false,
             url: "http://eslint-community.github.io/eslint-plugin-es-x/rules/no-symbol-dispose.html",
         },
         fixable: null,
         messages: {
-            forbidden: "ES2025 '{{name}}' property is forbidden.",
+            forbidden: "ES2026 '{{name}}' property is forbidden.",
         },
         schema: [
             {
diff --git a/tests/lib/rules/no-symbol-asyncdispose.js b/tests/lib/rules/no-symbol-asyncdispose.js
@@ -8,7 +8,7 @@ new RuleTester().run("no-symbol-asyncdispose", rule, {
     invalid: [
         {
             code: "Symbol.asyncDispose",
-            errors: ["ES2025 'Symbol.asyncDispose' property is forbidden."],
+            errors: ["ES2026 'Symbol.asyncDispose' property is forbidden."],
         },
     ],
 })
diff --git a/tests/lib/rules/no-symbol-dispose.js b/tests/lib/rules/no-symbol-dispose.js
@@ -8,7 +8,7 @@ new RuleTester().run("no-symbol-dispose", rule, {
     invalid: [
         {
             code: "Symbol.dispose",
-            errors: ["ES2025 'Symbol.dispose' property is forbidden."],
+            errors: ["ES2026 'Symbol.dispose' property is forbidden."],
         },
     ],
 })

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"eslint-plugin-es-x": major
 +---
++
 +Update `no-explicit-resource-management` config.
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ module.exports = {`
`14`	`14`	`"es-x/no-asyncdisposablestack": "error",`
`15`	`15`	`"es-x/no-disposablestack": "error",`
`16`	`16`	`"es-x/no-suppressederror": "error",`
	`17`	`+ "es-x/no-symbol-asyncdispose": "error",`
	`18`	`+ "es-x/no-symbol-dispose": "error",`
`17`	`19`	`"es-x/no-using-declarations": "error",`
`18`	`20`	`},`
`19`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,6 @@ module.exports = {`
`40`	`40`	`"es-x/no-set-prototype-issupersetof": "error",`
`41`	`41`	`"es-x/no-set-prototype-symmetricdifference": "error",`
`42`	`42`	`"es-x/no-set-prototype-union": "error",`
`43`		`- "es-x/no-symbol-asyncdispose": "error",`
`44`		`- "es-x/no-symbol-dispose": "error",`
`45`	`43`	`"es-x/no-trailing-dynamic-import-commas": "error",`
`46`	`44`	`},`
`47`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@ module.exports = {`
`16`	`16`	`"es-x/no-disposablestack": "error",`
`17`	`17`	`"es-x/no-error-iserror": "error",`
`18`	`18`	`"es-x/no-suppressederror": "error",`
	`19`	`+ "es-x/no-symbol-asyncdispose": "error",`
	`20`	`+ "es-x/no-symbol-dispose": "error",`
`19`	`21`	`"es-x/no-using-declarations": "error",`
`20`	`22`	`},`
`21`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@ module.exports = {`
`10`	`10`	`"es-x/no-asyncdisposablestack": "error",`
`11`	`11`	`"es-x/no-disposablestack": "error",`
`12`	`12`	`"es-x/no-suppressederror": "error",`
	`13`	`+ "es-x/no-symbol-asyncdispose": "error",`
	`14`	`+ "es-x/no-symbol-dispose": "error",`
`13`	`15`	`"es-x/no-using-declarations": "error",`
`14`	`16`	`},`
`15`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,6 @@ module.exports = {`
`36`	`36`	`"es-x/no-set-prototype-issupersetof": "error",`
`37`	`37`	`"es-x/no-set-prototype-symmetricdifference": "error",`
`38`	`38`	`"es-x/no-set-prototype-union": "error",`
`39`		`- "es-x/no-symbol-asyncdispose": "error",`
`40`		`- "es-x/no-symbol-dispose": "error",`
`41`	`39`	`"es-x/no-trailing-dynamic-import-commas": "error",`
`42`	`40`	`},`
`43`	`41`	`}`