Fix false positives for built-in properties of object in no-*-prototype-* rules (#245)

Author: ota-meshi

lib/util/define-prototype-properties-handler/index.js

@@ -83,7 +83,10 @@ function definePrototypePropertiesHandler(context, propertyTypeMap, options) {
         propertyTypeMap,
     })
 
-    const propertyEntries = Object.entries(propertyTypeMap)
+    const propertyEntries = Object.entries(propertyTypeMap).map(
+        ([className, properties]) =>
+            /** @type {const} */ ([className, Object.keys(properties)]),
+    )
 
     /**
      * @param {MemberExpression|Property} node
@@ -126,7 +129,7 @@ function definePrototypePropertiesHandler(context, propertyTypeMap, options) {
     // eslint-disable-next-line func-style
     let verifyPropertyName = (node, propertyName, objectNode) => {
         for (const [className, properties] of propertyEntries) {
-            if (!properties[propertyName]) {
+            if (!properties.includes(propertyName)) {
                 continue
             }
             if (
@@ -145,7 +148,7 @@ function definePrototypePropertiesHandler(context, propertyTypeMap, options) {
         // For performance
         const [[className, properties]] = propertyEntries
         verifyPropertyName = (node, propertyName, objectNode) => {
-            if (!properties[propertyName]) {
+            if (!properties.includes(propertyName)) {
                 return
             }
             verifyClassPropertyName(node, className, propertyName, objectNode)

tests/lib/rules/no-array-prototype-at.js

@@ -23,6 +23,8 @@ new RuleTester().run(ruleId, rule, {
         },
         // Test for https://github.com/eslint-community/eslint-plugin-es-x/issues/223
         "for (const { x } of foo) {}",
+        `var array = [];
+         var constructor = array.constructor = {};`,
     ],
     invalid: [
         {

tests/lib/rules/no-array-prototype-every.js

@@ -21,6 +21,8 @@ new RuleTester().run(ruleId, rule, {
             options: [{ aggressive: false }],
             settings: { "es-x": { aggressive: true } },
         },
+        `var array = [];
+         var constructor = array.constructor = {};`,
     ],
     invalid: [
         {