fix: correctly handle rules that are missing meta or have meta / create defined in variables (#225)

Author: bmish

docs/rules/no-deprecated-context-methods.md

@@ -39,8 +39,8 @@ Examples of **incorrect** code for this rule:
 module.exports = {
   create (context) {
     return {
-      Program (node) {
-        const firstToken = context.getFirstToken(node);
+      Program (ast) {
+        const firstToken = context.getFirstToken(ast);
       },
     };
   },
@@ -55,8 +55,8 @@ module.exports = {
     const sourceCode = context.getSourceCode();
 
     return {
-      Program (node) {
-        const firstToken = sourceCode.getFirstToken(node);
+      Program (ast) {
+        const firstToken = sourceCode.getFirstToken(ast);
       },
     };
   },

lib/rules/fixer-return.js

@@ -93,8 +93,9 @@ module.exports = {
     }
 
     return {
-      Program (node) {
-        contextIdentifiers = utils.getContextIdentifiers(context, node);
+      Program (ast) {
+        const sourceCode = context.getSourceCode();
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
       },
 
       // Stacks this function's information.

lib/rules/no-deprecated-context-methods.js

@@ -58,8 +58,8 @@ module.exports = {
     // ----------------------------------------------------------------------
 
     return {
-      'Program:exit' () {
-        [...utils.getContextIdentifiers(context, sourceCode.ast)]
+      'Program:exit' (ast) {
+        [...utils.getContextIdentifiers(sourceCode.scopeManager, ast)]
           .filter(
             contextId =>
               contextId.parent.type === 'MemberExpression' &&

lib/rules/no-deprecated-report-api.js

@@ -36,8 +36,8 @@ module.exports = {
     // ----------------------------------------------------------------------
 
     return {
-      Program (node) {
-        contextIdentifiers = utils.getContextIdentifiers(context, node);
+      Program (ast) {
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
       },
       CallExpression (node) {
         if (

lib/rules/no-missing-placeholders.js

@@ -37,7 +37,8 @@ module.exports = {
 
     return {
       Program (ast) {
-        contextIdentifiers = utils.getContextIdentifiers(context, ast);
+        const sourceCode = context.getSourceCode();
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
       },
       CallExpression (node) {
         if (

lib/rules/no-unused-placeholders.js

@@ -37,7 +37,8 @@ module.exports = {
 
     return {
       Program (ast) {
-        contextIdentifiers = utils.getContextIdentifiers(context, ast);
+        const sourceCode = context.getSourceCode();
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
       },
       CallExpression (node) {
         if (

lib/rules/no-useless-token-range.js

@@ -107,7 +107,7 @@ module.exports = {
 
     return {
       'Program:exit' (ast) {
-        [...utils.getSourceCodeIdentifiers(context, ast)]
+        [...utils.getSourceCodeIdentifiers(sourceCode.scopeManager, ast)]
           .filter(identifier => identifier.parent.type === 'MemberExpression' &&
             identifier.parent.object === identifier &&
             identifier.parent.property.type === 'Identifier' &&

lib/rules/prefer-message-ids.js

@@ -36,9 +36,9 @@ module.exports = {
 
     return {
       Program (ast) {
-        contextIdentifiers = utils.getContextIdentifiers(context, ast);
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
 
-        if (info === null || info.meta === null) {
+        if (info === null) {
           return;
         }
 
@@ -49,7 +49,7 @@ module.exports = {
           metaNode.properties.find(p => p.type === 'Property' && utils.getKeyName(p) === 'messages');
 
         if (!messagesNode) {
-          context.report({ node: metaNode, messageId: 'messagesMissing' });
+          context.report({ node: metaNode || info.create, messageId: 'messagesMissing' });
           return;
         }
 

lib/rules/prefer-placeholders.js

@@ -39,8 +39,8 @@ module.exports = {
     // ----------------------------------------------------------------------
 
     return {
-      Program (node) {
-        contextIdentifiers = utils.getContextIdentifiers(context, node);
+      Program (ast) {
+        contextIdentifiers = utils.getContextIdentifiers(scopeManager, ast);
       },
       CallExpression (node) {
         if (

lib/rules/prefer-replace-text.js

@@ -38,8 +38,8 @@ module.exports = {
     let contextIdentifiers;
 
     return {
-      Program (node) {
-        contextIdentifiers = utils.getContextIdentifiers(context, node);
+      Program (ast) {
+        contextIdentifiers = utils.getContextIdentifiers(sourceCode.scopeManager, ast);
       },
 
       // Stacks this function's information.