Skip to content

Commit ca712cd

Browse files
committed
Add defaultOptions to all rules
1 parent e6a2f42 commit ca712cd

11 files changed

+38
-23
lines changed

lib/rules/consistent-output.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ module.exports = {
3232
default: 'consistent',
3333
},
3434
],
35+
defaultOptions: ['consistent'],
3536
messages: {
3637
missingOutput: 'This test case should have an output assertion.',
3738
},

lib/rules/meta-property-ordering.js

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,18 @@
66

77
const { getKeyName, getRuleInfo } = require('../utils');
88

9+
const defaultOrder = [
10+
'type',
11+
'docs',
12+
'fixable',
13+
'hasSuggestions',
14+
'deprecated',
15+
'replacedBy',
16+
'schema',
17+
'defaultOptions', // https://github.com/eslint/rfcs/tree/main/designs/2023-rule-options-defaults
18+
'messages',
19+
];
20+
921
// ------------------------------------------------------------------------------
1022
// Rule Definition
1123
// ------------------------------------------------------------------------------
@@ -28,6 +40,7 @@ module.exports = {
2840
elements: { type: 'string' },
2941
},
3042
],
43+
defaultOptions: [defaultOrder],
3144
messages: {
3245
inconsistentOrder:
3346
'The meta properties should be placed in a consistent order: [{{order}}].',
@@ -41,17 +54,7 @@ module.exports = {
4154
return {};
4255
}
4356

44-
const order = context.options[0] || [
45-
'type',
46-
'docs',
47-
'fixable',
48-
'hasSuggestions',
49-
'deprecated',
50-
'replacedBy',
51-
'schema',
52-
'defaultOptions', // https://github.com/eslint/rfcs/tree/main/designs/2023-rule-options-defaults
53-
'messages',
54-
];
57+
const order = context.options[0] || defaultOrder;
5558

5659
const orderMap = new Map(order.map((name, i) => [name, i]));
5760

lib/rules/no-property-in-node.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ module.exports = {
7070
additionalProperties: false,
7171
},
7272
],
73+
defaultOptions: [{ additionalNodeTypeFiles: [] }],
7374
messages: {
7475
in: 'Prefer checking specific node properties instead of a broad `in`.',
7576
},

lib/rules/report-message-format.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ module.exports = {
2929
type: 'string',
3030
},
3131
],
32+
defaultOptions: [''],
3233
messages: {
3334
noMatch: "Report message does not match the pattern '{{pattern}}'.",
3435
},

lib/rules/require-meta-docs-description.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ module.exports = {
3535
additionalProperties: false,
3636
},
3737
],
38+
defaultOptions: [{ pattern: '^(enforce|require|disallow)' }],
3839
messages: {
3940
extraWhitespace:
4041
'`meta.docs.description` must not have leading nor trailing whitespace.',

lib/rules/require-meta-docs-recommended.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ module.exports = {
2828
additionalProperties: false,
2929
},
3030
],
31+
defaultOptions: [{ allowNonBoolean: false }],
3132
messages: {
3233
incorrect: '`meta.docs.recommended` is required to be a boolean.',
3334
missing: '`meta.docs.recommended` is required.',

lib/rules/require-meta-docs-url.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ module.exports = {
4040
additionalProperties: false,
4141
},
4242
],
43+
defaultOptions: [{}],
4344
messages: {
4445
mismatch: '`meta.docs.url` property must be `{{expectedUrl}}`.',
4546
missing: '`meta.docs.url` property is missing.',

lib/rules/require-meta-fixable.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module.exports = {
3636
additionalProperties: false,
3737
},
3838
],
39+
defaultOptions: [{ catchNoFixerButFixableProperty: false }],
3940
messages: {
4041
invalid: '`meta.fixable` must be either `code`, `whitespace`, or `null`.',
4142
missing:

lib/rules/require-meta-schema.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ module.exports = {
3131
additionalProperties: false,
3232
},
3333
],
34+
defaultOptions: [{ requireSchemaPropertyWhenOptionless: true }],
3435
messages: {
3536
addEmptySchema: 'Add empty schema indicating the rule has no options.',
3637
foundOptionsUsage:

lib/rules/test-case-property-ordering.js

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,19 @@
77

88
const utils = require('../utils');
99

10+
const defaultOrder = [
11+
'filename',
12+
'code',
13+
'output',
14+
'options',
15+
'parser',
16+
'languageOptions', // flat-mode only
17+
'parserOptions', // eslintrc-mode only
18+
'globals', // eslintrc-mode only
19+
'env', // eslintrc-mode only
20+
'errors',
21+
];
22+
1023
// ------------------------------------------------------------------------------
1124
// Rule Definition
1225
// ------------------------------------------------------------------------------
@@ -30,6 +43,7 @@ module.exports = {
3043
elements: { type: 'string' },
3144
},
3245
],
46+
defaultOptions: [defaultOrder],
3347
messages: {
3448
inconsistentOrder:
3549
'The properties of a test case should be placed in a consistent order: [{{order}}].',
@@ -40,18 +54,7 @@ module.exports = {
4054
// ----------------------------------------------------------------------
4155
// Public
4256
// ----------------------------------------------------------------------
43-
const order = context.options[0] || [
44-
'filename',
45-
'code',
46-
'output',
47-
'options',
48-
'parser',
49-
'languageOptions', // flat-mode only
50-
'parserOptions', // eslintrc-mode only
51-
'globals', // eslintrc-mode only
52-
'env', // eslintrc-mode only
53-
'errors',
54-
];
57+
const order = context.options[0] || defaultOrder;
5558
const sourceCode = context.sourceCode || context.getSourceCode(); // TODO: just use context.sourceCode when dropping eslint < v9
5659

5760
return {

0 commit comments

Comments
 (0)