💥 upgrade dependencies

mysticatea · mysticatea · commit 36822aa832de · 2019-04-22T15:54:58.000+09:00
diff --git a/lib/configs/_ts.js b/lib/configs/_ts.js
@@ -19,6 +19,8 @@ module.exports = {
                 // Enabled rules
                 "@mysticatea/ts/adjacent-overload-signatures": "error",
                 "@mysticatea/ts/array-type": "error",
+                "@mysticatea/ts/await-thenable": "error",
+                "@mysticatea/ts/ban-ts-ignore": "error",
                 "@mysticatea/ts/class-name-casing": "error",
                 "@mysticatea/ts/explicit-member-accessibility": "error",
                 "@mysticatea/ts/interface-name-prefix": "error",
@@ -27,18 +29,34 @@ module.exports = {
                 "@mysticatea/ts/no-array-constructor": "error",
                 "@mysticatea/ts/no-empty-interface": "error",
                 "@mysticatea/ts/no-extraneous-class": "error",
+                "@mysticatea/ts/no-for-in-array": "error",
                 "@mysticatea/ts/no-inferrable-types": "error",
                 "@mysticatea/ts/no-misused-new": "error",
                 "@mysticatea/ts/no-object-literal-type-assertion": "error",
                 "@mysticatea/ts/no-parameter-properties": "error",
+                "@mysticatea/ts/no-require-imports": "error",
                 "@mysticatea/ts/no-this-alias": [
                     "error",
                     { allowDestructuring: true },
                 ],
                 "@mysticatea/ts/no-triple-slash-reference": "error",
+                "@mysticatea/ts/no-unnecessary-qualifier": "error",
+                "@mysticatea/ts/no-unnecessary-type-assertion": "error",
+                "@mysticatea/ts/no-useless-constructor": "error",
                 "@mysticatea/ts/no-var-requires": "error",
+                "@mysticatea/ts/prefer-function-type": "error",
+                "@mysticatea/ts/prefer-includes": "error",
                 "@mysticatea/ts/prefer-namespace-keyword": "error",
+                "@mysticatea/ts/prefer-string-starts-ends-with": "error",
                 "@mysticatea/ts/restrict-plus-operands": "error",
+                "@mysticatea/ts/require-array-sort-compare": "error",
+                "@mysticatea/ts/unbound-method": [
+                    // https://github.com/typescript-eslint/typescript-eslint/issues/451
+                    "off",
+                    { ignoreStatic: true },
+                ],
+                // https://github.com/typescript-eslint/typescript-eslint/issues/452
+                "@mysticatea/ts/unified-signatures": "off",
                 "@mysticatea/prettier": [
                     "error",
                     {
@@ -72,12 +90,15 @@ module.exports = {
                 "@mysticatea/ts/member-delimiter-style": "off", // favor of Prettier.
                 "@mysticatea/ts/member-ordering": "off",
                 "@mysticatea/ts/no-explicit-any": "off",
+                "@mysticatea/ts/no-extra-parens": "off", // favor of Prettier.
                 "@mysticatea/ts/no-namespace": "off", // I like the namespace for interfaces (type only things).
                 "@mysticatea/ts/no-non-null-assertion": "off",
                 "@mysticatea/ts/no-type-alias": "off",
                 "@mysticatea/ts/no-unused-vars": "off", // tsc verifies it.
                 "@mysticatea/ts/no-use-before-define": "off", // tsc verifies it.
+                "@mysticatea/ts/prefer-for-of": "off",
                 "@mysticatea/ts/prefer-interface": "off",
+                "@mysticatea/ts/promise-function-async": "off",
                 "@mysticatea/ts/type-annotation-spacing": "off", // favor of Prettier.
             },
             settings: {
diff --git a/lib/configs/_vue.js b/lib/configs/_vue.js
@@ -14,6 +14,30 @@ module.exports = {
             parser: require.resolve("vue-eslint-parser"),
             rules: {
                 // Enabled rules
+                "@mysticatea/vue/array-bracket-spacing": ["error", "never"],
+                "@mysticatea/vue/arrow-spacing": "error",
+                "@mysticatea/vue/block-spacing": "error",
+                "@mysticatea/vue/brace-style": "error",
+                "@mysticatea/vue/camelcase": "error",
+                "@mysticatea/vue/comma-dangle": [
+                    "error",
+                    {
+                        arrays: "always",
+                        objects: "always",
+                        imports: "always",
+                        exports: "always",
+                        functions: "always",
+                    },
+                ],
+                "@mysticatea/vue/comment-directive": "error",
+                "@mysticatea/vue/eqeqeq": [
+                    "error",
+                    "always",
+                    { null: "ignore" },
+                ],
+                "@mysticatea/vue/jsx-uses-vars": "error",
+                "@mysticatea/vue/key-spacing": "error",
+                "@mysticatea/vue/match-component-file-name": "error",
                 "@mysticatea/vue/max-attributes-per-line": [
                     "error",
                     {
@@ -24,9 +48,8 @@ module.exports = {
                         },
                     },
                 ],
-                "@mysticatea/vue/comment-directive": "error",
-                "@mysticatea/vue/jsx-uses-vars": "error",
                 "@mysticatea/vue/no-async-in-computed-properties": "error",
+                "@mysticatea/vue/no-boolean-default": "error",
                 "@mysticatea/vue/no-dupe-keys": "error",
                 "@mysticatea/vue/no-duplicate-attributes": "error",
                 "@mysticatea/vue/no-parsing-error": "error",
@@ -37,11 +60,16 @@ module.exports = {
                 "@mysticatea/vue/no-template-key": "error",
                 "@mysticatea/vue/no-textarea-mustache": "error",
                 "@mysticatea/vue/no-unused-vars": "error",
+                "@mysticatea/vue/object-curly-spacing": ["error", "always"],
                 "@mysticatea/vue/require-component-is": "error",
+                "@mysticatea/vue/require-direct-export": "error",
                 "@mysticatea/vue/require-render-return": "error",
                 "@mysticatea/vue/require-v-for-key": "error",
                 "@mysticatea/vue/require-valid-default-prop": "error",
                 "@mysticatea/vue/return-in-computed-property": "error",
+                "@mysticatea/vue/space-infix-ops": "error",
+                "@mysticatea/vue/space-unary-ops": "error",
+                "@mysticatea/vue/v-on-function-call": "error",
                 "@mysticatea/vue/valid-template-root": "error",
                 "@mysticatea/vue/valid-v-bind": "error",
                 "@mysticatea/vue/valid-v-cloak": "error",
@@ -95,9 +123,10 @@ module.exports = {
                 "@mysticatea/vue/no-use-v-if-with-v-for": "error",
                 "@mysticatea/vue/no-v-html": "error",
                 "@mysticatea/vue/require-prop-type-constructor": "error",
-                "@mysticatea/vue/use-v-on-exact": "off",
+                "@mysticatea/vue/use-v-on-exact": "error",
 
                 // Disabled rules (prefer prettier)
+                "@mysticatea/vue/no-restricted-syntax": "off",
                 "@mysticatea/vue/script-indent": "off",
             },
             settings: {
diff --git a/lib/configs/es5.js b/lib/configs/es5.js
@@ -35,7 +35,7 @@ module.exports = merge(
             curly: "error",
             "default-case": "error",
             "dot-notation": "error",
-            eqeqeq: ["error", "allow-null"],
+            eqeqeq: ["error", "always", { null: "ignore" }],
             "for-direction": "error",
             "func-style": ["error", "declaration"],
             "getter-return": "error",
@@ -178,6 +178,7 @@ module.exports = merge(
                 { blankLine: "always", next: "*", prev: "function" },
             ],
             "prefer-promise-reject-errors": "error",
+            quotes: ["error", "double", { avoidEscape: true }],
             radix: "error",
             "require-atomic-updates": "error",
             "require-await": "error",
@@ -261,7 +262,6 @@ module.exports = merge(
             "operator-linebreak": "off",
             "padded-blocks": "off",
             "quote-props": "off",
-            quotes: "off",
             "rest-spread-spacing": "off",
             semi: "off",
             "semi-spacing": "off",
@@ -348,6 +348,7 @@ module.exports = merge(
             "prefer-arrow-callback": "off",
             "prefer-const": "off",
             "prefer-destructuring": "off",
+            "prefer-named-capture-group": "off",
             "prefer-numeric-literals": "off",
             "prefer-rest-params": "off",
             "prefer-object-spread": "off",
diff --git a/lib/rules/arrow-parens.js b/lib/rules/arrow-parens.js
@@ -26,6 +26,7 @@ function isSameLine(a, b) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "enforce the parentheses style of arrow functions.",
             category: "Stylistic Issues",
diff --git a/lib/rules/block-scoped-var.js b/lib/rules/block-scoped-var.js
@@ -192,6 +192,7 @@ class PseudoScope {
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "disallow illegal usage of variables as block-scoped.",
             category: "Possible Errors",
diff --git a/lib/rules/no-instanceof-array.js b/lib/rules/no-instanceof-array.js
@@ -11,6 +11,7 @@
 
 module.exports = {
     meta: {
+        type: "problem",
         docs: {
             description: "disallow 'instanceof' for Array",
             category: "Best Practices",
diff --git a/lib/rules/no-instanceof-wrapper.js b/lib/rules/no-instanceof-wrapper.js
@@ -11,6 +11,7 @@
 
 module.exports = {
     meta: {
+        type: "problem",
         docs: {
             description: "disallow 'instanceof' for wrapper objects",
             category: "Best Practices",
diff --git a/lib/rules/no-literal-call.js b/lib/rules/no-literal-call.js
@@ -17,6 +17,7 @@ const LITERAL_AND_CLASS_TYPE = /^(?:(?:Array|Class|Object)Expression|(?:Template
 
 module.exports = {
     meta: {
+        type: "problem",
         docs: {
             description: "Disallow a call of a literal.",
             category: "Possible Errors",
diff --git a/lib/rules/no-this-in-static.js b/lib/rules/no-this-in-static.js
@@ -11,6 +11,7 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "Disallow `this`/`super` in static methods",
             category: "Best Practices",
diff --git a/lib/rules/no-use-ignored-vars.js b/lib/rules/no-use-ignored-vars.js
@@ -16,6 +16,7 @@ const DEFAULT_IGNORE_PATTERN = /^_[a-zA-Z]+$/u
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "Disallow a use of ignored variables.",
             category: "Stylistic Issues",
diff --git a/lib/rules/no-useless-rest-spread.js b/lib/rules/no-useless-rest-spread.js
@@ -93,6 +93,7 @@ function defineFixer(sourceCode, node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "Disallow unnecessary spread operators.",
             category: "Best Practices",
diff --git a/lib/rules/prefer-for-of.js b/lib/rules/prefer-for-of.js
@@ -107,7 +107,7 @@ function isCalledRecursively(context, node) {
  * @param {ASTNode} node - The `for` loop node to check.
  * @returns {boolean} `true` if the node is a simple array traversing.
  */
-//eslint-disable-next-line complexity, require-jsdoc
+//eslint-disable-next-line complexity
 function isTraversingArray(node) {
     const init = node.init
     const test = node.test
@@ -493,6 +493,7 @@ function fixForStatement(context, node, fixer) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
         docs: {
             description: "requires for-of statements instead of Array#forEach",
             category: "Best Practices",
diff --git a/package.json b/package.json
@@ -10,30 +10,31 @@
     "lib"
   ],
   "peerDependencies": {
-    "eslint": ">=5.12.1"
+    "eslint": ">=5.16.0"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "~1.1.1",
-    "@typescript-eslint/parser": "~1.1.1",
-    "eslint-plugin-eslint-comments": "~3.0.1",
-    "eslint-plugin-eslint-plugin": "~2.0.0",
-    "eslint-plugin-node": "~8.0.0",
-    "eslint-plugin-prettier": "~3.0.0",
-    "eslint-plugin-vue": "~5.1.0",
+    "@typescript-eslint/eslint-plugin": "~1.7.0",
+    "@typescript-eslint/parser": "~1.7.0",
+    "eslint-plugin-eslint-comments": "~3.1.1",
+    "eslint-plugin-eslint-plugin": "~2.0.1",
+    "eslint-plugin-node": "~8.0.1",
+    "eslint-plugin-prettier": "~3.0.1",
+    "eslint-plugin-vue": "~5.2.2",
     "prettier": "~1.14.3",
     "vue-eslint-parser": "^5.0.0"
   },
   "devDependencies": {
-    "@mysticatea/eslint-plugin": "^7.0.0",
-    "codecov": "^3.1.0",
-    "eslint": "~5.12.1",
+    "@mysticatea/eslint-plugin": "^9.0.1",
+    "codecov": "^3.3.0",
+    "eslint": "~5.16.0",
     "fs-extra": "^7.0.1",
-    "globals": "^11.9.0",
-    "mocha": "^5.2.0",
+    "globals": "^11.11.0",
+    "mocha": "^6.1.4",
     "npm-run-all": "^4.1.5",
-    "nyc": "^13.1.0",
+    "nyc": "^14.0.0",
     "opener": "^1.5.1",
-    "rimraf": "^2.6.2"
+    "rimraf": "^2.6.3",
+    "typescript": "~3.4.4"
   },
   "scripts": {
     "clean": "rimraf .nyc_output coverage",
diff --git a/tests/lib/configs/_rules.js b/tests/lib/configs/_rules.js
@@ -6,18 +6,23 @@
 
 const Validator = require("eslint/lib/config/config-validator")
 const Environments = require("eslint/lib/config/environments")
-const Plugins = require("eslint/lib/config/plugins")
-const Rules = require("eslint/lib/rules")
+const RulesIndex = require("eslint/lib/built-in-rules-index")
+const PluginRulesIndex = require("../../../lib/rules")
 
 const environments = new Environments()
-const allRules = new Rules()
-const coreRules = new Rules()
-const plugins = new Plugins(environments, allRules)
-
-plugins.define("@mysticatea", require("../../../index"))
+const coreRules = new Map(
+    Object.keys(RulesIndex).map(key => [key, RulesIndex[key]])
+)
+const pluginRules = new Map(
+    Object.keys(PluginRulesIndex).map(key => [
+        `@mysticatea/${key}`,
+        PluginRulesIndex[key],
+    ])
+)
+const allRules = new Map([...coreRules, ...pluginRules])
 
 const deprecatedRuleNames = new Set(
-    Array.from(allRules.getAllLoadedRules())
+    Array.from(allRules)
         .filter(([, rule]) => rule && rule.meta && rule.meta.deprecated)
         .map(([ruleId]) => ruleId)
 )
@@ -35,18 +40,17 @@ module.exports = {
     validateConfig(config, source) {
         Validator.validate(
             config,
-            source,
             ruleId => allRules.get(ruleId),
-            environments
+            environments,
+            source
         )
 
         /* istanbul ignore next */
-        const ruleMap = allRules.getAllLoadedRules()
         for (const ruleId of [].concat(
             Object.keys(config.rules || {}),
             ...(config.overrides || []).map(c => Object.keys(c.rules || {}))
         )) {
-            const rule = ruleMap.get(ruleId)
+            const rule = allRules.get(ruleId)
             if (rule == null) {
                 throw new Error(`The '${ruleId}' rule does not exist.`)
             }
@@ -73,7 +77,7 @@ module.exports = {
      * @returns {string[]} The core rule names.
      */
     getCoreRuleNames() {
-        return Array.from(coreRules.getAllLoadedRules().keys()).filter(
+        return Array.from(coreRules.keys()).filter(
             ruleId =>
                 !deprecatedRuleNames.has(ruleId) &&
                 !removedRuleNames.has(ruleId)
@@ -86,7 +90,7 @@ module.exports = {
      * @returns {object} The core rules. Keys are rule IDs and values are each rule definition.
      */
     getPluginRuleNames(pluginName) {
-        return Object.keys(plugins.get("@mysticatea").rules)
+        return Object.keys(PluginRulesIndex)
             .filter(
                 ruleId =>
                     pluginName === "@mysticatea"
diff --git a/tests/lib/rules/no-useless-rest-spread.js b/tests/lib/rules/no-useless-rest-spread.js
@@ -17,8 +17,7 @@ const rule = require("../../../lib/rules/no-useless-rest-spread")
 
 const ruleTester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2017,
-        ecmaFeatures: { experimentalObjectRestSpread: true },
+        ecmaVersion: 2018,
     },
 })
 
