chore: fix ESLint errors

MichaelDeBoey · MichaelDeBoey · commit 689f53069fa5 · 2022-10-16T19:48:44.000+02:00
diff --git a/lib/configs/+eslint-plugin.js b/lib/configs/+eslint-plugin.js
@@ -17,18 +17,19 @@ module.exports = {
                     "error",
                 "@eslint-community/mysticatea/eslint-plugin/fixer-return":
                     "error",
-                "@eslint-community/mysticatea/eslint-plugin/meta-property-ordering": [
-                    "error",
+                "@eslint-community/mysticatea/eslint-plugin/meta-property-ordering":
                     [
-                        "deprecated",
-                        "docs",
-                        "fixable",
-                        "messages",
-                        "replacedBy",
-                        "schema",
-                        "type",
+                        "error",
+                        [
+                            "deprecated",
+                            "docs",
+                            "fixable",
+                            "messages",
+                            "replacedBy",
+                            "schema",
+                            "type",
+                        ],
                     ],
-                ],
                 "@eslint-community/mysticatea/eslint-plugin/no-deprecated-context-methods":
                     "error",
                 "@eslint-community/mysticatea/eslint-plugin/no-deprecated-report-api":
@@ -49,36 +50,33 @@ module.exports = {
                     "error",
                 "@eslint-community/mysticatea/eslint-plugin/prefer-replace-text":
                     "error",
-                "@eslint-community/mysticatea/eslint-plugin/report-message-format": [
-                    "error",
-                    "[^a-z'\"{].*\\.$",
-                ],
+                "@eslint-community/mysticatea/eslint-plugin/report-message-format":
+                    ["error", "[^a-z'\"{].*\\.$"],
                 "@eslint-community/mysticatea/eslint-plugin/require-meta-docs-description":
                     "error",
-                "@eslint-community/mysticatea/eslint-plugin/require-meta-docs-url": [
-                    "error",
-                    { pattern: rulesDocumentUrl },
-                ],
+                "@eslint-community/mysticatea/eslint-plugin/require-meta-docs-url":
+                    ["error", { pattern: rulesDocumentUrl }],
                 "@eslint-community/mysticatea/eslint-plugin/require-meta-fixable":
                     "error",
                 "@eslint-community/mysticatea/eslint-plugin/require-meta-schema":
                     "error",
                 "@eslint-community/mysticatea/eslint-plugin/require-meta-type":
                     "error",
-                "@eslint-community/mysticatea/eslint-plugin/test-case-property-ordering": [
-                    "error",
+                "@eslint-community/mysticatea/eslint-plugin/test-case-property-ordering":
                     [
-                        "filename",
-                        "code",
-                        "output",
-                        "options",
-                        "parser",
-                        "parserOptions",
-                        "globals",
-                        "env",
-                        "errors",
+                        "error",
+                        [
+                            "filename",
+                            "code",
+                            "output",
+                            "options",
+                            "parser",
+                            "parserOptions",
+                            "globals",
+                            "env",
+                            "errors",
+                        ],
                     ],
-                ],
                 "@eslint-community/mysticatea/eslint-plugin/test-case-shorthand-strings":
                     "error",
             },
diff --git a/lib/configs/_override-vue.js b/lib/configs/_override-vue.js
@@ -155,20 +155,19 @@ module.exports = {
                 "@eslint-community/mysticatea/vue/html-quotes": "error",
                 "@eslint-community/mysticatea/vue/order-in-components": "error",
                 "@eslint-community/mysticatea/vue/this-in-template": "error",
-                "@eslint-community/mysticatea/vue/html-closing-bracket-newline": [
-                    "error",
-                    {
-                        singleline: "never",
-                        multiline: "always",
-                    },
-                ],
+                "@eslint-community/mysticatea/vue/html-closing-bracket-newline":
+                    [
+                        "error",
+                        {
+                            singleline: "never",
+                            multiline: "always",
+                        },
+                    ],
                 "@eslint-community/mysticatea/vue/html-closing-bracket-spacing":
                     "error",
                 "@eslint-community/mysticatea/vue/prop-name-casing": "error",
-                "@eslint-community/mysticatea/vue/component-name-in-template-casing": [
-                    "error",
-                    "kebab-case",
-                ],
+                "@eslint-community/mysticatea/vue/component-name-in-template-casing":
+                    ["error", "kebab-case"],
                 "@eslint-community/mysticatea/vue/multiline-html-element-content-newline":
                     "error",
                 "@eslint-community/mysticatea/vue/singleline-html-element-content-newline":
diff --git a/lib/processors/vue.js b/lib/processors/vue.js
@@ -22,7 +22,7 @@ module.exports = {
         }
 
         // Filter messages which are in disabled area.
-        return messages[0].filter(message => {
+        return messages[0].filter((message) => {
             if (
                 message.ruleId ===
                 "@eslint-community/mysticatea/vue/comment-directive"
diff --git a/lib/rules/arrow-parens.js b/lib/rules/arrow-parens.js
@@ -30,8 +30,7 @@ module.exports = {
             description: "enforce the parentheses style of arrow functions.",
             category: "Stylistic Issues",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/arrow-parens.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/arrow-parens.md",
         },
         fixable: "code",
         schema: [],
diff --git a/lib/rules/block-scoped-var.js b/lib/rules/block-scoped-var.js
@@ -9,8 +9,10 @@
 // Helpers
 //------------------------------------------------------------------------------
 
-const scopeNodeType = /^(?:(?:Block|Switch|For(?:In|Of)?)Statement|CatchClause|Program)$/u
-const containerNodeType = /^(?:For(?:In|Of)?Statement|(?:Arrow)?Function(?:Declaration|Expression))$/u
+const scopeNodeType =
+    /^(?:(?:Block|Switch|For(?:In|Of)?)Statement|CatchClause|Program)$/u
+const containerNodeType =
+    /^(?:For(?:In|Of)?Statement|(?:Arrow)?Function(?:Declaration|Expression))$/u
 
 /**
  * Checks whether or not a given definition should be skipped.
@@ -196,8 +198,7 @@ module.exports = {
             description: "disallow illegal usage of variables as block-scoped.",
             category: "Possible Errors",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/block-scoped-var.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/block-scoped-var.md",
         },
         fixable: null,
         schema: [],
diff --git a/lib/rules/no-instanceof-array.js b/lib/rules/no-instanceof-array.js
@@ -14,8 +14,7 @@ module.exports = {
         docs: {
             description: "disallow 'instanceof' for Array",
             category: "Best Practices",
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-instanceof-array.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-instanceof-array.md",
         },
         fixable: "code",
         schema: [],
@@ -64,7 +63,7 @@ module.exports = {
                         loc: node.loc,
                         message:
                             "Unexpected 'instanceof' operator. Use 'Array.isArray' instead.",
-                        fix: fixer =>
+                        fix: (fixer) =>
                             fixer.replaceText(
                                 node,
                                 `Array.isArray(${sourceCode.getText(
diff --git a/lib/rules/no-instanceof-wrapper.js b/lib/rules/no-instanceof-wrapper.js
@@ -14,8 +14,7 @@ module.exports = {
         docs: {
             description: "disallow 'instanceof' for wrapper objects",
             category: "Best Practices",
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-instanceof-wrapper.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-instanceof-wrapper.md",
         },
         fixable: "code",
         schema: [],
@@ -76,7 +75,7 @@ module.exports = {
                             message:
                                 "Unexpected 'instanceof' operator. Use 'typeof x === \"{{typeName}}\"' instead.",
                             data: { typeName },
-                            fix: fixer =>
+                            fix: (fixer) =>
                                 fixer.replaceText(
                                     node,
                                     `typeof ${sourceCode.getText(
diff --git a/lib/rules/no-literal-call.js b/lib/rules/no-literal-call.js
@@ -9,7 +9,8 @@
 //------------------------------------------------------------------------------
 
 const LITERAL_TYPE = /^(?:(?:Array|Object)Expression|(?:Template)?Literal)$/u
-const LITERAL_AND_CLASS_TYPE = /^(?:(?:Array|Class|Object)Expression|(?:Template)?Literal)$/u
+const LITERAL_AND_CLASS_TYPE =
+    /^(?:(?:Array|Class|Object)Expression|(?:Template)?Literal)$/u
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -21,8 +22,7 @@ module.exports = {
             description: "disallow a call of a literal.",
             category: "Possible Errors",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-literal-call.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-literal-call.md",
         },
         fixable: null,
         schema: [],
diff --git a/lib/rules/no-this-in-static.js b/lib/rules/no-this-in-static.js
@@ -14,8 +14,7 @@ module.exports = {
         docs: {
             description: "disallow `this`/`super` in static methods",
             category: "Best Practices",
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-this-in-static.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-this-in-static.md",
         },
         fixable: null,
         schema: [],
diff --git a/lib/rules/no-use-ignored-vars.js b/lib/rules/no-use-ignored-vars.js
@@ -20,8 +20,7 @@ module.exports = {
             description: "disallow a use of ignored variables.",
             category: "Stylistic Issues",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-use-ignored-vars.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-use-ignored-vars.md",
         },
         fixable: null,
         schema: [{ type: "string" }],
diff --git a/lib/rules/no-useless-rest-spread.js b/lib/rules/no-useless-rest-spread.js
@@ -8,7 +8,8 @@
 // Helpers
 //------------------------------------------------------------------------------
 
-const FUNC_TYPE = /^(?:FunctionDeclaration|(?:New|Call|(?:Arrow)?Function)Expression)$/u
+const FUNC_TYPE =
+    /^(?:FunctionDeclaration|(?:New|Call|(?:Arrow)?Function)Expression)$/u
 const PROPERTY_PATTERN = /^(?:Experimental)?(Rest|Spread)Property$/u
 
 /**
@@ -56,7 +57,7 @@ function getLastElementToken(sourceCode, node) {
  * @returns {function} A fixer function.
  */
 function defineFixer(sourceCode, node) {
-    return fixer => {
+    return (fixer) => {
         const child = node.argument
 
         // If the inner array includes holes, do nothing.
@@ -97,8 +98,7 @@ module.exports = {
             description: "disallow unnecessary spread operators.",
             category: "Best Practices",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-useless-rest-spread.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/no-useless-rest-spread.md",
         },
         fixable: "code",
         schema: [],
@@ -116,7 +116,7 @@ module.exports = {
         function verify(node) {
             const nodeType = node.type.replace(
                 PROPERTY_PATTERN,
-                t => `${t}Element`
+                (t) => `${t}Element`
             )
             const parentType = node.parent.type
             const argumentType = node.argument.type
@@ -131,11 +131,11 @@ module.exports = {
                     nodeType === "RestElement" && argumentType !== parentType
                 const type1 = nodeType === "RestElement" ? "rest" : "spread"
                 const type2 =
-                    /*eslint-disable @eslint-community/mysticatea/prettier */
+                    /* eslint-disable @eslint-community/mysticatea/prettier */
                     isRestParameter ? "parameter" :
                     isArray ? "element" :
                     /* otherwise */ "property"
-                    /*eslint-enable @eslint-community/mysticatea/prettier */
+                    /* eslint-enable @eslint-community/mysticatea/prettier */
 
                 context.report({
                     node,
diff --git a/lib/rules/prefer-for-of.js b/lib/rules/prefer-for-of.js
@@ -115,7 +115,7 @@ function isTraversingArray(node) {
     let indexDecl = null
     let lengthDecl = null
 
-    /*eslint-disable @eslint-community/mysticatea/prettier */
+    /* eslint-disable @eslint-community/mysticatea/prettier */
     return (
         init != null &&
         init.type === "VariableDeclaration" &&
@@ -186,7 +186,7 @@ function isTraversingArray(node) {
             )
         )
     )
-    /*eslint-enable @eslint-community/mysticatea/prettier */
+    /* eslint-enable @eslint-community/mysticatea/prettier */
 }
 
 /**
@@ -243,7 +243,7 @@ function isIndexVarOnlyUsedToGetArrayElements(context, node) {
     const arrayText = getArrayTextOfForStatement(sourceCode, node)
     const indexVar = context.getDeclaredVariables(node.init)[0]
 
-    return indexVar.references.every(reference => {
+    return indexVar.references.every((reference) => {
         const id = reference.identifier
 
         return (
@@ -273,7 +273,8 @@ function isLengthVarOnlyUsedToTest(context, node) {
     const lengthVar = context.getDeclaredVariables(node.init.declarations[1])[0]
 
     return lengthVar.references.every(
-        reference => reference.init || contains(node.test, reference.identifier)
+        (reference) =>
+            reference.init || contains(node.test, reference.identifier)
     )
 }
 
@@ -497,8 +498,7 @@ module.exports = {
             description: "requires for-of statements instead of Array#forEach",
             category: "Best Practices",
             recommended: false,
-            url:
-                "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/prefer-for-of.md",
+            url: "https://github.com/eslint-community/eslint-plugin-mysticatea/blob/HEAD/docs/rules/prefer-for-of.md",
         },
         fixable: "code",
         schema: [],
@@ -580,7 +580,7 @@ module.exports = {
                 if (
                     thisFuncInfo != null &&
                     thisFuncInfo.isTarget &&
-                    !thisFuncInfo.returnNodes.some(returnNode =>
+                    !thisFuncInfo.returnNodes.some((returnNode) =>
                         contains(returnNode, node)
                     )
                 ) {
diff --git a/scripts/generate-configs.js b/scripts/generate-configs.js
@@ -20,9 +20,9 @@ fs.writeFileSync(
 module.exports = {
 ${fs
     .readdirSync(path.resolve(__dirname, "../lib/configs"))
-    .map(fileName => path.basename(fileName, ".js"))
-    .filter(id => !id.startsWith("_"))
-    .map(id => `    "${id}": require("./configs/${id}"),`)
+    .map((fileName) => path.basename(fileName, ".js"))
+    .filter((id) => !id.startsWith("_"))
+    .map((id) => `    "${id}": require("./configs/${id}"),`)
     .join("\n")}
 }
 `
diff --git a/scripts/generate-rules.js b/scripts/generate-rules.js
@@ -20,14 +20,14 @@ fs.writeFileSync(
 module.exports = Object.assign(
 ${fs
     .readdirSync(path.resolve(__dirname, "../lib/foreign-rules"))
-    .map(fileName => path.basename(fileName, ".js"))
-    .map(id => `    require("./foreign-rules/${id}"),`)
+    .map((fileName) => path.basename(fileName, ".js"))
+    .map((id) => `    require("./foreign-rules/${id}"),`)
     .join("\n")}
     {
 ${fs
     .readdirSync(path.resolve(__dirname, "../lib/rules"))
-    .map(fileName => path.basename(fileName, ".js"))
-    .map(id => `        "${id}": require("./rules/${id}"),`)
+    .map((fileName) => path.basename(fileName, ".js"))
+    .map((id) => `        "${id}": require("./rules/${id}"),`)
     .join("\n")}
     }
 )
diff --git a/tests/lib/configs/_rules.js b/tests/lib/configs/_rules.js
diff --git a/tests/lib/rules/block-scoped-var.js b/tests/lib/rules/block-scoped-var.js
diff --git a/tests/lib/rules/prefer-for-of.js b/tests/lib/rules/prefer-for-of.js

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ module.exports = {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`// Filter messages which are in disabled area.`
`25`		`- return messages[0].filter(message => {`
	`25`	`+ return messages[0].filter((message) => {`
`26`	`26`	`if (`
`27`	`27`	`message.ruleId ===`
`28`	`28`	`"@eslint-community/mysticatea/vue/comment-directive"`