Skip to content

Commit 77e43ed

Browse files
fix(@eslint-community/mysticatea/ts/no-loss-of-precision): it's only available with ESLint >=v7.1 (#53)
1 parent 63e85eb commit 77e43ed

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

lib/configs/_override-ts.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
/**
2-
* @author Toru Nagashima
3-
* See LICENSE file in root directory for full license.
4-
*/
51
"use strict"
62

3+
const { Linter } = require("eslint")
4+
const semver = require("semver")
5+
6+
const isESLint71OrHigher = semver.gte(Linter.version, "7.1.0")
7+
78
module.exports = {
89
overrides: [
910
{
@@ -71,7 +72,15 @@ module.exports = {
7172
"@eslint-community/mysticatea/ts/no-inferrable-types": "error",
7273
"@eslint-community/mysticatea/ts/no-invalid-this": "error",
7374
"@eslint-community/mysticatea/ts/no-invalid-void-type": "error",
74-
"@eslint-community/mysticatea/ts/no-loss-of-precision": "error",
75+
...(isESLint71OrHigher
76+
? {
77+
"@eslint-community/mysticatea/ts/no-loss-of-precision":
78+
"error",
79+
}
80+
: {
81+
"@eslint-community/mysticatea/ts/no-loss-of-precision":
82+
"off",
83+
}), // TODO: enable fully once we drop v7 support
7584
"@eslint-community/mysticatea/ts/no-loop-func": "error",
7685
"@eslint-community/mysticatea/ts/no-meaningless-void-operator":
7786
"error",
@@ -162,7 +171,7 @@ module.exports = {
162171
"error",
163172
"@eslint-community/mysticatea/ts/triple-slash-reference":
164173
"error",
165-
// なんか誤検知が多い...
174+
// I get a lot of false positives...
166175
"@eslint-community/mysticatea/ts/unbound-method": [
167176
"off",
168177
{ ignoreStatic: true },

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,12 @@
5050
"eslint-plugin-prettier": "~3.4.1",
5151
"eslint-plugin-vue": "~8.7.1",
5252
"prettier": "~2.7.1",
53+
"semver": "^7.3.8",
5354
"vue-eslint-parser": "^8.3.0"
5455
},
5556
"devDependencies": {
56-
"@eslint/eslintrc": "^1.3.3",
5757
"@eslint-community/eslint-plugin-mysticatea": "file:.",
58+
"@eslint/eslintrc": "^1.3.3",
5859
"eslint": "~8.27.0",
5960
"globals": "^13.17.0",
6061
"mocha": "^9.2.2",

0 commit comments

Comments
 (0)