💥 update dependencies and configs

mysticatea · mysticatea · commit a59386ba1264 · 2019-07-03T06:29:27.000+09:00
diff --git a/.travis.yml b/.travis.yml
@@ -1,10 +1,8 @@
-sudo: false
-
 language: node_js
 node_js:
-  - "6.5.0"
   - "8"
   - "10"
+  - "12"
 
 after_success:
   - npm run codecov
diff --git a/lib/configs/+eslint-plugin.js b/lib/configs/+eslint-plugin.js
@@ -15,6 +15,18 @@ module.exports = {
                 // Enabled rules
                 "@mysticatea/eslint-plugin/consistent-output": "error",
                 "@mysticatea/eslint-plugin/fixer-return": "error",
+                "@mysticatea/eslint-plugin/meta-property-ordering": [
+                    "error",
+                    [
+                        "deprecated",
+                        "docs",
+                        "fixable",
+                        "messages",
+                        "replacedBy",
+                        "schema",
+                        "type",
+                    ],
+                ],
                 "@mysticatea/eslint-plugin/no-deprecated-context-methods":
                     "error",
                 "@mysticatea/eslint-plugin/no-deprecated-report-api": "error",
@@ -35,8 +47,20 @@ module.exports = {
                 ],
                 "@mysticatea/eslint-plugin/require-meta-fixable": "error",
                 "@mysticatea/eslint-plugin/require-meta-type": "error",
-                "@mysticatea/eslint-plugin/test-case-property-ordering":
+                "@mysticatea/eslint-plugin/test-case-property-ordering": [
                     "error",
+                    [
+                        "filename",
+                        "code",
+                        "output",
+                        "options",
+                        "parser",
+                        "parserOptions",
+                        "globals",
+                        "env",
+                        "errors",
+                    ],
+                ],
                 "@mysticatea/eslint-plugin/test-case-shorthand-strings":
                     "error",
             },
diff --git a/lib/configs/+modules.js b/lib/configs/+modules.js
@@ -10,6 +10,11 @@ module.exports = {
     },
     rules: {
         "@mysticatea/node/no-extraneous-import": "error",
+        "@mysticatea/node/file-extension-in-import": [
+            "error",
+            "always",
+            { ".js": "never", ".ts": "never", ".tsx": "never" },
+        ],
         "@mysticatea/node/no-missing-import": "error",
         "@mysticatea/node/no-unpublished-import": "error",
     },
diff --git a/lib/configs/+node.js b/lib/configs/+node.js
@@ -33,6 +33,8 @@ module.exports = {
         "@mysticatea/node/prefer-global/text-encoder": "off",
         "@mysticatea/node/prefer-global/url-search-params": "off",
         "@mysticatea/node/prefer-global/url": "off",
+        "@mysticatea/node/prefer-promises/dns": "off",
+        "@mysticatea/node/prefer-promises/fs": "off",
         "@mysticatea/node/process-exit-as-throw": "error",
         "@mysticatea/node/shebang": "error",
     },
diff --git a/lib/configs/_ts.js b/lib/configs/_ts.js
@@ -29,6 +29,7 @@ module.exports = {
                 "@mysticatea/ts/no-array-constructor": "error",
                 "@mysticatea/ts/no-empty-interface": "error",
                 "@mysticatea/ts/no-extraneous-class": "error",
+                "@mysticatea/ts/no-floating-promises": "error",
                 "@mysticatea/ts/no-for-in-array": "error",
                 "@mysticatea/ts/no-inferrable-types": "error",
                 "@mysticatea/ts/no-misused-new": "error",
@@ -41,20 +42,18 @@ module.exports = {
                 ],
                 "@mysticatea/ts/no-triple-slash-reference": "error",
                 "@mysticatea/ts/no-unnecessary-qualifier": "error",
-                // https://github.com/typescript-eslint/typescript-eslint/issues/453
-                "@mysticatea/ts/no-unnecessary-type-assertion": "off",
-                "@mysticatea/ts/no-useless-constructor": "error",
+                "@mysticatea/ts/no-unnecessary-type-assertion": "error",
                 "@mysticatea/ts/no-var-requires": "error",
                 // https://github.com/typescript-eslint/typescript-eslint/issues/454
                 "@mysticatea/ts/prefer-function-type": "off",
                 "@mysticatea/ts/prefer-includes": "error",
                 "@mysticatea/ts/prefer-namespace-keyword": "error",
+                "@mysticatea/ts/prefer-regexp-exec": "error",
                 "@mysticatea/ts/prefer-string-starts-ends-with": "error",
                 "@mysticatea/ts/restrict-plus-operands": "error",
                 "@mysticatea/ts/require-array-sort-compare": "error",
                 "@mysticatea/ts/unbound-method": [
-                    // https://github.com/typescript-eslint/typescript-eslint/issues/451
-                    "off",
+                    "error",
                     { ignoreStatic: true },
                 ],
                 // https://github.com/typescript-eslint/typescript-eslint/issues/452
@@ -72,6 +71,14 @@ module.exports = {
                     },
                 ],
 
+                // Replacements
+                camelcase: "off",
+                "@mysticatea/ts/camelcase": "error",
+                "no-empty-function": "off",
+                "@mysticatea/ts/no-empty-function": "error",
+                "no-useless-constructor": "off",
+                "@mysticatea/ts/no-useless-constructor": "error",
+
                 // Disabled rules
                 "func-style": "off",
                 "init-declarations": "off",
@@ -85,22 +92,24 @@ module.exports = {
                 "no-use-before-define": "off",
                 "one-var": "off",
                 "@mysticatea/ts/ban-types": "off",
-                "@mysticatea/ts/camelcase": "off", // ?
+                "@mysticatea/ts/consistent-type-definitions": "off",
                 "@mysticatea/ts/explicit-function-return-type": "off", // I want but this is not so...
+                "@mysticatea/ts/func-call-spacing": "off", // favor of Prettier.
                 "@mysticatea/ts/generic-type-naming": "off",
                 "@mysticatea/ts/indent": "off", // favor of Prettier.
                 "@mysticatea/ts/member-delimiter-style": "off", // favor of Prettier.
                 "@mysticatea/ts/member-ordering": "off",
                 "@mysticatea/ts/no-explicit-any": "off",
                 "@mysticatea/ts/no-extra-parens": "off", // favor of Prettier.
+                "@mysticatea/ts/no-magic-numbers": "off",
                 "@mysticatea/ts/no-namespace": "off", // I like the namespace for interfaces (type only things).
                 "@mysticatea/ts/no-non-null-assertion": "off",
                 "@mysticatea/ts/no-type-alias": "off",
                 "@mysticatea/ts/no-unused-vars": "off", // tsc verifies it.
                 "@mysticatea/ts/no-use-before-define": "off", // tsc verifies it.
                 "@mysticatea/ts/prefer-for-of": "off",
-                "@mysticatea/ts/prefer-interface": "off",
                 "@mysticatea/ts/promise-function-async": "off",
+                "@mysticatea/ts/semi": "off", // favor of Prettier.
                 "@mysticatea/ts/type-annotation-spacing": "off", // favor of Prettier.
             },
             settings: {
diff --git a/lib/rules/arrow-parens.js b/lib/rules/arrow-parens.js
@@ -26,7 +26,6 @@ function isSameLine(a, b) {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "enforce the parentheses style of arrow functions.",
             category: "Stylistic Issues",
@@ -36,6 +35,7 @@ module.exports = {
         },
         fixable: "code",
         schema: [],
+        type: "suggestion",
     },
     create(context) {
         return {
diff --git a/lib/rules/block-scoped-var.js b/lib/rules/block-scoped-var.js
@@ -192,7 +192,6 @@ class PseudoScope {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "disallow illegal usage of variables as block-scoped.",
             category: "Possible Errors",
@@ -202,6 +201,7 @@ module.exports = {
         },
         fixable: null,
         schema: [],
+        type: "suggestion",
     },
     create(context) {
         /**
diff --git a/lib/rules/no-instanceof-array.js b/lib/rules/no-instanceof-array.js
@@ -11,7 +11,6 @@
 
 module.exports = {
     meta: {
-        type: "problem",
         docs: {
             description: "disallow 'instanceof' for Array",
             category: "Best Practices",
@@ -20,6 +19,7 @@ module.exports = {
         },
         fixable: "code",
         schema: [],
+        type: "problem",
     },
 
     create(context) {
diff --git a/lib/rules/no-instanceof-wrapper.js b/lib/rules/no-instanceof-wrapper.js
@@ -11,7 +11,6 @@
 
 module.exports = {
     meta: {
-        type: "problem",
         docs: {
             description: "disallow 'instanceof' for wrapper objects",
             category: "Best Practices",
@@ -20,6 +19,7 @@ module.exports = {
         },
         fixable: "code",
         schema: [],
+        type: "problem",
     },
 
     create(context) {
diff --git a/lib/rules/no-literal-call.js b/lib/rules/no-literal-call.js
@@ -17,7 +17,6 @@ const LITERAL_AND_CLASS_TYPE = /^(?:(?:Array|Class|Object)Expression|(?:Template
 
 module.exports = {
     meta: {
-        type: "problem",
         docs: {
             description: "Disallow a call of a literal.",
             category: "Possible Errors",
@@ -27,6 +26,7 @@ module.exports = {
         },
         fixable: null,
         schema: [],
+        type: "problem",
     },
 
     create(context) {
diff --git a/lib/rules/no-this-in-static.js b/lib/rules/no-this-in-static.js
@@ -11,7 +11,6 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "Disallow `this`/`super` in static methods",
             category: "Best Practices",
@@ -20,6 +19,7 @@ module.exports = {
         },
         fixable: null,
         schema: [],
+        type: "suggestion",
     },
 
     create(context) {
diff --git a/lib/rules/no-use-ignored-vars.js b/lib/rules/no-use-ignored-vars.js
@@ -16,7 +16,6 @@ const DEFAULT_IGNORE_PATTERN = /^_[a-zA-Z]+$/u
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "Disallow a use of ignored variables.",
             category: "Stylistic Issues",
@@ -26,6 +25,7 @@ module.exports = {
         },
         fixable: null,
         schema: [{ type: "string" }],
+        type: "suggestion",
     },
 
     create(context) {
diff --git a/lib/rules/no-useless-rest-spread.js b/lib/rules/no-useless-rest-spread.js
@@ -93,7 +93,6 @@ function defineFixer(sourceCode, node) {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "Disallow unnecessary spread operators.",
             category: "Best Practices",
@@ -103,6 +102,7 @@ module.exports = {
         },
         fixable: "code",
         schema: [],
+        type: "suggestion",
     },
 
     create(context) {
@@ -130,11 +130,12 @@ module.exports = {
                 const isRestParameter =
                     nodeType === "RestElement" && argumentType !== parentType
                 const type1 = nodeType === "RestElement" ? "rest" : "spread"
-                const type2 = isRestParameter
-                    ? "parameter"
-                    : isArray
-                        ? "element"
-                        : /* otherwise */ "property"
+                const type2 =
+                    /*eslint-disable @mysticatea/prettier */
+                    isRestParameter ? "parameter" :
+                    isArray ? "element" :
+                    /* otherwise */ "property"
+                    /*eslint-enable @mysticatea/prettier */
 
                 context.report({
                     node,
diff --git a/lib/rules/prefer-for-of.js b/lib/rules/prefer-for-of.js
@@ -493,7 +493,6 @@ function fixForStatement(context, node, fixer) {
 
 module.exports = {
     meta: {
-        type: "suggestion",
         docs: {
             description: "requires for-of statements instead of Array#forEach",
             category: "Best Practices",
@@ -503,6 +502,7 @@ module.exports = {
         },
         fixable: "code",
         schema: [],
+        type: "suggestion",
     },
     create(context) {
         let funcInfo = null
diff --git a/package.json b/package.json
@@ -13,28 +13,28 @@
     "eslint": ">=5.16.0"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "~1.7.0",
-    "@typescript-eslint/parser": "~1.7.0",
-    "eslint-plugin-eslint-comments": "~3.1.1",
-    "eslint-plugin-eslint-plugin": "~2.0.1",
-    "eslint-plugin-node": "~8.0.1",
-    "eslint-plugin-prettier": "~3.0.1",
-    "eslint-plugin-vue": "~5.2.2",
-    "prettier": "~1.14.3",
+    "@typescript-eslint/eslint-plugin": "~1.11.0",
+    "@typescript-eslint/parser": "~1.11.0",
+    "eslint-plugin-eslint-comments": "~3.1.2",
+    "eslint-plugin-eslint-plugin": "~2.1.0",
+    "eslint-plugin-node": "~9.1.0",
+    "eslint-plugin-prettier": "~3.1.0",
+    "eslint-plugin-vue": "~5.2.3",
+    "prettier": "~1.18.2",
     "vue-eslint-parser": "^5.0.0"
   },
   "devDependencies": {
-    "@mysticatea/eslint-plugin": "^9.0.1",
-    "codecov": "^3.3.0",
-    "eslint": "~5.16.0",
-    "fs-extra": "^7.0.1",
-    "globals": "^11.11.0",
+    "@mysticatea/eslint-plugin": "file:.",
+    "codecov": "^3.5.0",
+    "eslint": "~6.0.1",
+    "fs-extra": "^8.1.0",
+    "globals": "^11.12.0",
     "mocha": "^6.1.4",
     "npm-run-all": "^4.1.5",
-    "nyc": "^14.0.0",
+    "nyc": "^14.1.1",
     "opener": "^1.5.1",
     "rimraf": "^2.6.3",
-    "typescript": "~3.4.4"
+    "typescript": "~3.5.2"
   },
   "scripts": {
     "clean": "rimraf .nyc_output coverage",
diff --git a/scripts/generate-configs.js b/scripts/generate-configs.js
@@ -19,11 +19,11 @@ fs.writeFileSync(
 
 module.exports = {
 ${fs
-        .readdirSync(path.resolve(__dirname, "../lib/configs"))
-        .map(fileName => path.basename(fileName, ".js"))
-        .filter(id => !id.startsWith("_"))
-        .map(id => `    "${id}": require("./configs/${id}"),`)
-        .join("\n")}
+    .readdirSync(path.resolve(__dirname, "../lib/configs"))
+    .map(fileName => path.basename(fileName, ".js"))
+    .filter(id => !id.startsWith("_"))
+    .map(id => `    "${id}": require("./configs/${id}"),`)
+    .join("\n")}
 }
 `
 )
diff --git a/scripts/generate-rules.js b/scripts/generate-rules.js
@@ -19,16 +19,16 @@ fs.writeFileSync(
 
 module.exports = Object.assign(
 ${fs
-        .readdirSync(path.resolve(__dirname, "../lib/foreign-rules"))
-        .map(fileName => path.basename(fileName, ".js"))
-        .map(id => `    require("./foreign-rules/${id}"),`)
-        .join("\n")}
+    .readdirSync(path.resolve(__dirname, "../lib/foreign-rules"))
+    .map(fileName => path.basename(fileName, ".js"))
+    .map(id => `    require("./foreign-rules/${id}"),`)
+    .join("\n")}
     {
 ${fs
-        .readdirSync(path.resolve(__dirname, "../lib/rules"))
-        .map(fileName => path.basename(fileName, ".js"))
-        .map(id => `        "${id}": require("./rules/${id}"),`)
-        .join("\n")}
+    .readdirSync(path.resolve(__dirname, "../lib/rules"))
+    .map(fileName => path.basename(fileName, ".js"))
+    .map(id => `        "${id}": require("./rules/${id}"),`)
+    .join("\n")}
     }
 )
 `
diff --git a/tests/lib/configs/_rules.js b/tests/lib/configs/_rules.js
diff --git a/tests/lib/rules/block-scoped-var.js b/tests/lib/rules/block-scoped-var.js
diff --git a/tests/lib/rules/no-instanceof-wrapper.js b/tests/lib/rules/no-instanceof-wrapper.js
diff --git a/tests/lib/rules/no-literal-call.js b/tests/lib/rules/no-literal-call.js
diff --git a/tests/lib/rules/prefer-for-of.js b/tests/lib/rules/prefer-for-of.js
