Skip to content

Commit ad8f4f4

Browse files
authored
chore: move rule tests parserOptions to ruleTester (#157)
it can help migrating to the eslint v9 RuleTester
1 parent bc6c538 commit ad8f4f4

33 files changed

+352
-708
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131
"@types/eslint": "^8.44.6",
3232
"@typescript-eslint/parser": "^5.60.0",
3333
"esbuild": "^0.18.7",
34-
"eslint": "^8.53.0",
34+
"eslint": "^8.56.0",
3535
"eslint-config-prettier": "^8.8.0",
3636
"eslint-doc-generator": "^1.6.1",
37-
"eslint-plugin-eslint-plugin": "^5.1.0",
37+
"eslint-plugin-eslint-plugin": "^5.2.1",
3838
"eslint-plugin-n": "file:.",
3939
"fast-glob": "^3.2.12",
4040
"husky": "^8.0.3",

tests/lib/rules/callback-return.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66

77
const RuleTester = require("eslint").RuleTester
88
const rule = require("../../../lib/rules/callback-return")
9+
const ruleTester = new RuleTester({ env: { node: true, es6: true } })
910

10-
new RuleTester().run("callback-return", rule, {
11+
ruleTester.run("callback-return", rule, {
1112
valid: [
1213
// callbacks inside of functions should return
1314
"function a(err) { if (err) return callback (err); }",
@@ -40,25 +41,20 @@ new RuleTester().run("callback-return", rule, {
4041
// arrow functions
4142
{
4243
code: "var x = err => { if (err) { callback(); return; } }",
43-
parserOptions: { ecmaVersion: 6 },
4444
},
4545
{
4646
code: "var x = err => callback(err)",
47-
parserOptions: { ecmaVersion: 6 },
4847
},
4948
{
5049
code: "var x = err => { setTimeout( () => { callback(); }); }",
51-
parserOptions: { ecmaVersion: 6 },
5250
},
5351

5452
// classes
5553
{
5654
code: "class x { horse() { callback(); } } ",
57-
parserOptions: { ecmaVersion: 6 },
5855
},
5956
{
6057
code: "class x { horse() { if (err) { return callback(); } callback(); } } ",
61-
parserOptions: { ecmaVersion: 6 },
6258
},
6359

6460
// options (only warns with the correct callback name)
@@ -188,7 +184,6 @@ new RuleTester().run("callback-return", rule, {
188184
},
189185
{
190186
code: "var x = (err) => { if (err) { callback (err); } }",
191-
parserOptions: { ecmaVersion: 6 },
192187
errors: [
193188
{
194189
messageId: "missingReturn",
@@ -200,7 +195,6 @@ new RuleTester().run("callback-return", rule, {
200195
},
201196
{
202197
code: "var x = { x(err) { if (err) { callback (err); } } }",
203-
parserOptions: { ecmaVersion: 6 },
204198
errors: [
205199
{
206200
messageId: "missingReturn",
@@ -223,7 +217,6 @@ new RuleTester().run("callback-return", rule, {
223217
},
224218
{
225219
code: "var x = { x(err) { if (err) { callback && callback (err); } } }",
226-
parserOptions: { ecmaVersion: 6 },
227220
errors: [
228221
{
229222
messageId: "missingReturn",
@@ -268,7 +261,6 @@ new RuleTester().run("callback-return", rule, {
268261
},
269262
{
270263
code: "var a = (err) => { callback (err); callback(); }",
271-
parserOptions: { ecmaVersion: 6 },
272264
errors: [
273265
{
274266
messageId: "missingReturn",
@@ -302,7 +294,6 @@ new RuleTester().run("callback-return", rule, {
302294
},
303295
{
304296
code: "class x { horse() { if (err) { callback(); } callback(); } } ",
305-
parserOptions: { ecmaVersion: 6 },
306297
errors: [
307298
{
308299
messageId: "missingReturn",
@@ -344,7 +335,6 @@ new RuleTester().run("callback-return", rule, {
344335
},
345336
{
346337
code: "() => { if (x) { callback(); } }",
347-
parserOptions: { ecmaVersion: 6 },
348338
errors: [
349339
{
350340
messageId: "missingReturn",

0 commit comments

Comments
 (0)