Skip to content

Commit af28d6f

Browse files
adrianmclimacklinu
authored andcommitted
fix(param-names): remove fixer (#146)
Fixes #145
1 parent 764f004 commit af28d6f

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ or start with the recommended rule set:
8080
| -------------------------------------------------------- | -------------------------------------------------------------------------------- | ----------- | -------- |
8181
| [`catch-or-return`][catch-or-return] | Enforces the use of `catch()` on un-returned promises. | :bangbang: | |
8282
| [`no-return-wrap`][no-return-wrap] | Avoid wrapping values in `Promise.resolve` or `Promise.reject` when not needed. | :bangbang: | |
83-
| [`param-names`][param-names] | Enforce consistent param names and ordering when creating new promises. | :bangbang: | :wrench: |
83+
| [`param-names`][param-names] | Enforce consistent param names and ordering when creating new promises. | :bangbang: | |
8484
| [`always-return`][always-return] | Return inside each `then()` to create readable and reusable Promise chains. | :bangbang: | |
8585
| [`no-native`][no-native] | In an ES5 environment, make sure to create a `Promise` constructor before using. | | |
8686
| [`no-nesting`][no-nesting] | Avoid nested `then()` or `catch()` statements | :warning: | |

__tests__/param-names.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,19 @@ ruleTester.run('param-names', rule, {
2222
invalid: [
2323
{
2424
code: 'new Promise(function(reject, resolve) {})',
25-
errors: [{ message }],
26-
output: 'new Promise(function(resolve, reject) {})'
25+
errors: [{ message }]
2726
},
2827
{
2928
code: 'new Promise(function(resolve, rej) {})',
30-
errors: [{ message }],
31-
output: 'new Promise(function(resolve, reject) {})'
29+
errors: [{ message }]
3230
},
3331
{
3432
code: 'new Promise(yes => {})',
35-
errors: [{ message }],
36-
output: 'new Promise(resolve => {})'
33+
errors: [{ message }]
3734
},
3835
{
3936
code: 'new Promise((yes, no) => {})',
40-
errors: [{ message }],
41-
output: 'new Promise((resolve, reject) => {})'
37+
errors: [{ message }]
4238
}
4339
]
4440
})

rules/param-names.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@ module.exports = {
2626
context.report({
2727
node,
2828
message:
29-
'Promise constructor parameters must be named resolve, reject',
30-
fix(fixer) {
31-
return [
32-
fixer.replaceText(params[0], 'resolve'),
33-
params[1] && fixer.replaceText(params[1], 'reject')
34-
].filter(Boolean)
35-
}
29+
'Promise constructor parameters must be named resolve, reject'
3630
})
3731
}
3832
}

0 commit comments

Comments
 (0)