Skip to content

Commit 7b7f831

Browse files
authored
fix: semver calculations for defineConfig import (#168)
* fix: semver calculations for `defineConfig` import * Update lib/config-generator.js
1 parent fb20451 commit 7b7f831

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/config-generator.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import path from "node:path";
1212
import { spawnSync } from "node:child_process";
1313
import { writeFile } from "node:fs/promises";
1414
import enquirer from "enquirer";
15-
import semverSatisfies from "semver/functions/satisfies.js";
15+
import semverGreaterThanRange from "semver/ranges/gtr.js";
1616
import { isPackageTypeModule, installSyncSaveDev, fetchPeerDependencies, findPackageJson } from "./utils/npm-utils.js";
1717
import { getShorthandName } from "./utils/naming.js";
1818
import * as log from "./utils/logging.js";
@@ -251,7 +251,7 @@ export class ConfigGenerator {
251251
const versionRequirement = versionMatch[1]; // Complete version requirement string
252252

253253
// Check if the version requirement allows for ESLint 9.22.0+
254-
isDefineConfigExported = semverSatisfies("9.22.0", versionRequirement);
254+
isDefineConfigExported = !semverGreaterThanRange("9.22.0", versionRequirement);
255255

256256
// eslint is in the peer dependencies => overwrite eslint version
257257
this.result.devDependencies[0] = peers[eslintIndex];

tests/__snapshots__/config@eslint-config-xo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default defineConfig([
88
]);",
99
"configFilename": "eslint.config.mjs",
1010
"devDependencies": [
11-
"eslint@>=9.8.0",
11+
"eslint@>=9.25.0",
1212
"eslint-config-xo",
1313
],
1414
"installFlags": [

0 commit comments

Comments
 (0)