|
| 1 | +# 04/17/2025 ESLint TSC Meeting Transcript |
| 2 | + |
| 3 | +**mdjermanovic:** Hi! |
| 4 | + |
| 5 | +**fasttime:** Hi! |
| 6 | + |
| 7 | +**nzakas:** Howdy! |
| 8 | + |
| 9 | +**nzakas:** Just pulling up last meeting's notes |
| 10 | + |
| 11 | +**nzakas:** Okay, doesn't look like we had any followups. |
| 12 | + |
| 13 | +**nzakas:** Let's start with statuses. I've been working on CSSTree, adding types to the CSS plugin, and the MCP server. |
| 14 | + |
| 15 | +**mdjermanovic:** I was mostly reviewing PRs |
| 16 | + |
| 17 | +**fasttime:** I've been reviewing PRs and working on the multithread linting RFC. |
| 18 | + |
| 19 | +**nzakas:** Okay, what's everyone's availability in the next couple of weeks? I'm still likely looking at about an hour each week day for at least another week. |
| 20 | + |
| 21 | +**mdjermanovic:** I expect to be available 1.5-2 hours every day |
| 22 | + |
| 23 | +**fasttime:** I expect to be working 10-12 hours a week. |
| 24 | + |
| 25 | +**nzakas:** And RFC duty: |
| 26 | +This week - @mdjermanovic |
| 27 | +April 21 - @fasttime |
| 28 | +April 28 - @nzakas |
| 29 | + * 👍 @mdjermanovic, @fasttime |
| 30 | + |
| 31 | +**nzakas:** Please double check that 😄 |
| 32 | + |
| 33 | +**nzakas:** It looks like we don't have any issues flagged for today. Are there any topics anyone would like to discuss? |
| 34 | + |
| 35 | +**fasttime:** Nothing from my side. |
| 36 | + |
| 37 | +**mdjermanovic:** Maybe this one. Any concerns about turning suggestions into autofixes? https://github.com/eslint/eslint/issues/19608 |
| 38 | + |
| 39 | +**nzakas:** Given that we couldn't find any rationalization for why it was a suggestion instead of an autofix, I'm okay with switching to an autofix. |
| 40 | + |
| 41 | +**fasttime:** I'm fine with switching to autofixes. We could probably do the same thing in other rules like `no-object-constructor`. |
| 42 | + |
| 43 | +**mdjermanovic:** Okay then, I'll mark it as accepted |
| 44 | + * 👍 @nzakas, @fasttime |
| 45 | + |
| 46 | +**nzakas:** Any others? |
| 47 | + |
| 48 | +**mdjermanovic:** There's another issue for which we have an ongoing PR and are already reviewing it but haven't officially accepted it yet: https://github.com/eslint/eslint/issues/19581 |
| 49 | + |
| 50 | +**mdjermanovic:** The proposal is to add a new rule |
| 51 | + |
| 52 | +**nzakas:** The issue is marked as accepted? |
| 53 | + |
| 54 | +**mdjermanovic:** Oh yes, it does, I didn't notice it. Please disregard then |
| 55 | + |
| 56 | +**nzakas:** As for the name, I think `no-unassigned-vars` is fine. |
| 57 | + * 👍 @mdjermanovic, @fasttime |
| 58 | + |
| 59 | +**mdjermanovic:** Sounds good to me |
| 60 | + |
| 61 | +**nzakas:** Any others? |
| 62 | + |
| 63 | +**mdjermanovic:** Nothing else in particular from my side |
| 64 | + |
| 65 | +**nzakas:** @fasttime ? |
| 66 | + |
| 67 | +**fasttime:** No, I don't have any issues to discuss for today. |
| 68 | + |
| 69 | +**nzakas:** Let's talk a bit about our process. I'm still finding that my PRs seem to be getting lost without reviews for weeks. Two examples: |
| 70 | +https://github.com/eslint/rewrite/pull/172 |
| 71 | +https://github.com/eslint/eslint/pull/19592 |
| 72 | + |
| 73 | +**nzakas:** We talked a couple meetings ago about prioritizing each other's PRs. That doesn't seem to be happening. What can we do to tighten the feedback loop? |
| 74 | + |
| 75 | +**mdjermanovic:** Yeah, those are relatively big ones. I couldn't find enough continuous amount of time to focus on reviewing them. |
| 76 | + |
| 77 | +**mdjermanovic:** I could start reviewing the migrate-config one this weekend |
| 78 | + |
| 79 | +**mdjermanovic:** For the MCP server, I'm not familiar with the subject so I'll need to do some learning first. |
| 80 | + |
| 81 | +**fasttime:** The MCP PR has received a suggestion. |
| 82 | + |
| 83 | +**fasttime:** Or rather, the respective issue. |
| 84 | + |
| 85 | +**nzakas:** The issue received an idea for an enhancement, yes. I don't think it's necessary for the first version. I think it's more important to get something out and let people give us feedback than to wait for the perfect implementation. |
| 86 | + |
| 87 | +**nzakas:** I also don't want other linters to beat us to getting an MCP server out. |
| 88 | + |
| 89 | +**fasttime:** I could review the MCP PR this weekend I guess. |
| 90 | + |
| 91 | +**nzakas:** Could I ask you to look at it before the release? 😄 Otherwise it's another two weeks. |
| 92 | + |
| 93 | +**fasttime:** Tomorrow, I'm afraid I won't do it. |
| 94 | + |
| 95 | +**nzakas:** 😢 |
| 96 | + |
| 97 | +**nzakas:** If you both can please prioritize these two PRs, I'd appreciate it. |
| 98 | + |
| 99 | +**nzakas:** And I'd still like to know how we can avoid this going forward. I appreciate needing a chunk of time to review larger PRs, I just don't think putting it off for two weeks is an acceptable approach if we want to be able to ship things. |
| 100 | + |
| 101 | +**mdjermanovic:** I'll like to learn about the subject and review the PR, but I don't think I'll be able to do it properly tomorrow |
| 102 | + |
| 103 | +**fasttime:** For me, I'm not familiar with the topic, so I'd also have to find the time to learn one thing or two. |
| 104 | + |
| 105 | +**fasttime:** But I think the documentation online is helpful, from what I saw. |
| 106 | + |
| 107 | +**nzakas:** MCP is just another spin on REST, but specific to LLMs. resources are like GET requests, tools are like POST requests. That's about 70% of what you need to know: https://modelcontextprotocol.io/introduction |
| 108 | + * 👍 @mdjermanovic, @fasttime |
| 109 | + |
| 110 | +**nzakas:** And this specifically for servers: https://modelcontextprotocol.io/quickstart/server |
| 111 | + * 👍 @mdjermanovic, @fasttime |
| 112 | + |
| 113 | +**nzakas:** I'd still like to talk process so larger PRs don't sit like these did. Any ideas? |
| 114 | + |
| 115 | +**mdjermanovic:** Nothing in particular than what we said (but didn't follow the past two weeks) - to prioritize reviewing |
| 116 | + |
| 117 | +**nzakas:** Can we maybe agree to set one day aside each week to just focus on each other's PRs? |
| 118 | + * 👍 @mdjermanovic |
| 119 | + |
| 120 | +**fasttime:** The one thing I could imagine is focusing more on reviewing PRs, but that's already around 50% of what I'm doing. |
| 121 | + |
| 122 | +**fasttime:** Which day would it be? |
| 123 | + |
| 124 | +**nzakas:** I don't think we need to coordinate, it can be up to each of us. Just an agreement that one each week we'll focus on our PRs. |
| 125 | + |
| 126 | +**mdjermanovic:** Sounds good to me |
| 127 | + |
| 128 | +**fasttime:** Sounds good to me, too. |
| 129 | + |
| 130 | +**nzakas:** Okay, we've agreed to dedicate one day a week to reviewing each other's PRs. We'll see how it goes. Thanks! |
| 131 | + * 👍 @mdjermanovic, @fasttime |
| 132 | + |
| 133 | +**nzakas:** Let's talk about the release |
| 134 | + |
| 135 | +**mdjermanovic:** I can tomorrow |
| 136 | + * 🙏 @nzakas |
| 137 | + |
| 138 | +**fasttime:** Thanks! |
| 139 | + |
| 140 | +**mdjermanovic:** `eslint` and `@eslint/js` as usual |
| 141 | + |
| 142 | +**mdjermanovic:** eslint/rewrite packages? https://github.com/eslint/rewrite/pull/179 |
| 143 | + |
| 144 | +**nzakas:** That's the type updates. The other updates are bogus dev dependency stuff. I think I'd like to see if we can split out the `@eslint/core` release from the rest |
| 145 | + |
| 146 | +**fasttime:** I believe the only interesting change since last version is https://github.com/eslint/rewrite/pull/178, but since that's not used in any repos yet, we could also delay the release. |
| 147 | + |
| 148 | +**mdjermanovic:** Okay, then we'll postpone that |
| 149 | + * 👍 @fasttime |
| 150 | + |
| 151 | +**mdjermanovic:** All three of the language plugins (`@eslint/json`, `@eslint/markdown`, `@eslint/css`) have pending releases. I could release them after the meeting if there are no objections |
| 152 | + * 👍 @nzakas, @fasttime |
| 153 | + |
| 154 | +**nzakas:** Okay, I think that's it for today. Thanks everyone ( and thanks @sam3k_ for the notes) |
| 155 | + |
| 156 | +**mdjermanovic:** Thanks! 👋 |
| 157 | + |
| 158 | +**fasttime:** Thanks! Bye 👋 |
0 commit comments