|
| 1 | +# 06/26/2025 ESLint TSC Meeting Transcript |
| 2 | + |
| 3 | +**mdjermanovic:** Hi! |
| 4 | + |
| 5 | +**fasttime:** Hi! |
| 6 | + |
| 7 | +**nzakas:** Howdy! |
| 8 | + |
| 9 | +**nzakas:** Just going to pull up the notes from last meeting |
| 10 | + |
| 11 | +**nzakas:** We had a couple of followups. @mdjermanovic to investigate the rule options behavior. This was related to https://github.com/eslint/eslint/pull/19843. That was completed. I now need to update that PR. |
| 12 | + |
| 13 | +**nzakas:** And for me, I was going to investigate automating the contributor pool report, which I just opened a PR for: https://github.com/eslint/tsc-meetings/pull/593 |
| 14 | + * 👍 @mdjermanovic, @fasttime |
| 15 | + |
| 16 | +**nzakas:** Let's do statuses next. For me, I spent most of my time on CSS variable tracking, refactoring the core reporting into a new `FileReport` class, and adding token methods to `JSONSourceCode`. |
| 17 | + |
| 18 | +**mdjermanovic:** I was working on the `basePath` feature |
| 19 | + |
| 20 | +**fasttime:** I've been busy with the multithread linting prototype and different reviews, 50/50. |
| 21 | + |
| 22 | +**nzakas:** Let's talk availability over the next couple of weeks. I'll be around 2.5-3 hours each weekday except for Friday July 4, which is a holiday in the US. |
| 23 | + |
| 24 | +**mdjermanovic:** I'm expecting to be available 2 hours each day until (including) July 6th. Then I'll be mostly offline July 7-11 |
| 25 | + |
| 26 | +**fasttime:** I should be available 7-9 hours per week the next two weeks. |
| 27 | + |
| 28 | +**nzakas:** RFC Duty: |
| 29 | +This week - @fasttime |
| 30 | +June 30 - @nzakas |
| 31 | + * 👍 @fasttime |
| 32 | + |
| 33 | +**nzakas:** Should we rotate back to @fasttime for July 7 given that @mdjermanovic is off? |
| 34 | + |
| 35 | +**mdjermanovic:** Yes, I'll be away that exact week. Maybe I could switch with someone (take the next week, or the one after)? |
| 36 | + |
| 37 | +**fasttime:** I can take the July 7 week |
| 38 | + |
| 39 | +**mdjermanovic:** Alright, then I'could take the week after |
| 40 | + |
| 41 | +**nzakas:** If I swap with @mdjermanovic then @fasttime gets your usual break in between |
| 42 | + |
| 43 | +**mdjermanovic:** That's also fine with me |
| 44 | + |
| 45 | +**nzakas:** So June 30 would be @mdjermanovic and July 7 would be me. |
| 46 | + |
| 47 | +**mdjermanovic:** Works for me |
| 48 | + |
| 49 | +**fasttime:** Okay, let's do that |
| 50 | + |
| 51 | +**nzakas:** Okay, updated RFC duty: |
| 52 | +This week - @fasttime |
| 53 | +June 30 - @mdjermanovic |
| 54 | +July 7- @nzakas |
| 55 | + * 👍 @mdjermanovic, @fasttime |
| 56 | + |
| 57 | +**nzakas:** I just had one PR I flagged for today: |
| 58 | +https://github.com/eslint/rewrite/pull/231 |
| 59 | + |
| 60 | +**nzakas:** Basically the same change as the one we made for `@eslint/compat`. Do we want to move forward with this? |
| 61 | + |
| 62 | +**fasttime:** `@eslint/compat` already had a peer dependency on ESLint, we just relaxed the version range to allow installing that package alongside ESLint 8 |
| 63 | + |
| 64 | +**fasttime:** I think that for `config-helpers`, the request is about adding a peer dependency, and that should be on ESLint "^9.10.0`" because of the types? |
| 65 | + |
| 66 | +**nzakas:** Ah, I misunderstood |
| 67 | + |
| 68 | +**nzakas:** `@eslint/config-helpers` is also supposed to work with ESLint v8 |
| 69 | + |
| 70 | +**fasttime:** Unless we want to allow installing `config-helpers` with ESLint 8, then it would be the same I think. |
| 71 | + |
| 72 | +**nzakas:** https://eslint.org/blog/2025/03/flat-config-extends-define-config-global-ignores/#support-for-older-eslint-versions |
| 73 | + |
| 74 | +**nzakas:** We called out using it in v8 in the blog post |
| 75 | + |
| 76 | +**nzakas:** Of course, the types won't be correct for v8 |
| 77 | + |
| 78 | +**fasttime:** Then maybe we could check what minimum ESLint v8 version is supported? |
| 79 | + |
| 80 | +**mdjermanovic:** ESLint v8 users could still use the older version of config-helpers? |
| 81 | + |
| 82 | +**nzakas:** They'd then get the same error mentioned in the PR, that types from `eslint` can't be found. |
| 83 | + |
| 84 | +**nzakas:** We can just say "oh well" and live with it, of course. 🙂 |
| 85 | + |
| 86 | +**mdjermanovic:** Well, we can't add types back to v8, so in the sense of types, config-helpers is indeed incompatible with eslint v8? |
| 87 | + |
| 88 | +**nzakas:** Only if you're using TypeScript to validate your config file. |
| 89 | + |
| 90 | +**nzakas:** Functionally it works fine |
| 91 | + |
| 92 | +**mdjermanovic:** Yes, that's what I meant. |
| 93 | + |
| 94 | +**nzakas:** Primary issue is the `Linter.Config` type, which was eslintrc in v8 and flat in v9 |
| 95 | + |
| 96 | +**fasttime:** I also think types are not necessary. The only effect of the optional peer dependency will be automatically installing a matching version of ESLint if none is present. |
| 97 | + |
| 98 | +**nzakas:** So would we want to set it at `^9`? |
| 99 | + |
| 100 | +**fasttime:** Maybe yes if it's optional. |
| 101 | + |
| 102 | +**mdjermanovic:** Optional means that it isn't required, but if one is present then it must match the range? |
| 103 | + |
| 104 | +**fasttime:** I'm not sure. Would have to check that. npm changed things a couple of times. |
| 105 | + |
| 106 | +**nzakas:** I think what we want to avoid is someone getting a warning when they install `@eslint/config-helpers` alongside `eslint@^8`, correct? |
| 107 | + |
| 108 | +**fasttime:** I think yes |
| 109 | + |
| 110 | +**mdjermanovic:** I also think yes, as said it works fine functionally |
| 111 | + |
| 112 | +**nzakas:** This seems to be another argument for moving those types into `@eslint/core` to eliminate the direct dependency on `eslint` and therefore avoid this problem. |
| 113 | + |
| 114 | +**nzakas:** I could have sworn there was an open issue about this.. |
| 115 | + |
| 116 | +**fasttime:** Yes, many packages have separate types. |
| 117 | + |
| 118 | +**nzakas:** https://github.com/eslint/rewrite/issues/226 |
| 119 | + |
| 120 | +**nzakas:** It seems like finishing up this work is actually the solution to the problem. |
| 121 | + * 👍 @mdjermanovic |
| 122 | + |
| 123 | +**fasttime:** I don't recall an issue about moving all ESLint types to the core. Maybe we can create one? |
| 124 | + |
| 125 | +**nzakas:** (see above) |
| 126 | + |
| 127 | +**nzakas:** And not all ESLint types, just the core ones (essentially `Config`, and all necessary types to implement it) |
| 128 | + * 👍 @mdjermanovic |
| 129 | + |
| 130 | +**fasttime:** Makes sense, still it's not very clear from the issue description. |
| 131 | + |
| 132 | +**nzakas:** Yeah, the issue started as being about `@eslint/config-helpers` and the conversation flowed into creating a separate package for types and then to using `@eslint/core` for this purpose. |
| 133 | + |
| 134 | +**nzakas:** So to wrap up this discussion, it sounds like we've agreed: |
| 135 | + |
| 136 | +1. Not to accept the PR |
| 137 | +2. Move forward with moving types into `@eslint/core` to solve this problem |
| 138 | + * 👍 @mdjermanovic, @fasttime |
| 139 | + |
| 140 | +**nzakas:** Okay, I'll prioritize working on this in the next couple of weeks. |
| 141 | + |
| 142 | +**nzakas:** Any other issues or PRs anyone would like to discuss? |
| 143 | + |
| 144 | +**mdjermanovic:** Yes, the question raised here about the flags: https://github.com/eslint/eslint/pull/19879#pullrequestreview-2963194460 |
| 145 | + |
| 146 | +**mdjermanovic:** Do we want to update the flag along with the last known bug fix, or wait till the next version after the bug fix is released |
| 147 | + |
| 148 | +**nzakas:** I'm not sure if this is really a bug fix vs. a feature. |
| 149 | + |
| 150 | +**mdjermanovic:** It's a feature that also fixes a bug 🙂 |
| 151 | + |
| 152 | +**nzakas:** True 🙂 |
| 153 | + |
| 154 | +**nzakas:** To me, the decision of whether to flip from unstable to v10 is if we believe this is now feature complete. |
| 155 | + |
| 156 | +**mdjermanovic:** I was thinking that we'd like to wait to wait one version to see if everything is stable |
| 157 | + |
| 158 | +**nzakas:** What does stable mean to you? |
| 159 | + |
| 160 | +**mdjermanovic:** Feature complete & no bugs |
| 161 | + |
| 162 | +**nzakas:** Okay, see stable to me means feature complete but there may be bugs. 🙂 |
| 163 | + |
| 164 | +**mdjermanovic:** Ah, okay, from that point of view we could update the flag |
| 165 | + * 👍 @fasttime |
| 166 | + |
| 167 | +**nzakas:** I don't feel strongly either way, just want to make sure we're speaking the same language. |
| 168 | + |
| 169 | +**mdjermanovic:** @fasttime what do you think? Update the flag in the PR or in a subsequent release? |
| 170 | + |
| 171 | +**nzakas:** If we want to wait a release to ensure there aren't any bugs, I'm fine with that. |
| 172 | + |
| 173 | +**fasttime:** I'd say update the flag with the PR because there's no guarantee that there will be no bugs, but I'm also fine either way |
| 174 | + |
| 175 | +**mdjermanovic:** Alright, I'll update the PR to update the flag |
| 176 | + * 👍 @nzakas, @fasttime |
| 177 | + |
| 178 | +**nzakas:** We've decided to update `unstable_config_lookup_from_file` to `v10_config_lookup_from_file`. |
| 179 | + * 👍 @mdjermanovic |
| 180 | + |
| 181 | +**nzakas:** That means when @mdjermanovic is back, we can start discussing v10. 🎉 |
| 182 | + * 🎉 @michael.faith, @mdjermanovic, @fasttime |
| 183 | + |
| 184 | +**nzakas:** Okay, any other issues or PRs to discuss? |
| 185 | + |
| 186 | +**mdjermanovic:** There shouldn't be `unstable` after `v10_`? |
| 187 | + |
| 188 | +**nzakas:** 🤦♂️ |
| 189 | + |
| 190 | +**nzakas:** My fingers got away from me 🙂 |
| 191 | + |
| 192 | +**mdjermanovic:** Alright, `v10_config_lookup_from_file` |
| 193 | + * 👍 @fasttime |
| 194 | + |
| 195 | +**fasttime:** I don't have any other issues to discuss at this time |
| 196 | + |
| 197 | +**mdjermanovic:** I also don't have any other issues for today |
| 198 | + |
| 199 | +**nzakas:** Okay, let's talk about the release. |
| 200 | + |
| 201 | +**fasttime:** I can do the release tomorrow |
| 202 | + * 🙏 @nzakas |
| 203 | + |
| 204 | +**mdjermanovic:** Thanks! |
| 205 | + |
| 206 | +**fasttime:** It will be only `eslint` and `@eslint/js` I think |
| 207 | + * 👍 @nzakas, @mdjermanovic |
| 208 | + |
| 209 | +**fasttime:** Any PRs we would like to get merged? I don't see any. |
| 210 | + |
| 211 | +**nzakas:** Just the basePath one, I think |
| 212 | + |
| 213 | +**fasttime:** Oh, will it be ready tomorrow? |
| 214 | + |
| 215 | +**mdjermanovic:** I'll try to update it with the flag change in time, so if it gets two approvals, then it would be nice to include it. |
| 216 | + * 👍 @nzakas, @fasttime |
| 217 | + |
| 218 | +**nzakas:** Okay, I think that's all for today. Thanks everyone (and thanks @sam3k_ for the notes) |
| 219 | + |
| 220 | +**fasttime:** Thanks! |
| 221 | + |
| 222 | +**mdjermanovic:** Thanks 👋 |
0 commit comments