feat: Support namespace-based external marking (#1188)

* feat: Support namespace-based external marking

Allow marking entire package namespaces as external using the external query parameter.
For example, using ?external=@radix-ui will mark all @radix-ui/* packages as external.

This simplifies configuration when working with packages that have many sub-packages
from the same namespace, eliminating the need to list each package individually.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* chore: Remove accidentally committed binary file

Remove the esm.sh binary that was accidentally included in the previous commit.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: nicksrandall

server/build.go

@@ -569,8 +569,8 @@ func (ctx *BuildContext) buildModule(analyzeMode bool) (meta *BuildMeta, include
 					}
 
 					// bundles all dependencies in `bundle` mode, apart from peerDependencies and `?external` flag
-					if ctx.bundleMode == BundleDeps && !ctx.args.External.Has(toPackageName(specifier)) && !implicitExternal.Has(specifier) {
-						pkgName := toPackageName(specifier)
+					pkgName := toPackageName(specifier)
+					if ctx.bundleMode == BundleDeps && !ctx.args.External.Has(pkgName) && !isPackageInExternalNamespace(pkgName, ctx.args.External) && !implicitExternal.Has(specifier) {
 						_, ok := pkgJson.PeerDependencies[pkgName]
 						if !ok {
 							return esbuild.OnResolveResult{}, nil

server/build_args.go

@@ -226,6 +226,19 @@ func resolveBuildArgs(npmrc *NpmRC, installDir string, args *BuildArgs, esm EsmP
 					}
 					continue
 				}
+				// Check if this is a namespace pattern (e.g., @radix-ui)
+				isNamespace := strings.HasPrefix(name, "@") && !strings.Contains(name[1:], "/")
+				if isNamespace {
+					// Add all packages from this namespace that are in deps
+					for _, dep := range deps.Values() {
+						if strings.HasPrefix(dep, name+"/") {
+							external = append(external, dep)
+						}
+					}
+					// Also keep the namespace itself in external for pattern matching
+					external = append(external, name)
+					continue
+				}
 				// if the subModule externalizes the package entry
 				if name == esm.PkgName && esm.SubPath != "" {
 					external = append(external, name)

server/build_resolver.go

@@ -685,7 +685,8 @@ func (ctx *BuildContext) resolveExternalModule(specifier string, kind esbuild.Re
 	}()
 
 	// check `?external`
-	if ctx.externalAll || ctx.args.External.Has(toPackageName(specifier)) {
+	packageName := toPackageName(specifier)
+	if ctx.externalAll || ctx.args.External.Has(packageName) || isPackageInExternalNamespace(packageName, ctx.args.External) {
 		resolvedPath = specifier
 		return
 	}

server/dts_transform.go

@@ -189,7 +189,7 @@ func transformDTS(ctx *BuildContext, dts string, buildArgsPrefix string, marker
 		}
 
 		// respect `?external` query
-		if ctx.externalAll || ctx.args.External.Has(depPkgName) {
+		if ctx.externalAll || ctx.args.External.Has(depPkgName) || isPackageInExternalNamespace(depPkgName, ctx.args.External) {
 			return specifier, nil
 		}
 

server/path.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/Masterminds/semver/v3"
 	"github.com/esm-dev/esm.sh/internal/npm"
+	"github.com/ije/gox/set"
 	"github.com/ije/gox/utils"
 )
 
@@ -270,3 +271,18 @@ func toPackageName(specifier string) string {
 	name, _, _, _ := splitEsmPath(specifier)
 	return name
 }
+
+// isPackageInExternalNamespace checks if a package belongs to an external namespace
+// For example, if "@radix-ui" is in external, then "@radix-ui/react-dropdown" would match
+func isPackageInExternalNamespace(pkgName string, external set.ReadOnlySet[string]) bool {
+	for _, ext := range external.Values() {
+		// Check if ext is a namespace (starts with @ and has no /)
+		if strings.HasPrefix(ext, "@") && !strings.Contains(ext[1:], "/") {
+			// Check if the package belongs to this namespace
+			if strings.HasPrefix(pkgName, ext+"/") {
+				return true
+			}
+		}
+	}
+	return false
+}

test/build-args/external.test.ts

@@ -92,3 +92,22 @@ Deno.test("external nodejs builtin modules", async () => {
   assertEquals(res3.status, 200);
   assertStringIncludes(await res3.text(), ` from "node:buffer"`);
 });
+
+Deno.test("external namespace packages", async () => {
+  // Test that using @radix-ui as external marks all @radix-ui/* packages as external
+  {
+    const res = await fetch("http://localhost:8080/@radix-ui/[email protected]?external=@radix-ui");
+    res.body?.cancel();
+    assertEquals(res.status, 200);
+    const modulePath = res.headers.get("x-esm-path");
+    const res2 = await fetch("http://localhost:8080" + modulePath);
+    const code = await res2.text();
+    // All @radix-ui packages should be external
+    assertStringIncludes(code, 'from"@radix-ui/react-compose-refs"');
+    assertStringIncludes(code, 'from"@radix-ui/react-context"');
+    assertStringIncludes(code, 'from"@radix-ui/react-id"');
+    assertStringIncludes(code, 'from"@radix-ui/react-menu"');
+    assertStringIncludes(code, 'from"@radix-ui/react-primitive"');
+    assertStringIncludes(code, 'from"@radix-ui/react-use-controllable-state"');
+  }
+});