Fix getImportPath function (close #1166)

Author: ije

server/build.go

@@ -211,9 +211,10 @@ func (ctx *BuildContext) buildPath() {
 	if ctx.dev {
 		name += ".development"
 	}
-	if ctx.bundleMode == BundleDeps {
+	switch ctx.bundleMode {
+	case BundleDeps:
 		name += ".bundle"
-	} else if ctx.bundleMode == BundleFalse {
+	case BundleFalse:
 		name += ".nobundle"
 	}
 	ctx.path = fmt.Sprintf(
@@ -1520,9 +1521,10 @@ func (ctx *BuildContext) install() (err error) {
 
 	// - install dependencies in `BundleDeps` mode
 	// - install '@babel/runtime' and '@swc/helpers' if they are present in the dependencies in `BundleDefault` mode
-	if ctx.bundleMode == BundleDeps {
+	switch ctx.bundleMode {
+	case BundleDeps:
 		ctx.npmrc.installDependencies(ctx.wd, ctx.pkgJson, false, nil)
-	} else if ctx.bundleMode == BundleDefault {
+	case BundleDefault:
 		if v, ok := ctx.pkgJson.Dependencies["@babel/runtime"]; ok {
 			ctx.npmrc.installDependencies(ctx.wd, &npm.PackageJSON{Dependencies: map[string]string{"@babel/runtime": v}}, false, nil)
 		}

server/build_resolver.go

@@ -999,7 +999,7 @@ func (ctx *BuildContext) resolveDTS(entry BuildEntry) (string, error) {
 
 func (ctx *BuildContext) getImportPath(esm EsmPath, buildArgsPrefix string, externalAll bool) string {
 	if strings.HasSuffix(esm.SubPath, ".json") && ctx.existsPkgFile(esm.SubPath) {
-		return esm.Name() + "/" + esm.SubPath + "?module"
+		return "/" + esm.Name() + "/" + esm.SubPath + "?module"
 	}
 	asteriskPrefix := ""
 	if externalAll {

server/npmrc.go

@@ -126,12 +126,10 @@ func (npmrc *NpmRC) getRegistryByPackageName(packageName string) *NpmRegistry {
 	return &npmrc.NpmRegistry
 }
 
-type versionResolver func(metadata *npm.PackageMetadata, version string) (string, error)
-
 func (npmrc *NpmRC) fetchPackageMetadata(pkgName string, version string, useVersionSpecificEndpoint bool) (*npm.PackageMetadata, *npm.PackageJSONRaw, error) {
 	reg := npmrc.getRegistryByPackageName(pkgName)
 	regUrl := reg.Registry + pkgName
-	
+
 	if useVersionSpecificEndpoint && strings.HasPrefix(regUrl, npmRegistry) {
 		regUrl += "/" + version
 	}
@@ -286,7 +284,7 @@ func (npmrc *NpmRC) getPackageInfoByDate(pkgName string, dateVersion string) (pa
 
 	reg := npmrc.getRegistryByPackageName(pkgName)
 	cacheKey := reg.Registry + pkgName + "@date=" + dateVersion
-	
+
 	return withCache(cacheKey, time.Duration(config.NpmQueryCacheTTL)*time.Second, func() (*npm.PackageJSON, string, error) {
 		metadata, _, err := npmrc.fetchPackageMetadata(pkgName, dateVersion, false)
 		if err != nil {
@@ -308,7 +306,6 @@ func (npmrc *NpmRC) getPackageInfoByDate(pkgName string, dateVersion string) (pa
 	})
 }
 
-
 func (npmrc *NpmRC) installPackage(pkg npm.Package) (packageJson *npm.PackageJSON, err error) {
 	installDir := path.Join(npmrc.StoreDir(), pkg.String())
 	packageJsonPath := path.Join(installDir, "node_modules", pkg.Name, "package.json")

test/issue-1166/test.ts

@@ -0,0 +1,12 @@
+import { assert, assertEquals } from "jsr:@std/assert";
+
+// change the import path to the module you want to test
+import { parse } from "http://localhost:8080/[email protected]";
+
+// related issue: https://github.com/esm-dev/esm.sh/issues/1161
+Deno.test("testing name", () => {
+  const config = parse("BASIC=basic"); // will return an object
+  assertEquals(typeof config, "object");
+  assert(config);
+  assertEquals(config.BASIC, "basic");
+});