fix: analyze splitting regardless even when sideEffects: false (#1179)

Currently we don't analyze splitting when `sideEffects: false`. This can
result in duplication of symbols in shared files of entry-points. Even
if there are no side effects, this duplication can cause issues with
singletons or identify comparisons.

Author: devversion

server/build.go

@@ -147,7 +147,7 @@ func (ctx *BuildContext) Build() (meta *BuildMeta, err error) {
 	}
 
 	// analyze splitting modules
-	if !ctx.pkgJson.SideEffectsFalse && ctx.bundleMode == BundleDefault && ctx.pkgJson.Exports.Len() > 1 {
+	if ctx.bundleMode == BundleDefault && ctx.pkgJson.Exports.Len() > 1 {
 		ctx.status = "analyze"
 		err = ctx.analyzeSplitting()
 		if err != nil {

test/issue-1178/test.ts

@@ -0,0 +1,32 @@
+import { assert, assertEquals } from "jsr:@std/assert";
+
+// Needed as some Angular classes would need to be compiled.
+import "http://localhost:8080/@angular/[email protected]";
+
+import {
+  FactoryProvider,
+  Provider,
+  RendererFactory2,
+} from "http://localhost:8080/@angular/[email protected]";
+import { ɵDomRendererFactory2 } from "http://localhost:8080/@angular/[email protected]";
+import { provideAnimations } from "http://localhost:8080/@angular/[email protected]/animations";
+
+// related issue: https://github.com/esm-dev/esm.sh/issues/1178
+Deno.test(
+  "testing identity of classes matches between entry-points",
+  () => {
+    const renderFactoryProvider = provideAnimations()
+      .find((r: Provider): r is FactoryProvider =>
+        (r as Partial<FactoryProvider>).provide === RendererFactory2
+      );
+    assert(
+      renderFactoryProvider !== undefined,
+      "Expected renderer factory provider to be found.",
+    );
+    assertEquals(
+      renderFactoryProvider.deps?.[0],
+      ɵDomRendererFactory2,
+      "Expected identity of DomRendererFactory to match between entry-points.",
+    );
+  },
+);