AttributeError: 'ListWithProvenance' object has no attribute 'get'

[chrisdane]

On levante and esm_tools release, I get

which esm_tools
/work/ab1095/a270073/sw/py/pkgs/bin/esm_tools
esm_tools --version
esm_tools, version 6.61.1

cd /home/a/a270073/esm/runscripts/awicm-1.0-recom
esm_runscripts awicm_recom_levante_ssp.run.yaml -e bla -c

Initializing run_number=1 and date=2015-01-01
Traceback (most recent call last):
  File "/work/ab1095/a270073/sw/py/pkgs/bin/esm_runscripts", line 33, in <module>
    sys.exit(load_entry_point('esm-tools', 'console_scripts', 'esm_runscripts')())
  File "/home/a/a270073/esm/esm_tools/src/esm_runscripts/cli.py", line 236, in main
    setup = SimulationSetup(command_line_config=command_line_config)
  File "/home/a/a270073/esm/esm_tools/src/esm_runscripts/sim_objects.py", line 113, in __init__
    self.config = prepare.run_job(self.config)
  File "/home/a/a270073/esm/esm_tools/src/esm_runscripts/prepare.py", line 19, in run_job
    helpers.evaluate(config, "prepare", "prepare_recipe")
  File "/home/a/a270073/esm/esm_tools/src/esm_runscripts/helpers.py", line 75, in evaluate
    config = esm_plugin_manager.work_through_recipe(
  File "/home/a/a270073/esm/esm_tools/src/esm_plugin_manager/esm_plugin_manager.py", line 159, in work_through_recipe
    config = getattr(submodule, workitem)(config)
  File "/home/a/a270073/esm/esm_tools/src/esm_runscripts/batch_system.py", line 791, in find_openmp
    omp_num_threads = str(config[model].get("omp_num_threads", 1))
AttributeError: 'ListWithProvenance' object has no attribute 'get'

(same error if esm_tools are installed to default ~/.local.)

Thanks and cheers!

[mandresm]

Hi @chrisdane,

I think the problems are in your further_readings, you need to specify the section on them since a while, so for example, for fesom_output_production.yaml it all needs to be nested under fesom.

An explanation on why we made this change:

On our way of fixing a lot of bad design choices and problems with inconsistent merging and resolving of choose_blocks and the environment_changes hell (environment_changes do not exist anymore, see https://esm-tools.readthedocs.io/en/latest/esm_environment.html for more info), a year ago we made a lot of backend changes. With those we also enforced that all yamls files should share the same structure, and their root keys should always be the sections, meaning general, fesom, jsbash, echam, computer ... We made these changes in all components like the echam.yaml so that you would not feel the transition, and run tests that made sure nothing was changed from the model's perspective, but we have no control on further_readings that you were using.

We need to handle this error so that it tells you what is exactly happening, so that'll be something I'll take care of.

Please, let me know if nesting the content of these files in their respective model keys solves it.

[mandresm]

I tried the solution and I am getting passed the check without problems. I'd would still recommend to check that everything with the stream and output configuration makes sense

[chrisdane]

Thanks a lot!

[mandresm]

I'm opening it because I am working on an error handling to catch this and tell the user what's going on.