Change error handling to follow typical ESMF patterns

Author: billsacks

src/Infrastructure/IO/src/ESMCI_IO_NetCDF.C

@@ -643,8 +643,7 @@ void IO_NetCDF::destruct(void) {
     ESMC_TypeKind_Flag  arrayType = ncToEsmcType(nctype);
     if (arrayType == ESMF_NOKIND) {
       string errstr = string(": problem converting NetCDF type to ESMF type");
-      ESMC_LogDefault.Write(errstr, ESMC_LOGMSG_ERROR, ESMC_CONTEXT);
-      *rc = ESMF_FAILURE;
+      ESMC_LogDefault.MsgFoundError(ESMC_RC_ARG_VALUE, errstr, ESMC_CONTEXT, rc);
       return thisArray;
     }
 
@@ -886,7 +885,7 @@ void IO_NetCDF::destruct(void) {
     nc_type            ncType = esmcToNcType(esmcType);
     if (ncType == NC_UNSPECIFIED) {
       string errstr = string(": problem converting ESMF type to NetCDF type");
-      ESMC_LogDefault.MsgFoundError(ESMF_FAILURE, errstr, ESMC_CONTEXT, &localrc);
+      ESMC_LogDefault.MsgFoundError(ESMC_RC_ARG_VALUE, errstr, ESMC_CONTEXT, &localrc);
       return localrc;
     }
 
@@ -994,7 +993,7 @@ void IO_NetCDF::destruct(void) {
 
     default:
       string errstr = string(": unhandled NetCDF type");
-      ESMC_LogDefault.MsgFoundError(ESMF_FAILURE, errstr, ESMC_CONTEXT, &localrc);
+      ESMC_LogDefault.MsgFoundError(ESMC_RC_NOT_IMPL, errstr, ESMC_CONTEXT, &localrc);
       return localrc;
     }