Skip to content

Commit 80e5760

Browse files
fix openmm tests
1 parent 8049e6b commit 80e5760

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

tests/openmm_md/jobs/test_base.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,13 @@ def test_add_reporters(interchange, tmp_path):
3333
assert next_dcd[5] is True # enforce periodic boundaries
3434
assert isinstance(sim.reporters[1], StateDataReporter)
3535
next_state = sim.reporters[1].describeNextReport(sim)
36-
assert next_state[0] == 50 # steps until next report
36+
37+
# steps until next report
38+
# TODO: make test more robust
39+
if isinstance(next_state, dict):
40+
assert next_state["steps"] == 50
41+
else:
42+
assert next_state[0] == 50
3743

3844

3945
def test_resolve_attr():
@@ -180,14 +186,12 @@ def do_nothing(self, sim, dir_name):
180186
report_velocities=True,
181187
)
182188

183-
with pytest.raises(RuntimeError):
184-
run_job(maker1.make(interchange))
185-
# run_job(base_job)
186-
187189
import MDAnalysis
188190
from packaging.version import Version
189191

190192
if Version(MDAnalysis.__version__) < Version("2.8.0"):
193+
with pytest.raises(RuntimeError):
194+
run_job(maker1.make(interchange))
191195
return
192196

193197
maker2 = BaseOpenMMMaker(

tests/openmm_md/test_utils.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
increment_name,
1313
)
1414

15+
"""
16+
TODO: Needs revision
17+
"""
18+
1519

1620
@pytest.mark.skip("annoying test")
1721
def test_download_xml(tmp_path: Path) -> None:

0 commit comments

Comments
 (0)