feat: Update to remove display task (espp update) and fix sa for carts (#94)

* feat: Update to remove display task (espp update) and fix sa for carts

* fix sa

Author: finger563

components/box-emu/example/main/box_emu_example.cpp

@@ -154,8 +154,8 @@ static size_t load_audio() {
   }
 
   // these are configured in the CMakeLists.txt file
-  extern const char wav_start[] asm("_binary_click_wav_start");
-  extern const char wav_end[] asm("_binary_click_wav_end");
+  extern const char wav_start[] asm("_binary_click_wav_start"); // cppcheck-suppress syntaxError
+  extern const char wav_end[] asm("_binary_click_wav_end");    // cppcheck-suppress syntaxError
 
   // -1 due to the size being 1 byte too large, I think because end is the byte
   // immediately after the last byte in the memory but I'm not sure - cmm 2022-08-20

components/box-emu/src/box-emu.cpp

@@ -50,15 +50,8 @@ bool BoxEmu::initialize_box() {
     return false;
   }
   static constexpr size_t pixel_buffer_size = espp::EspBox::lcd_width() * num_rows_in_framebuffer;
-  static constexpr int update_period_ms = 16;
-  espp::Task::BaseConfig display_task_config = {
-    .name = "Display",
-    .stack_size_bytes = 6 * 1024,
-    .priority = 10,
-    .core_id = 1,
-  };
   // initialize the LVGL display for the esp-box
-  if (!box.initialize_display(pixel_buffer_size, display_task_config, update_period_ms)) {
+  if (!box.initialize_display(pixel_buffer_size)) {
     logger_.error("Failed to initialize display!");
     return false;
   }

components/espp

@@ -36,6 +36,7 @@ struct fb fb;
 struct pcm pcm;
 static uint8_t currentBuffer = 0;
 
+// cppcheck-suppress constParameterPointer
 extern "C" void die(char *fmt, ...) {
   // do nothing...
 }

components/gbc/src/gameboy.cpp

@@ -238,6 +238,7 @@ extern "C" void osd_getinput(void)
 	}
 }
 
+// cppcheck-suppress constParameterPointer
 extern "C" void osd_getmouse(int *x, int *y, int *button)
 {
 }

components/nes/src/video_audio.cpp

@@ -37,6 +37,7 @@ void sms_frame(int skip_render);
 void sms_init(void);
 void sms_reset(void);
 
+// cppcheck-suppress constParameterPointer
 extern "C" void system_manage_sram(uint8 *sram, int slot, int mode) {
 }
 

components/sms/src/sms.cpp

@@ -171,13 +171,11 @@ class Cart {
       // now resume the menu
       menu_->resume();
       display_->force_refresh();
-      display_->resume();
       // wait here until the menu is no longer shown
       while (!menu_->is_paused()) {
         using namespace std::chrono_literals;
         std::this_thread::sleep_for(100ms);
       }
-      display_->pause();
       // make sure to clear the screen before we resume the game
       espp::St7789::clear(0,0,320,240);
       // only run the post_menu if we are still running

main/cart.hpp

@@ -14,7 +14,7 @@ class GbcCart : public Cart {
     init();
   }
 
-  ~GbcCart() {
+  virtual ~GbcCart() override {
     deinit();
   }
 

main/gbc_cart.hpp

@@ -14,7 +14,7 @@ class GenesisCart : public Cart {
     init();
   }
 
-  ~GenesisCart() {
+  virtual ~GenesisCart() override {
     logger_.info("~GenesisCart()");
     deinit();
   }

main/genesis_cart.hpp

@@ -104,8 +104,6 @@ extern "C" void app_main(void) {
       // Cart handles platform specific code, state management, etc.
       {
         std::unique_ptr<Cart> cart(make_cart(selected_rom, display));
-
-        display->pause();
         if (cart) {
           while (cart->run());
         } else {
@@ -128,6 +126,5 @@ extern "C" void app_main(void) {
 
     gui.resume();
     display->force_refresh();
-    display->resume();
   }
 }