TSL2591 Component Kconfig File Question

[jChereck]

I'm trying to use the TSL2591 component in a project, and I noticed that configuration options don't appear in idf.py menuconfig, I think this is because the config file is named kconfig.i2c instead of kconfig. I would think it should have the second name, that way the defaults would show up to be edited and could be set in a kconfig.defaults file in the root of my repo.

That said I'm very new to esp-idf and likely just don't understand something here.

[trombik]

Kconfig.i2c is named deliberately so. The file is not for the component, but for examples.

https://github.com/esp-idf-lib/tsl2591/blob/d8d7e8bdf4b5fa623b9d714a5631eff25d74e748/examples/default/main/Kconfig.projbuild#L1-L3

[jChereck]

Ah, because it is just used as a variable inside the tsl2591_test method, and you expect any project using i2c will be creating their own variables for the SDA and SCL pins? But if there were more things to configure internally a kconfig file would likely be included ex: readings in foot candles vs lumens?

[trombik]

No, it has nothing to do with users, i.e. you. The file is for our convenience. We have many i2c components and the same configuration is used in many examples, e.g. SDA and SCL pins for different chips.

The component itself does not, and should not, define i2c pin numbers. It is your responsibility to define ones.