Checking installed version: "❌ Rust"

[vikblom]

Hi,

I'm using this tool to generate a config with just defaults. Specifcally

> esp-generate --version
esp-generate 0.3.1

After creation the tool prints:

> esp-generate --chip=esp32s3 -O . foo 

Checking installed versions
❌ Rust
🆗 espflash
🆗 probe-rs

What is check is behind the "❌ Rust" and how can I fix that?

It would be helpful if this information was included in the printout.

Thanks!

[bugadani]

Please give us the output of rustc +esp --version (just so we know whether there is a bug in the version comparison tool, or we can get away with printing some helpful hints)

[vikblom]

Sure, it is

> rustc +esp --version
rustc 1.84.0-nightly (b0bd11bcc 2025-01-10) (1.84.0.0)

> which rustc
/home/viktor/.rustup/toolchains/esp/bin/rustc

espup defaulted me to 1.85.0-nightly but then I got a bunch of errors for

error[E0787]: the `asm!` macro is not allowed in naked functions

(I guess because of rust-lang/rust#128651 ?)

So my setup is based on espup install -v 1.84.0 and sourced envs from export-esp.sh.

[bjoernQ]

The check is here:

esp-generate/src/check.rs

Lines 19 to 45 in e0cfa7b

	pub fn check(chip: Chip) {
	// TODO: check +nightly if needed
	let rust_version = get_version(
	"rustc",
	if chip.is_xtensa() {
	&["+esp"]
	} else {
	&["+stable"]
	},
	);
	let espflash_version = get_version("espflash", &[]);
	let probers_version = get_version("probe-rs", &[]);
	println!("\nChecking installed versions");
	print_result("Rust", check_version(rust_version, 1, 84, 0));
	print_result("espflash", check_version(espflash_version, 3, 3, 0));
	print_result("probe-rs", check_version(probers_version, 0, 25, 0));
	}
	fn print_result(name: &str, check_result: CheckResult) {
	match check_result {
	CheckResult::Ok => println!("🆗 {}", name),
	CheckResult::WrongVersion => println!("🛑 {}", name),
	CheckResult::NotFound => println!("❌ {}", name),
	}
	}

The X means not found at all

Did you source export-esp-sh before running esp-generate?

[vikblom]

@bjoernQ Well I'm not using bash so I'm not sourcing it directly. But I've exported the variables it sets.

I took the code in check.rs and compiled it into a standalone Rust. Running that gives me all OK. So it would seem my path modification are lost somewhere along the way in espup?

Does espup invoke this check through a subprogram/script in any way?

[vikblom]

Tried with esp-generate built from source and that finds rustc OK. I was getting esp-generate as an os package so there must be some issue with how its packaged.

Sorry for the nothingburger issue. But do please consider augmenting ❌ with some text. Thanks for the troubelshooting help!

[bugadani]

Let's keep this open until we add some advice what the various things mean.