ci(test-size): takes example name (#5264)

JurajSadel · web-flow · commit 0fb66ac60280 · 2026-03-26T12:59:18.000Z
* ci(test-size): takes example name

* help message
diff --git a/.github/workflows/binary-size.yml b/.github/workflows/binary-size.yml
@@ -7,6 +7,10 @@ on:
         description: "Pull request number to analyze"
         required: true
         type: string
+      example_name:
+        description: "Example directory name to analyze (e.g., embassy_dhcp)"
+        required: true
+        type: string
 
 jobs:
   binary-size:
@@ -22,16 +26,10 @@ jobs:
         target:
           - soc: esp32c3
             rust-target: riscv32imc-unknown-none-elf
-            dir-qa: ./qa-test
-            dir-dhcp: ./examples/wifi/embassy_dhcp
           - soc: esp32c6
             rust-target: riscv32imac-unknown-none-elf
-            dir-qa: ./qa-test
-            dir-dhcp: ./examples/wifi/embassy_dhcp
           - soc: esp32
             rust-target: xtensa-esp32-none-elf
-            dir-qa: ./qa-test
-            dir-dhcp: ./examples/wifi/embassy_dhcp
 
     steps:
       - name: Setup Rust
@@ -82,45 +80,82 @@ jobs:
           cd $HOME
           mkdir results
 
-      - name: Build PR QA Binary
-        working-directory: ${{ matrix.target.dir-qa }}
+      - name: Build PR example
         run: |
-          cargo build --release --bin sleep_timer --features ${{ matrix.target.soc }} --target ${{ matrix.target.rust-target }}
-          cp target/${{ matrix.target.rust-target }}/release/sleep_timer $HOME/results/pr_qa_build_${{ matrix.target.soc }}.elf
+          set -euo pipefail
+
+          RAW_INPUT="${{ github.event.inputs.example_name }}"
+          cargo xtask build examples $RAW_INPUT --chip "${{ matrix.target.soc }}"
+
+          EXAMPLE_NAME=$(echo "$RAW_INPUT" | awk '{print $1}')
+          BIN_NAME=$(echo "$EXAMPLE_NAME" | tr '_' '-')
+
+          BIN=$(
+          find target qa-test/target examples -type f \
+            -path "*/release/${BIN_NAME}" \
+            -executable \
+            2>/dev/null | head -n 1 || true
+          )
+
+          # Fallback to `_` instead of `-`
+          if [ -z "$BIN" ]; then
+          BIN=$(find target qa-test/target examples -type f \
+            -path "*/release/${EXAMPLE_NAME}" \
+            -executable \
+            2>/dev/null | head -n 1 || true)
+          fi
 
-      - name: Build PR DHCP Binary
-        working-directory: ${{ matrix.target.dir-dhcp }}
-        run: |
-          # Build
-          cargo build --release --features ${{ matrix.target.soc }} --target ${{ matrix.target.rust-target }}
-          # Copy PR binary to parent directory (outside workspace)
-          cp target/${{ matrix.target.rust-target }}/release/embassy-dhcp $HOME/results/pr_dhcp_build_${{ matrix.target.soc }}.elf
+          if [ -z "$BIN" ]; then
+            echo "Error: Built PR binary not found"
+            exit 1
+          fi
 
-      # Checkout base (current default branch HEAD) for comparison
+          cp "$BIN" $HOME/results/pr_qa_build_${{ matrix.target.soc }}.elf
+
+      # Checkout base
       - name: Checkout Base Commit
         uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
-      - name: Build Base QA Binary
-        working-directory: ${{ matrix.target.dir-qa }}
+      - name: Build Base example
         run: |
-          cargo build --release --bin sleep_timer --features ${{ matrix.target.soc }} --target ${{ matrix.target.rust-target }}
-          cp target/${{ matrix.target.rust-target }}/release/sleep_timer $HOME/results/base_qa_build_${{ matrix.target.soc }}.elf
+          set -euo pipefail
+          cargo clean
+
+          RAW_INPUT="${{ github.event.inputs.example_name }}"
+          cargo xtask build examples $RAW_INPUT --chip "${{ matrix.target.soc }}"
+
+          EXAMPLE_NAME=$(echo "$RAW_INPUT" | awk '{print $1}')
+          BIN_NAME=$(echo "$EXAMPLE_NAME" | tr '_' '-')
+
+          BIN=$(
+          find target qa-test/target examples -type f \
+            -path "*/release/${BIN_NAME}" \
+            -executable \
+            2>/dev/null | head -n 1 || true
+          )
+
+          # Fallback to `_` instead of `-`
+          if [ -z "$BIN" ]; then
+          BIN=$(find target qa-test/target examples -type f \
+            -path "*/release/${EXAMPLE_NAME}" \
+            -executable \
+            2>/dev/null | head -n 1 || true)
+          fi
 
-      - name: Build Base DHCP Binary
-        working-directory: ${{ matrix.target.dir-dhcp }}
-        run: |
-          cargo build --release --features ${{ matrix.target.soc }} --target ${{ matrix.target.rust-target }}
-          cp target/${{ matrix.target.rust-target }}/release/embassy-dhcp $HOME/results/base_dhcp_build_${{ matrix.target.soc }}.elf
+          if [ -z "$BIN" ]; then
+            echo "Error: Built BASE binary not found"
+            exit 1
+          fi
+
+          cp "$BIN" $HOME/results/base_qa_build_${{ matrix.target.soc }}.elf
 
       - name: Copy binaries to workspace for Bloaty
         run: |
           # Copy files from $HOME/results to current workspace
           cp $HOME/results/base_qa_build_${{ matrix.target.soc }}.elf ./
           cp $HOME/results/pr_qa_build_${{ matrix.target.soc }}.elf ./
-          cp $HOME/results/base_dhcp_build_${{ matrix.target.soc }}.elf ./
-          cp $HOME/results/pr_dhcp_build_${{ matrix.target.soc }}.elf ./
           ls -la *.elf
 
       # Diffs and Artifacts
@@ -140,23 +175,6 @@ jobs:
           echo "\`\`\`" >> result-pr-${{ matrix.target.soc }}.txt
           echo "EOF" >> result-pr-${{ matrix.target.soc }}.txt
 
-      - name: Run Bloaty DHCP Diff
-        id: bloaty-dhcp
-        uses: carlosperate/bloaty-action@v1
-        with:
-          bloaty-args: -d sections --domain vm --source-filter "^.text$|^.data|^.bss|^.rwdata|^.rwtext" base_dhcp_build_${{ matrix.target.soc }}.elf -- pr_dhcp_build_${{ matrix.target.soc }}.elf
-          output-to-summary: false
-        continue-on-error: true
-
-      - name: Save Bloaty DHCP output
-        run: |
-          echo "DHCP_DIFF<<EOF" >> result-pr-${{ matrix.target.soc }}.txt
-          echo "\`\`\`" >> result-pr-${{ matrix.target.soc }}.txt
-          echo "${{ steps.bloaty-dhcp.outputs.bloaty-output || 'N/A' }}" >> result-pr-${{ matrix.target.soc }}.txt
-          echo "\`\`\`" >> result-pr-${{ matrix.target.soc }}.txt
-          echo "EOF" >> result-pr-${{ matrix.target.soc }}.txt
-          cat result-pr-${{ matrix.target.soc }}.txt
-
       - name: Upload Result Artifact
         uses: actions/upload-artifact@v6
         with:
diff --git a/.github/workflows/dispatch.yml b/.github/workflows/dispatch.yml
@@ -559,7 +559,7 @@ jobs:
             - `/hil quick` — run a quick HIL matrix (only `ESP32-S3` (Xtensa) and `ESP32-C6` (RISC-V) tests)
             - `/hil full`  — run the full HIL matrix for all supported chips
             - `/hil <chip> [<chip> ...]` — run the full HIL tests **only** for the listed chips
-            - `/test-size` — run binary size analysis for this PR
+            - `/test-size <example_name>` — run binary size analysis for this PR for specified example, for `qa-test` example use `<example_name> --package qa-test`
             - You can optionally append `--test <name>[,<name>...]` to any `/hil` command to only run selected tests.
             If you aren't a repository **member/owner**, you must be **trusted for this PR**.
             Maintainers can grant access with a `trusted-author` label or with:
@@ -578,14 +578,33 @@ jobs:
       startsWith(github.event.comment.body, '/test-size')
     runs-on: ubuntu-latest
     steps:
+      - name: Extract example name from comment
+        id: extract
+        run: |
+          # Expected format: /test-size example_name
+          COMMENT="${{ github.event.comment.body }}"
+
+          # Remove the /test-size prefix and trim whitespace
+          EXAMPLE_NAME=$(echo "$COMMENT" | sed 's|/test-size||' | xargs)
+
+          if [ -z "$EXAMPLE_NAME" ]; then
+            echo "Error: No example name provided in comment"
+            echo "Expected format: /test-size example_name"
+            exit 1
+          fi
+
+          echo "example_name=$EXAMPLE_NAME" >> $GITHUB_OUTPUT
+          echo "Extracted example name: $EXAMPLE_NAME"
+
       - name: Dispatch Binary Size Analysis
         uses: benc-uk/workflow-dispatch@v1
         with:
           workflow: binary-size.yml
           ref: ${{ github.event.repository.default_branch }}
           inputs: |
             {
-              "pr_number": "${{ github.event.issue.number }}"
+              "pr_number": "${{ github.event.issue.number }}",
+              "example_name": "${{ steps.extract.outputs.example_name }}"
             }
 
       - name: Confirm in PR
diff --git a/xtask/src/commands/generate_report.rs b/xtask/src/commands/generate_report.rs
@@ -67,26 +67,13 @@ pub fn generate_report(workspace: &Path, args: ReportArgs) -> Result<()> {
             &code_fence_re,
             &leading_ws_re,
         );
-        let dhcp_diff = extract_block(
-            &content,
-            "DHCP_DIFF<<EOF",
-            "EOF",
-            &exclude_re,
-            &code_fence_re,
-            &leading_ws_re,
-        );
 
         writeln!(combined, "### `{}`\n", soc)?;
         writeln!(
             combined,
-            "##### sleep-timer Diff (PR vs. Base)\n```\n{}\n```\n",
+            "##### Diff (PR vs. Base)\n```\n{}\n```\n",
             qa_diff
         )?;
-        writeln!(
-            combined,
-            "##### embassy-dhcp Diff (PR vs. Base)\n```\n{}\n```\n",
-            dhcp_diff
-        )?;
     }
 
     Ok(())
