Skip to content

Commit a2143b5

Browse files
JurajSadelJurajSadel
committed
review comments
1 parent 748d0d3 commit a2143b5

File tree

11 files changed

+26
-26
lines changed

11 files changed

+26
-26
lines changed

‎hil-test/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ Our self-hosted runners have the following setup:
113113

114114
[connection_c2]: https://docs.espressif.com/projects/esp-idf/en/stable/esp32c2/api-guides/jtag-debugging/configure-other-jtag.html#configure-hardware
115115
[connection_s2]: https://docs.espressif.com/projects/esp-idf/en/stable/esp32s2/api-guides/jtag-debugging/configure-other-jtag.html#configure-hardware
116-
[connection_esp32]: https://docs.espressif.com/projects/esp-idf/en/v5.3.1/esp32/api-guides/jtag-debugging/configure-other-jtag.html#configure-hardware
116+
[connection_esp32]: https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-guides/jtag-debugging/configure-other-jtag.html#configure-hardware.html#configure-hardware
117117
[`hil.yml`]: https://github.com/esp-rs/esp-hal/blob/main/.github/workflows/hil.yml
118118
[setup]: #rpi-setup
119119

‎hil-test/tests/gpio.rs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//! GPIO Test
22
//!
33
//! Folowing pins are used:
4-
//! GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5-
//! GPIO3 / GPIO10 / GPIO26 (esp32s2 / esp32s3 / esp32)
4+
//! GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
5+
//! GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
66
77
//% CHIPS: esp32 esp32c2 esp32c3 esp32c6 esp32h2 esp32s2 esp32s3
88
//% FEATURES: generic-queue
@@ -27,15 +27,15 @@ static INPUT_PIN: Mutex<RefCell<Option<Input<'static, TestGpio1>>>> =
2727
Mutex::new(RefCell::new(None));
2828

2929
cfg_if::cfg_if! {
30-
if #[cfg(not(any(esp32, esp32s2, esp32s3)))] {
31-
pub type TestGpio1 = GpioPin<2>;
32-
pub type TestGpio2 = GpioPin<3>;
30+
if #[cfg(esp32)] {
31+
pub type TestGpio1 = GpioPin<26>;
32+
pub type TestGpio2 = GpioPin<27>;
3333
} else if #[cfg(any(esp32s2, esp32s3))] {
3434
pub type TestGpio1 = GpioPin<9>;
3535
pub type TestGpio2 = GpioPin<10>;
36-
} else if #[cfg(esp32)] {
37-
pub type TestGpio1 = GpioPin<26>;
38-
pub type TestGpio2 = GpioPin<27>;
36+
} else {
37+
pub type TestGpio1 = GpioPin<2>;
38+
pub type TestGpio2 = GpioPin<3>;
3939
}
4040
}
4141

‎hil-test/tests/spi_full_duplex.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//!
33
//! Folowing pins are used:
44
//! SCLK GPIO0
5-
//! MISO GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5+
//! MISO GPIO2(esp32s2) / GPIO9(esp32s3) / GPIO26(esp32)
66
//! MOSI GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
77
//!
88
//! Connect MISO and MOSI pins.

‎hil-test/tests/spi_full_duplex_dma.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
//!
33
//! Folowing pins are used:
44
//! SCLK GPIO0
5-
//! MISO GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
6-
//! MOSI GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
5+
//! MISO GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
6+
//! MOSI GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
77
//!
88
//! Connect MISO and MOSI pins.
99

‎hil-test/tests/spi_half_duplex_read.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
//!
33
//! Folowing pins are used:
44
//! SCLK GPIO0
5-
//! MISO GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5+
//! MISO GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
66
//!
7-
//! GPIO GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 /esp32)
7+
//! GPIO GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
88
//!
99
//! Connect MISO and GPIO pins.
1010

‎hil-test/tests/spi_half_duplex_write.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
//!
33
//! Following pins are used:
44
//! SCLK GPIO0
5-
//! MOSI GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5+
//! MOSI GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
66
//!
7-
//! PCNT GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
7+
//! PCNT GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
88
//!
99
//! Connect MOSI and PCNT pins.
1010

‎hil-test/tests/twai.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//! TWAI test
22
//!
33
//! Folowing pins are used:
4-
//! TX GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5-
//! RX GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
4+
//! TX GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
5+
//! RX GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
66
//!
77
//! Connect TX and RX pins.
88

‎hil-test/tests/uart.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//! UART Test
22
//!
33
//! Folowing pins are used:
4-
//! TX GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5-
//! RX GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
4+
//! TX GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
5+
//! RX GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
66
//!
77
//! Connect TX and RX pins.
88

‎hil-test/tests/uart_async.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//! UART Test
22
//!
33
//! Folowing pins are used:
4-
//! TX GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5-
//! RX GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
4+
//! TX GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
5+
//! RX GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
66
//!
77
//! Connect TX and RX pins.
88

‎hil-test/tests/uart_tx_rx.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
//! UART TX/RX Test
22
//!
33
//! Folowing pins are used:
4-
//! TX GPIO2 / GPIO9 / GPIO26 (esp32s2 / esp32s3 / esp32)
5-
//! RX GPIO3 / GPIO10 / GPIO27 (esp32s2 / esp32s3 / esp32)
4+
//! TX GPIO2 / GPIO9 (esp32s2 / esp32s3) / GPIO26 (esp32)
5+
//! RX GPIO3 / GPIO10 (esp32s2 / esp32s3) / GPIO27 (esp32)
66
//!
77
//! Connect TX and RX pins.
88

0 commit comments

Comments
 (0)