Skip to content

Commit be59ca5

Browse files
authored
Unbreak changelogs (#4332)
1 parent 3517f1b commit be59ca5

File tree

4 files changed

+22
-10
lines changed

4 files changed

+22
-10
lines changed

esp-hal/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2626
- ESP32: Expose `psram_vaddr_mode` via `PsramConfig` (#3990)
2727
- ESP32-S3: Expose more `Camera` config options (#3996)
2828
- Functions to query chip revision for every chip (#3892)
29-
- ESP32-S3: Add RtcI2c driver (#0000)
29+
- ESP32-S3: Add RtcI2c driver (#4016)
3030
- `ShaBackend, Sha<N>Context`: Work-queue based SHA driver (#4013)
3131
- I2S: `i2s::master::Config` with support for more TDM mode standards (#3985)
3232
- ESP32: support outputting the main I2S clock signal (#4128)

esp-radio/CHANGELOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3232
- `esp-ieee802154` package has been folded into `esp-radio`, it's now alloc. (#3861, #3890)
3333
- `ble`, `esp-now`, `csi`, `sniffer`, `esp-ieee802154` and `smoltcp` features and APIs marked as unstable (#3865)
3434
- Update bt-hci version to add additional HCI commands (#3920)
35-
- A number of enums/structs have been marked as `#[non_exhaustive]` (#3981, #4017)
36-
- `AuthMethod`, `Protocol`, `AccessPointInfo`, `AccessPointConfiguration`, `ClientConfiguration`, `Capability`, `Configuration`, `WifiEvent`, `InternalWifiError`, `ScanTypeConfig`, `WifiState`, and `WifiMode`
35+
- `AuthMethod`, `Protocol`, `AccessPointInfo`, `AccessPointConfiguration`, `ClientConfiguration`, `Capability`, `Configuration`, `WifiEvent`, `InternalWifiError`, `ScanTypeConfig`, `WifiState`, and `WifiMode` have been marked as `#[non_exhaustive]` (#3981, #4017)
3736
- The `Configuration`, `ClientConfiguration`, `AccessPointConfiguration`, and `EapClientConfiguration` enums have been renamed to `ModeConfig`, `ClientConfig`, `AccessPointConfig`, and `EapClientConfig` (#3994, #4278)
38-
- Error types implements `core::error:Error`
37+
- Error types implements `core::error:Error` (#3994, #4278)
3938
- Use `esp-phy` internally for PHY initialization (#3892)
4039
- `ap_state()` and `sta_state()` marked as stable (#4017)
4140
- `wifi_state()` marked as unstable (#4017)

xtask/src/changelog.rs

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,11 @@ impl ChangelogForVersion {
188188
current_group.lines.push(line);
189189
} else if line.trim().is_empty() {
190190
// Empty line, just skip
191-
} else {
192-
// Not ours any more.
191+
} else if line.starts_with("[") {
192+
// Link definitions in footer
193193
break;
194+
} else {
195+
bail!("Changelog line {} starts with unexpected character", line);
194196
}
195197
lines.next();
196198
}
@@ -273,9 +275,20 @@ impl ChangelogLine {
273275
.trim_end_matches('.') // normalize "(#pr)."
274276
.trim_end_matches(')')
275277
.split(',')
276-
.map(|pr| pr.trim().trim_start_matches('#').parse::<usize>())
277-
.collect::<Result<Vec<_>, _>>()
278-
.with_context(|| format!("Could not parse PR number {prs}"))?
278+
.map(|pr| {
279+
pr.trim()
280+
.trim_start_matches('#')
281+
.parse::<usize>()
282+
.with_context(|| format!("Could not parse PR number {prs}"))
283+
})
284+
.map(|pr| {
285+
if let Ok(0) = pr {
286+
bail!("PR number cannot be zero")
287+
} else {
288+
pr
289+
}
290+
})
291+
.collect::<Result<Vec<_>, _>>()?
279292
} else if indentation == 0 {
280293
bail!("Missing PR number");
281294
} else {

xtensa-lx/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323

2424
### Changed
2525

26-
* This crate no longer uses the `links` field in its `Cargo.toml` (#3697)
26+
- This crate no longer uses the `links` field in its `Cargo.toml` (#3697)
2727

2828
## [v0.11.0] - 2025-06-03
2929

0 commit comments

Comments
 (0)