Tidy up Camera according to latest guidelines (#3375)

* Tidy up `Camera` according to latest guidelines

* fmt

* enum

Author: Dominaezzz

esp-hal/CHANGELOG.md

@@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Moved numbered GPIO pin types from `esp_hal::gpio::GpioPin<N>` to `esp_hal::peripherals::GPION<'_>` (#3349)
 - Moved DMA channel types from `esp_hal::dma::DmaChannelN`/`esp_hal::dma::XYDmaChannel` to `esp_hal::peripherals::DMA_XY` (#3372)
 - `ParlIoFullDuplex`, `ParlIoTxOnly` and `ParlIoRxOnly` have been merged into `ParlIo` (#3366)
+- All `Camera` pins are now configured using `with_*()` methods (#3237)
 
 ### Fixed
 

esp-hal/MIGRATING-1.0.0-beta.0.md

@@ -224,3 +224,39 @@ The affected types in the `gpio::interconnect` module are:
 +     BurstConfig::default(),
   ).unwrap();
 ```
+
+## LCD_CAM Camera changes
+
+The data and ctrl pins of the camera have been split out into individual `with_*` methods.
+
+```diff
+- camera.with_ctrl_pins(vsync_pin, href_pin);
++ camera.with_vsync(vsync_pin).with_h_enable(href_pin);
++ config.with_vh_de_mode(VhdeMode::VsyncHsync);
+```
+
+```diff
+- camera.with_ctrl_pins_and_de(vsync_pin, hsync_pin, href_pin);
++ camera.with_vsync(vsync_pin).with_hsync(hsync_pin).with_h_enable(href_pin);
++ config.with_vh_de_mode(VhdeMode::De); // Needed to enable HSYNC pin
+```
+
+```diff
+- let data_pins = RxEightBits::new(
+-     peripherals.GPIO11,
+-     peripherals.GPIO9,
+-     peripherals.GPIO8,
+-     ....
+- );
+  let mut camera = Camera::new(
+      lcd_cam.cam,
+      peripherals.DMA_CH0,
+-     data_pins,
+-     config,
++     config.with_enable_2byte_mode(false) // If you were previously using RxEightBits (This is the default)
++     config.with_enable_2byte_mode(true) // If you were previously using RxSixteenBits
+  )?;
+
++ camera.with_data0(peripherals.GPIO11).with_data1(peripherals.GPIO9).with_dataX();
+
+```