Honor lint attributes for esp-rtos::main
#4359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Oct 15, 2025
| async fn __embassy_main(#fargs) #out { | ||
| #f_body | ||
| #(#lint_attrs)* | ||
| pub(crate) mod __main { |
There was a problem hiding this comment.
This module means the main function no longer shows up in rustdoc, right? Why is it necessary?
There was a problem hiding this comment.
we'd need to PR a change in https://github.com/embassy-rs/embassy/blob/main/embassy-executor-macros/src/macros/task.rs for that to work
I have never seen the main function showing up in docs 🤔 it's all doc-hidden AFAICS - so this looked like an straight forward solution without obvious drawbacks
bugadani
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This sparked from esp-rs/esp-generate#241 (comment)
Not sure if this needs a changelog entry
Testing
manual testing and inspecting the generated code